From patchwork Mon Sep 3 16:54:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10586181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A0D65A4 for ; Mon, 3 Sep 2018 16:56:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED0DB28A73 for ; Mon, 3 Sep 2018 16:55:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E16F528F5D; Mon, 3 Sep 2018 16:55:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ABF4728A73 for ; Mon, 3 Sep 2018 16:55:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A06A26E2BE; Mon, 3 Sep 2018 16:55:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E5416E2BB for ; Mon, 3 Sep 2018 16:55:04 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id u1-v6so1260436eds.1 for ; Mon, 03 Sep 2018 09:55:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xgpg9SrQEI7QSilImCQ+wvXmEmCTvZVuS+hzjic8sOA=; b=tJAyKarpYdGm1N8UtgBVjXSjG+IxJVWqgxy3qYEe/xAgwYgjK30DWp3A6W57JdHiDH /rIoXACuXLGmnW0utDsnM5PwzFNZrYWVCWKCv20WeBvixW41KGw8GNHITX1niY2ef421 B8cpzs+i7rf/YRiqDOiT+tzBxyF0eCJtx02CNuKSR9JLTGNFDq/g+IrGo1S1Kd8ZUdEW 3pKt+S4KRbeYeCpICSCJ139Pv+y1nR9YD0beYHQu7Gi8SwMtG72hpN6+wTHKUzLRP/vM siQGjkwO4tAVQvvhd3t6I5cqVURX3Xph9mObzI69yXoyhljCa9l1IASYb2DJnuveFrgL tVgQ== X-Gm-Message-State: APzg51B9pt+HMmjyFmlTALi581xOZ+nOGlk1ZWmC44+Z1Y32viSmzXOV unkMOXyqDlzl4j/WUaoPXhEY+5v9YXAV4w== X-Google-Smtp-Source: ANB0VdbPl0o7vsswZLUQCRkD8wNxnWXWpOzYXkfgfERLZI6nxpgnpDCKr2b/Mkpvdvdq9QNNCx1JdA== X-Received: by 2002:a50:94c4:: with SMTP id t4-v6mr32030277eda.306.1535993702692; Mon, 03 Sep 2018 09:55:02 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id u53-v6sm12777790edm.51.2018.09.03.09.55.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Sep 2018 09:55:02 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 11/14] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property Date: Mon, 3 Sep 2018 18:54:36 +0200 Message-Id: <20180903165439.24845-11-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180903165439.24845-1-daniel.vetter@ffwll.ch> References: <20180903165439.24845-1-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , VMware Graphics , Thomas Hellstrom MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The core _does_ the call to drm_atomic_commit for you. That's pretty much the entire point of having the fancy new atomic_set/get_prop callbacks. Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 0c25bb8faf80..0f7e116a59f0 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -2309,12 +2309,6 @@ vmw_du_connector_atomic_set_property(struct drm_connector *connector, if (property == dev_priv->implicit_placement_property) { vcs->is_implicit = val; - - /* - * We should really be doing a drm_atomic_commit() to - * commit the new state, but since this doesn't cause - * an immedate state change, this is probably ok - */ du->is_implicit = vcs->is_implicit; } else { return -EINVAL;