From patchwork Mon Sep 3 16:54:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10586191 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 928DB5A4 for ; Mon, 3 Sep 2018 16:56:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80A6B28A73 for ; Mon, 3 Sep 2018 16:56:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7224728F5D; Mon, 3 Sep 2018 16:56:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3AD4528A73 for ; Mon, 3 Sep 2018 16:56:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82F446E2C8; Mon, 3 Sep 2018 16:55:09 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id D40A16E2C0 for ; Mon, 3 Sep 2018 16:55:06 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id p52-v6so1217264eda.12 for ; Mon, 03 Sep 2018 09:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f4rClaGBO05gUJYpOEx/4mNFGuGS0PHDn2WDRXJgokY=; b=hFN1F/bdvBTKTeitgyH03f+uC1zi4REl/UqNvzZC3FXpndx3E2KR2KvkIh7VkWdRhx 2iA2GbkkXkTvfyZ5RPb1uOB0JviFCiKokdPWELRDdt33LWlrigPasa40ZTunmrh6G1sP XC6U48W7e6CS3j1VeGaxYpRcI2NToPJQpZsfosvgPJ6hXLslyyfjTpzTsPtpYX4Z1u1N lL5O8dziENAPAynuTLc+lLy69+x3Y42PhzEdn1rChZ0oxuZpxbnTD75zgn+LQb7RY2EL WpsGEryaBevk4kTDz4+UU7rB6NwqRiGryAqSiQsrdbijw3r4GRKhW/By0nAADol+BDfX K8lQ== X-Gm-Message-State: APzg51ABdQx6W0lshIWyivbA69xpqfG+wdopXtOzVXJXYJIdU0qBzUvI ueayro1bmnHF3o6g1z3YqCYLucP2uVJG+w== X-Google-Smtp-Source: ANB0Vdb+mrrOLu5MN0AQAJcUH3WPbWmyh1InnOuUAiCjLxjqfEDJjvKXcRDCWdIeKHxBX0oqlphUKw== X-Received: by 2002:a50:cc95:: with SMTP id q21-v6mr32024072edi.98.1535993705121; Mon, 03 Sep 2018 09:55:05 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id u53-v6sm12777790edm.51.2018.09.03.09.55.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Sep 2018 09:55:04 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 13/14] drm/atomic: Improve docs for drm_atomic_state->allow_modeset Date: Mon, 3 Sep 2018 18:54:38 +0200 Message-Id: <20180903165439.24845-13-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180903165439.24845-1-daniel.vetter@ffwll.ch> References: <20180903165439.24845-1-daniel.vetter@ffwll.ch> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Motivated by vmwgfx digging around in core uapi bits it shouldn't dig around in. Signed-off-by: Daniel Vetter --- include/drm/drm_atomic.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 4aff40886acb..91d896ec9c10 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -254,7 +254,6 @@ struct __drm_private_objs_state { * struct drm_atomic_state - the global state object for atomic updates * @ref: count of all references to this state (will not be freed until zero) * @dev: parent DRM device - * @allow_modeset: allow full modeset * @legacy_cursor_update: hint to enforce legacy cursor IOCTL semantics * @async_update: hint for asynchronous plane update * @planes: pointer to array of structures with per-plane data @@ -273,6 +272,15 @@ struct drm_atomic_state { struct kref ref; struct drm_device *dev; + + /** + * @allow_modeset: + * + * Allow full modeset. This is used by the ATOMIC IOCTL handler to + * implement the DRM_MODE_ATOMIC_ALLOW_MODESET flag. Drivers should + * never consult this flag, instead looking at the output of + * drm_atomic_crtc_needs_modeset(). + */ bool allow_modeset : 1; bool legacy_cursor_update : 1; bool async_update : 1;