From patchwork Fri Sep 21 11:42:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Osipenko X-Patchwork-Id: 10611683 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1F6DF15E8 for ; Sun, 23 Sep 2018 12:31:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EE732A1E0 for ; Sun, 23 Sep 2018 12:31:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0338B2A259; Sun, 23 Sep 2018 12:31:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 244F72A1E0 for ; Sun, 23 Sep 2018 12:31:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 62E1B6E1A5; Sun, 23 Sep 2018 12:31:04 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by gabe.freedesktop.org (Postfix) with ESMTPS id 700066E77E for ; Fri, 21 Sep 2018 11:42:59 +0000 (UTC) Received: by mail-pl1-x643.google.com with SMTP id t20-v6so2420591ply.13 for ; Fri, 21 Sep 2018 04:42:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yCrpo4cicYCZ8o9sYo8DxEFcgIsDA8DTr1rWb3FGrYA=; b=DSiHViQne/UaeooJ54kKbzXsaw4MJAKhplGR53QeJm7imtmGpLUXSqtATQ0pr3f4ui mjDHKspjQ4J+xmSmy+T/ybH1xWVReSBA5ZBiFAEkKJQg2Kh+pVxItSq7DZkayD9YdrhP SCaGmg1keq3CBLPXGSFrIvL3pxPCeuYcVMvKgqKZgJHevh6rjNYRljjau6KBDD6+lEex OciSt6Ek6boDZA/EmLxx+PplmZHl9vtPDRAQFK02luhBbUg0/CfebK6+8AF7d3r5zyT5 r70og8PrP72EN82ATZrw6sHw09E0bJsMpeFaN89ttXyFpQ+tiNBhLFSygX51RmreQ1fp racQ== X-Gm-Message-State: APzg51BxgAZ3VpqGAwwM3RKyVqPnrHjwRIeYZKkj/hdJ3LbLecMywllU 2xrHQUlJvhVXxSa9aJw1GK0= X-Google-Smtp-Source: ANB0Vdbp4Nz3jtahBUoInoF+VlRVTzU3YEXd3ZkpQpoC8eI4HZ01XgxvL83/xSe3qUp3LRAdwjsoEA== X-Received: by 2002:a17:902:2f84:: with SMTP id t4-v6mr44495709plb.87.1537530179051; Fri, 21 Sep 2018 04:42:59 -0700 (PDT) Received: from localhost.localdomain ([109.252.91.213]) by smtp.gmail.com with ESMTPSA id x9-v6sm43126132pfd.31.2018.09.21.04.42.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 04:42:58 -0700 (PDT) From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter Subject: [PATCH v1] drm/tegra: dpaux: Fix always-failing probing of the driver Date: Fri, 21 Sep 2018 14:42:41 +0300 Message-Id: <20180921114241.17002-1-digetx@gmail.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 23 Sep 2018 12:30:38 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Some of definitions in the code changed the meaning, unfortunately one place missed the change. Fixes: 0751bb5c44fe ("drm/tegra: dpaux: Add pinctrl support") Cc: # v4.8+ Signed-off-by: Dmitry Osipenko Acked-by: Jon Hunter --- I don't have HW to test DPAUX driver, apparently it has been broken for 2+ years now. There is also a known issue on with the DPAUX driver that prevents it from probing, that was discussed on the #tegra IRC. Thierry, please take a closer look at this driver and test it thoroughly, it has some obvious problems. drivers/gpu/drm/tegra/dpaux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c index d84e81ff36ad..ba5681fab73b 100644 --- a/drivers/gpu/drm/tegra/dpaux.c +++ b/drivers/gpu/drm/tegra/dpaux.c @@ -521,7 +521,7 @@ static int tegra_dpaux_probe(struct platform_device *pdev) * is no possibility to perform the I2C mode configuration in the * HDMI path. */ - err = tegra_dpaux_pad_config(dpaux, DPAUX_HYBRID_PADCTL_MODE_I2C); + err = tegra_dpaux_pad_config(dpaux, DPAUX_PADCTL_FUNC_I2C); if (err < 0) return err;