| Message ID | 20180926114139.22987-1-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm/etnaviv: Replace drm_dev_unref with drm_dev_put | expand |
Am Mittwoch, den 26.09.2018, 13:41 +0200 schrieb Thomas Zimmermann: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Thanks, now applied after slipping through the cracks a second time. Regards, Lucas > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > index 9b2720b41571..9c204200757e 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > @@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev) > > if (!priv) { > > dev_err(dev, "failed to allocate private data\n"); > > ret = -ENOMEM; > > - goto out_unref; > > + goto out_put; > > } > > drm->dev_private = priv; > > @@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev) > > component_unbind_all(dev, drm); > out_bind: > > kfree(priv); > -out_unref: > > - drm_dev_unref(drm); > +out_put: > > + drm_dev_put(drm); > > > return ret; > } > @@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) > > drm->dev_private = NULL; > > kfree(priv); > > > - drm_dev_unref(drm); > > + drm_dev_put(drm); > } > > static const struct component_master_ops etnaviv_master_ops = { > -- > 2.19.0 >
Am 07.11.18 um 17:37 schrieb Lucas Stach: > Am Mittwoch, den 26.09.2018, 13:41 +0200 schrieb Thomas Zimmermann: >> This patch unifies the naming of DRM functions for reference counting >> of struct drm_device. The resulting code is more aligned with the rest >> of the Linux kernel interfaces. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Thanks, now applied after slipping through the cracks a second time. Great, thanks a lot. > > Regards, > Lucas > >> --- >> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> index 9b2720b41571..9c204200757e 100644 >> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c >> @@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev) >>> if (!priv) { >>> dev_err(dev, "failed to allocate private data\n"); >>> ret = -ENOMEM; >>> - goto out_unref; >>> + goto out_put; >>> } >>> drm->dev_private = priv; >> >> @@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev) >>> component_unbind_all(dev, drm); >> out_bind: >>> kfree(priv); >> -out_unref: >>> - drm_dev_unref(drm); >> +out_put: >>> + drm_dev_put(drm); >> >>> return ret; >> } >> @@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) >>> drm->dev_private = NULL; >>> kfree(priv); >> >>> - drm_dev_unref(drm); >>> + drm_dev_put(drm); >> } >> >> static const struct component_master_ops etnaviv_master_ops = { >> -- >> 2.19.0 >>
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 9b2720b41571..9c204200757e 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c @@ -523,7 +523,7 @@ static int etnaviv_bind(struct device *dev) if (!priv) { dev_err(dev, "failed to allocate private data\n"); ret = -ENOMEM; - goto out_unref; + goto out_put; } drm->dev_private = priv; @@ -549,8 +549,8 @@ static int etnaviv_bind(struct device *dev) component_unbind_all(dev, drm); out_bind: kfree(priv); -out_unref: - drm_dev_unref(drm); +out_put: + drm_dev_put(drm); return ret; } @@ -567,7 +567,7 @@ static void etnaviv_unbind(struct device *dev) drm->dev_private = NULL; kfree(priv); - drm_dev_unref(drm); + drm_dev_put(drm); } static const struct component_master_ops etnaviv_master_ops = {
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.19.0