From patchwork Tue Oct 2 13:35:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10623713 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4E62113BB for ; Tue, 2 Oct 2018 13:36:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FA5928992 for ; Tue, 2 Oct 2018 13:36:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4394D289C0; Tue, 2 Oct 2018 13:36:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EE91828992 for ; Tue, 2 Oct 2018 13:36:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D14E66E33D; Tue, 2 Oct 2018 13:35:44 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F5816E331 for ; Tue, 2 Oct 2018 13:35:42 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id j62-v6so2073981edd.7 for ; Tue, 02 Oct 2018 06:35:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pq4vHwlpPRtQXt63MWsqtG9kw0W3NDxu3gFIPXjJT8Q=; b=fVHTY6pmtu10a9WCH4qK/IE0krDnCwpfvPZQOEqJ/JPZfwJAuXUIb6lCcUFOKRrSDz 8j2Y6mjeqTRUQHSQabSczoQH7yRJxsEJIV0UYo3JCWcFGebJqIyt8Iuu2MAfXlV6oF1W Eq3DP+ws89E2cIYuh4L0Q+3cTcYiy/tKWHiVixBJNRDK9JH5JisUOtvUlgs9yz7XpA9l d4dNmiaBGHjswxIZnbOhKQFL/glDxS+ti48qGdcy8sXbtjZdL3X7HDstxS4HkVUoOBIm XIvb0lLJRiCpO/QWI0z7vsfOwU9rbGeMsx6osQBQb5Qlflmf/tQGUdz+4/kb+CpLbmYb +EIA== X-Gm-Message-State: ABuFfohKC38ct0pfx0ccj2TFam6GmUUQrfr/JJSea5IFfiZb8pcEr9UG oN+g2LV0ysBs7BWuLh/Jo/7YtxDRhjE= X-Google-Smtp-Source: ACcGV620brrWpoNYC+MZDpPQs47RVeomdBN1vq9uj+1p8V1/HYXkbnRz3FBUB5WEL/9to8dbzZ8ZAg== X-Received: by 2002:aa7:c406:: with SMTP id j6-v6mr8902379edq.134.1538487340653; Tue, 02 Oct 2018 06:35:40 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id k42-v6sm3118819ede.94.2018.10.02.06.35.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 06:35:39 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 06/18] drm/atomic: Improve docs for drm_atomic_state->allow_modeset Date: Tue, 2 Oct 2018 15:35:14 +0200 Message-Id: <20181002133526.13685-7-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.0.rc2 In-Reply-To: <20181002133526.13685-1-daniel.vetter@ffwll.ch> References: <20181002133526.13685-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Motivated by vmwgfx digging around in core uapi bits it shouldn't dig around in. Signed-off-by: Daniel Vetter Reviewed-by: Ville Syrjälä --- include/drm/drm_atomic.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index d6adebcd6ea4..c09ecaf43825 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -254,7 +254,6 @@ struct __drm_private_objs_state { * struct drm_atomic_state - the global state object for atomic updates * @ref: count of all references to this state (will not be freed until zero) * @dev: parent DRM device - * @allow_modeset: allow full modeset * @legacy_cursor_update: hint to enforce legacy cursor IOCTL semantics * @async_update: hint for asynchronous plane update * @planes: pointer to array of structures with per-plane data @@ -273,6 +272,15 @@ struct drm_atomic_state { struct kref ref; struct drm_device *dev; + + /** + * @allow_modeset: + * + * Allow full modeset. This is used by the ATOMIC IOCTL handler to + * implement the DRM_MODE_ATOMIC_ALLOW_MODESET flag. Drivers should + * never consult this flag, instead looking at the output of + * drm_atomic_crtc_needs_modeset(). + */ bool allow_modeset : 1; bool legacy_cursor_update : 1; bool async_update : 1;