From patchwork Thu Oct 4 20:24:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10626623 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 23C5E15E2 for ; Thu, 4 Oct 2018 20:25:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17374296F1 for ; Thu, 4 Oct 2018 20:25:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B7CF296FF; Thu, 4 Oct 2018 20:25:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BFDD2296F1 for ; Thu, 4 Oct 2018 20:25:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F21C6E669; Thu, 4 Oct 2018 20:25:08 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51E866E669 for ; Thu, 4 Oct 2018 20:25:06 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id j62-v6so9743505edd.7 for ; Thu, 04 Oct 2018 13:25:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TwB4Krv/1cVJB9bIdD3k9ym3lCBE8j/pmCY/MRmdVng=; b=H661k27mmSX3HSJa4dAyeesCQiUZn6ux+b49t4bLgRUqa/rPG+2UKMJLyArcLJYR3T EF18VRVda7ofcXUz8IicJqBSdEns/QeFiSR+9OoBt5SP25zuth5Jc4S27Bqw8LqLgjJt sHPESHiOx+7xZSyAiNg1KDEkIv5RoZuQTYoG0BVImt3UBdzXpjlLpepPQanP22+OcwzA GGy/YauLK6YDFCC58YW3i1nmaIp8NOQjPSLhxjLgE5/qdd/NKqpX/IJ4k4cGYMB2qOj+ uATWasw+2ppjyRCyXLeTmginkQBVvvv/tVc4jlHL0eD5FQ7o2+hI0GQbKMTywD0/rNf2 LWNQ== X-Gm-Message-State: ABuFfogzjZFZVhvs1Vj7x1dIwPodyg2pOyPaJQA0ngCxwGuKHXup3asT +V/qIaVYVuIh6MtHrRDtzaJKOR/y10g= X-Google-Smtp-Source: ACcGV62qVjtqXYpZNzTaqMPblS+u5fbXbwOO6qn2Hn48nb/WuYKV/13efb61mAIA26NsahZ2q1pvIA== X-Received: by 2002:a17:906:5808:: with SMTP id m8-v6mr8412184ejq.20.1538684704317; Thu, 04 Oct 2018 13:25:04 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id y8-v6sm2040002edd.43.2018.10.04.13.25.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Oct 2018 13:25:03 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 05/21] drm/vmwgfx: Remove confused comment from vmw_du_connector_atomic_set_property Date: Thu, 4 Oct 2018 22:24:30 +0200 Message-Id: <20181004202446.22905-6-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.19.0.rc2 In-Reply-To: <20181004202446.22905-1-daniel.vetter@ffwll.ch> References: <20181004202446.22905-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Thomas Hellstrom , VMware Graphics Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The core _does_ the call to drm_atomic_commit for you. That's pretty much the entire point of having the fancy new atomic_set/get_prop callbacks. Signed-off-by: Daniel Vetter Cc: VMware Graphics Cc: Sinclair Yeh Cc: Thomas Hellstrom --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 91ad45b22fee..a50fb0360317 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -2303,12 +2303,6 @@ vmw_du_connector_atomic_set_property(struct drm_connector *connector, if (property == dev_priv->implicit_placement_property) { vcs->is_implicit = val; - - /* - * We should really be doing a drm_atomic_commit() to - * commit the new state, but since this doesn't cause - * an immedate state change, this is probably ok - */ du->is_implicit = vcs->is_implicit; } else { return -EINVAL;