From patchwork Tue Oct 16 15:52:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10643829 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 38751157A for ; Tue, 16 Oct 2018 15:52:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22CBC2A238 for ; Tue, 16 Oct 2018 15:52:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 15FBE2A2C3; Tue, 16 Oct 2018 15:52:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AA04D2A238 for ; Tue, 16 Oct 2018 15:52:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6326D6E24E; Tue, 16 Oct 2018 15:52:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 386CF6E24E for ; Tue, 16 Oct 2018 15:52:48 +0000 (UTC) Received: by mail-yb1-xb41.google.com with SMTP id e190-v6so9089079ybb.5 for ; Tue, 16 Oct 2018 08:52:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0f7UkSwVseT0sQomhGVX2n4cmtZrn4KVzhDNZv7jIqg=; b=fMrQfMizMg6wrjxjzxpw5APOYlNXo108He2ZuJ+2FAcAbVdP0iQEABCxgFs0Mtw9B5 m7PkYDtQkrPNYrV0ZJqBufikgQA8TfwcfHwunb6sKBmbgM2KpC3NdlXE1E6VTDdkOhay k8plRDrQDZinoywqKFSXVagPE19ctm7ZziYtWDPFq2YNyphXUitpO3Lhje7IjedQ4L69 86Vr+L2HJ9ol9TkfU1lvgPf/8pe/s68OZ5u4vyYlNME/MwsgKjHd4AuDGU5PXH5J+F2K 2EXnVJZVdrLPz5l8EP+CSo7TbfP+XOYNwK1s91Z05T2ZKel1IRP4ezCxKxDoLGAa+irk HILg== X-Gm-Message-State: ABuFfoi4yCTRPS1oeat6Hdf70oj9r1J2LuY/dixiUcSKSPxJPCzFUQ/l sYvNP8THJCFMNg0rIVH4Esc7wyf1rfeYtA== X-Google-Smtp-Source: ACcGV61cEt2P+DK0n5bIugMiCLxL+c8dxnZcxVwff50v9hh/mf6QDvTlguN90Xc4dsPFELC7MbE2iw== X-Received: by 2002:a25:71c2:: with SMTP id m185-v6mr11874374ybc.109.1539705167195; Tue, 16 Oct 2018 08:52:47 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id e187-v6sm3571000ywb.106.2018.10.16.08.52.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 08:52:46 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: [PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer Date: Tue, 16 Oct 2018 11:52:45 -0400 Message-Id: <20181016155245.112102-1-sean@poorly.run> X-Mailer: git-send-email 2.19.1.331.ge82ca0e54c-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul It causes a WARN in drm_atomic_get_plane_state(), and is not used by atomic (or dpu). Signed-off-by: Sean Paul Reviewed-by: Daniel Vetter --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index ae63590ad2d3..ed84cf44a222 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -1517,7 +1517,6 @@ struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane, NULL); drm_crtc_helper_add(crtc, &dpu_crtc_helper_funcs); - plane->crtc = crtc; /* save user friendly CRTC name for later */ snprintf(dpu_crtc->name, DPU_CRTC_NAME_SIZE, "crtc%u", crtc->base.id);