[4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding

Message ID	20181018073327.64942-5-icenowy@aosc.io (mailing list archive)
State	New, archived
Headers	show Return-Path: <dri-devel-bounces@lists.freedesktop.org> sender: lmn-TZDUIOWCRQMW) by relay.mailchannels.net (Postfix) with ESMTPA id EE3CD5C3945; Thu, 18 Oct 2018 07:34:20 +0000 (UTC) sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 121FE15D295; Thu, 18 Oct 2018 07:34:15 +0000 (UTC) From: Icenowy Zheng <icenowy@aosc.io> To: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>, Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Archit Taneja <architt@codeaurora.org>, Andrzej Hajda <a.hajda@samsung.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Subject: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding Date: Thu, 18 Oct 2018 15:33:22 +0800 Message-Id: <20181018073327.64942-5-icenowy@aosc.io> In-Reply-To: <20181018073327.64942-1-icenowy@aosc.io> References: <20181018073327.64942-1-icenowy@aosc.io> Precedence: list Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, Icenowy Zheng <icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Series	Analogix ANX6345 RGB-(e)DP bridge support \| expand [0/9] Analogix ANX6345 RGB-(e)DP bridge support [1/9] drm/bridge: move ANA78xx driver to analogix subdirectory [2/9] drm/bridge: split some definitions of ANX78xx to dedicated headers [3/9] drm/bridge: extract some Analogix I2C DP common code [4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding [5/9] drm/bridge: Add Analogix anx6345 support [6/9] arm64: allwinner: a64: add pinmux for RGB666 LCD [7/9] arm64: allwinner: a64: enable ANX6345 bridge on Pinebook [8/9] arm64: allwinner: a64: enable ANX6345 bridge on TERES-I [9/9,DO,NOT,MERGE] drm/sun4i: rgb: Add 5% tolerance to dot clock frequency check

Message ID

20181018073327.64942-5-icenowy@aosc.io (mailing list archive)

State

New, archived

Headers

From: Icenowy Zheng <icenowy@aosc.io>
To: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
 Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>,
 Archit Taneja <architt@codeaurora.org>,
 Andrzej Hajda <a.hajda@samsung.com>,
 Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: [PATCH 4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding
Date: Thu, 18 Oct 2018 15:33:22 +0800
Message-Id: <20181018073327.64942-5-icenowy@aosc.io>
In-Reply-To: <20181018073327.64942-1-icenowy@aosc.io>
References: <20181018073327.64942-1-icenowy@aosc.io>
Precedence: list
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com,
 linux-arm-kernel@lists.infradead.org, Icenowy Zheng <icenowy@aosc.io>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>

Series

Analogix ANX6345 RGB-(e)DP bridge support | expand

Commit Message

Icenowy Zheng Oct. 18, 2018, 7:33 a.m. UTC

The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed
for portable devices.

Add a binding document for it.

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 .../bindings/display/bridge/anx6345.txt       | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt

Comments

Icenowy Zheng Oct. 18, 2018, 10 a.m. UTC | #1

在 2018-10-18四的 11:53 +0300，Laurent Pinchart写道：
> Hi Icenowy,
> 
> Thank you for the patch.
> 
> On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
> > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
> > designed
> > for portable devices.
> > 
> > Add a binding document for it.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> >  .../bindings/display/bridge/anx6345.txt       | 39
> > +++++++++++++++++++
> >  1 file changed, 39 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt new
> > file
> > mode 100644
> > index 000000000000..0689d4eb5f65
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > @@ -0,0 +1,39 @@
> > +Analogix ANX6345 eDP Transmitter
> > +--------------------------------
> > +
> > +The ANX6345 is an ultra-low power Full-HD eDP transmitter designed
> > for
> > +portable devices.
> > +
> > +Required properties:
> > +
> > + - compatible		: "analogix,anx6345"
> > + - reg			: I2C address of the device
> > + - reset-gpios		: Which GPIO to use for reset
> > +
> > +Optional properties:
> > +
> > + - dvdd12-supply	: Regulator for 1.2V digital core power.
> > + - dvdd25-supply	: Regulator for 2.5V digital core power.
> 
> Shouldn't these to supplies be mandatory ?

Yes they should.

> 
> > + - panel-supply		: Regulator for the power of the panel.
> 
> Shouldn't the panel supply for specified in the DT node of the panel
> ?

However, eDP panel can be probed, may vary on the same device, and we
don't have a generic binding for it...

> 
> > + - edid			: verbatim EDID data block describing
> > attached
> > +			  panel, only used when the panel has no EDID
> > info.
> 
> This should also be specified in the panel DT node.
> 
> > + - Video port for RGB input, using the DT bindings defined in [1].
> 
> I think you should also add a port for the output.

What will it point to?

> 
> > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
> > +
> > +Example:
> > +
> > +anx6345: anx6345@38 {
> > +	compatible = "analogix,anx6345";
> > +	reg = <0x38>;
> > +	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> > +	panel-supply = <&reg_dc1sw>;
> > +	dvdd25-supply = <&reg_dldo2>;
> > +	dvdd12-supply = <&reg_fldo1>;
> > +
> > +	port {
> > +		anx6345_in: endpoint {
> > +			remote-endpoint = <&tcon0_out_anx6345>;
> > +		};
> > +	};
> > +};
> 
>

Icenowy Zheng Oct. 18, 2018, 12:40 p.m. UTC | #2

在 2018-10-18四的 14:23 +0300，Laurent Pinchart写道：
> Hi Icenowy,
> 
> On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
> > 在 2018-10-18四的 11:53 +0300，Laurent Pinchart写道：
> > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
> > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
> > > > designed
> > > > for portable devices.
> > > > 
> > > > Add a binding document for it.
> > > > 
> > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > ---
> > > > 
> > > >  .../bindings/display/bridge/anx6345.txt       | 39
> > > > +++++++++++++++++++
> > > > 
> > > >  1 file changed, 39 insertions(+)
> > > >  create mode 100644
> > > > 
> > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > new
> > > > file
> > > > mode 100644
> > > > index 000000000000..0689d4eb5f65
> > > > --- /dev/null
> > > > +++
> > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > @@ -0,0 +1,39 @@
> > > > +Analogix ANX6345 eDP Transmitter
> > > > +--------------------------------
> > > > +
> > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter
> > > > designed
> > > > for
> > > > +portable devices.
> > > > +
> > > > +Required properties:
> > > > +
> > > > + - compatible		: "analogix,anx6345"
> > > > + - reg			: I2C address of the device
> > > > + - reset-gpios		: Which GPIO to use for reset
> > > > +
> > > > +Optional properties:
> > > > +
> > > > + - dvdd12-supply	: Regulator for 1.2V digital core
> > > > power.
> > > > + - dvdd25-supply	: Regulator for 2.5V digital core
> > > > power.
> > > 
> > > Shouldn't these to supplies be mandatory ?
> > 
> > Yes they should.
> > 
> > > > + - panel-supply		: Regulator for the power of
> > > > the panel.
> > > 
> > > Shouldn't the panel supply for specified in the DT node of the
> > > panel
> > > ?
> > 
> > However, eDP panel can be probed, may vary on the same device, and
> > we
> > don't have a generic binding for it...
> 
> Shouldn't we fix that ? :-)

Maybe we should create a connector binding instead of a panel binding?

> 
> > > > + - edid			: verbatim EDID data block
> > > > describing
> > > > attached
> > > > +			  panel, only used when the panel has
> > > > no EDID
> > > > info.
> > > 
> > > This should also be specified in the panel DT node.
> > > 
> > > > + - Video port for RGB input, using the DT bindings defined in
> > > > [1].
> > > 
> > > I think you should also add a port for the output.
> > 
> > What will it point to?
> 
> The panel DT node ?
> 
> > > > +[1]: Documentation/devicetree/bindings/media/video-
> > > > interfaces.txt
> > > > +
> > > > +Example:
> > > > +
> > > > +anx6345: anx6345@38 {
> > > > +	compatible = "analogix,anx6345";
> > > > +	reg = <0x38>;
> > > > +	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> > > > +	panel-supply = <&reg_dc1sw>;
> > > > +	dvdd25-supply = <&reg_dldo2>;
> > > > +	dvdd12-supply = <&reg_fldo1>;
> > > > +
> > > > +	port {
> > > > +		anx6345_in: endpoint {
> > > > +			remote-endpoint = <&tcon0_out_anx6345>;
> > > > +		};
> > > > +	};
> > > > +};
> 
>

Rob Herring (Arm) Oct. 25, 2018, 6:30 p.m. UTC | #3

On Thu, Oct 18, 2018 at 08:40:11PM +0800, Icenowy Zheng wrote:
> 在 2018-10-18四的 14:23 +0300，Laurent Pinchart写道：
> > Hi Icenowy,
> > 
> > On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
> > > 在 2018-10-18四的 11:53 +0300，Laurent Pinchart写道：
> > > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
> > > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
> > > > > designed
> > > > > for portable devices.
> > > > > 
> > > > > Add a binding document for it.
> > > > > 
> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > > > > ---
> > > > > 
> > > > >  .../bindings/display/bridge/anx6345.txt       | 39
> > > > > +++++++++++++++++++
> > > > > 
> > > > >  1 file changed, 39 insertions(+)
> > > > >  create mode 100644
> > > > > 
> > > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > 
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > new
> > > > > file
> > > > > mode 100644
> > > > > index 000000000000..0689d4eb5f65
> > > > > --- /dev/null
> > > > > +++
> > > > > b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
> > > > > @@ -0,0 +1,39 @@
> > > > > +Analogix ANX6345 eDP Transmitter
> > > > > +--------------------------------
> > > > > +
> > > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter
> > > > > designed
> > > > > for
> > > > > +portable devices.
> > > > > +
> > > > > +Required properties:
> > > > > +
> > > > > + - compatible		: "analogix,anx6345"
> > > > > + - reg			: I2C address of the device
> > > > > + - reset-gpios		: Which GPIO to use for reset
> > > > > +
> > > > > +Optional properties:
> > > > > +
> > > > > + - dvdd12-supply	: Regulator for 1.2V digital core
> > > > > power.
> > > > > + - dvdd25-supply	: Regulator for 2.5V digital core
> > > > > power.
> > > > 
> > > > Shouldn't these to supplies be mandatory ?
> > > 
> > > Yes they should.
> > > 
> > > > > + - panel-supply		: Regulator for the power of
> > > > > the panel.
> > > > 
> > > > Shouldn't the panel supply for specified in the DT node of the
> > > > panel
> > > > ?
> > > 
> > > However, eDP panel can be probed, may vary on the same device, and
> > > we
> > > don't have a generic binding for it...
> > 
> > Shouldn't we fix that ? :-)
> 
> Maybe we should create a connector binding instead of a panel binding?

There's not any such thing as a standard eDP connector, is there? 
Otherwise, that's just creating a generic panel binding in disguise. 
Maybe if eDP interface is standardized enough in terms of power control, 
control lines, EDID at least sometimes present, etc., then we could have 
some sort of generic eDP panel/connector binding.

Rob

Icenowy Zheng Oct. 26, 2018, 12:08 a.m. UTC | #4

于 2018年10月26日 GMT+08:00 上午2:30:03, Rob Herring <robh@kernel.org> 写到:
>On Thu, Oct 18, 2018 at 08:40:11PM +0800, Icenowy Zheng wrote:
>> 在 2018-10-18四的 14:23 +0300，Laurent Pinchart写道：
>> > Hi Icenowy,
>> > 
>> > On Thursday, 18 October 2018 13:00:05 EEST Icenowy Zheng wrote:
>> > > 在 2018-10-18四的 11:53 +0300，Laurent Pinchart写道：
>> > > > On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
>> > > > > The ANX6345 is an ultra-low power DisplayPort/eDP transmitter
>> > > > > designed
>> > > > > for portable devices.
>> > > > > 
>> > > > > Add a binding document for it.
>> > > > > 
>> > > > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> > > > > ---
>> > > > > 
>> > > > >  .../bindings/display/bridge/anx6345.txt       | 39
>> > > > > +++++++++++++++++++
>> > > > > 
>> > > > >  1 file changed, 39 insertions(+)
>> > > > >  create mode 100644
>> > > > > 
>> > > > > Documentation/devicetree/bindings/display/bridge/anx6345.txt
>> > > > > 
>> > > > > diff --git
>> > > > >
>a/Documentation/devicetree/bindings/display/bridge/anx6345.txt
>> > > > >
>b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
>> > > > > new
>> > > > > file
>> > > > > mode 100644
>> > > > > index 000000000000..0689d4eb5f65
>> > > > > --- /dev/null
>> > > > > +++
>> > > > >
>b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
>> > > > > @@ -0,0 +1,39 @@
>> > > > > +Analogix ANX6345 eDP Transmitter
>> > > > > +--------------------------------
>> > > > > +
>> > > > > +The ANX6345 is an ultra-low power Full-HD eDP transmitter
>> > > > > designed
>> > > > > for
>> > > > > +portable devices.
>> > > > > +
>> > > > > +Required properties:
>> > > > > +
>> > > > > + - compatible		: "analogix,anx6345"
>> > > > > + - reg			: I2C address of the device
>> > > > > + - reset-gpios		: Which GPIO to use for reset
>> > > > > +
>> > > > > +Optional properties:
>> > > > > +
>> > > > > + - dvdd12-supply	: Regulator for 1.2V digital core
>> > > > > power.
>> > > > > + - dvdd25-supply	: Regulator for 2.5V digital core
>> > > > > power.
>> > > > 
>> > > > Shouldn't these to supplies be mandatory ?
>> > > 
>> > > Yes they should.
>> > > 
>> > > > > + - panel-supply		: Regulator for the power of
>> > > > > the panel.
>> > > > 
>> > > > Shouldn't the panel supply for specified in the DT node of the
>> > > > panel
>> > > > ?
>> > > 
>> > > However, eDP panel can be probed, may vary on the same device,
>and
>> > > we
>> > > don't have a generic binding for it...
>> > 
>> > Shouldn't we fix that ? :-)
>> 
>> Maybe we should create a connector binding instead of a panel
>binding?
>
>There's not any such thing as a standard eDP connector, is there? 
>Otherwise, that's just creating a generic panel binding in disguise. 
>Maybe if eDP interface is standardized enough in terms of power
>control, 
>control lines, EDID at least sometimes present, etc., then we could

eDP has the same display signal set with DP, including AUX which
carries DPCD and EDID (if present).

But I don't know whether other lines are standardized, including power, backlight, etc.

>have 
>some sort of generic eDP panel/connector binding.
>
>Rob
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.txt b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
new file mode 100644
index 000000000000..0689d4eb5f65
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/anx6345.txt
@@ -0,0 +1,39 @@ 
+Analogix ANX6345 eDP Transmitter
+--------------------------------
+
+The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for
+portable devices.
+
+Required properties:
+
+ - compatible		: "analogix,anx6345"
+ - reg			: I2C address of the device
+ - reset-gpios		: Which GPIO to use for reset
+
+Optional properties:
+
+ - dvdd12-supply	: Regulator for 1.2V digital core power.
+ - dvdd25-supply	: Regulator for 2.5V digital core power.
+ - panel-supply		: Regulator for the power of the panel.
+ - edid			: verbatim EDID data block describing attached
+			  panel, only used when the panel has no EDID info.
+ - Video port for RGB input, using the DT bindings defined in [1].
+
+[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
+
+Example:
+
+anx6345: anx6345@38 {
+	compatible = "analogix,anx6345";
+	reg = <0x38>;
+	reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
+	panel-supply = <&reg_dc1sw>;
+	dvdd25-supply = <&reg_dldo2>;
+	dvdd12-supply = <&reg_fldo1>;
+
+	port {
+		anx6345_in: endpoint {
+			remote-endpoint = <&tcon0_out_anx6345>;
+		};
+	};
+};

[4/9] dt-bindings: Add ANX6345 DP/eDP transmitter binding

Commit Message

Comments

Patch