diff mbox series

drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW

Message ID 20181018193136.4910-1-krisman@collabora.co.uk (mailing list archive)
State New, archived
Headers show
Series drm: panel-orientation-quirks: Do rotation quirk for new GPD Win2 FW | expand

Commit Message

Gabriel Krisman Bertazi Oct. 18, 2018, 7:31 p.m. UTC
I just got a new GDP Win2 device with an updated firmware, which still
requires this quirk to get the rotation right, so add the new firmware
date to the quirk matching table.

This should go to drm-misc-next.

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans de Goede Oct. 19, 2018, 7:28 a.m. UTC | #1
Hi,

On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
> I just got a new GDP Win2 device with an updated firmware, which still
> requires this quirk to get the rotation right, so add the new firmware
> date to the quirk matching table.
> 
> This should go to drm-misc-next.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

Thanks for the patch and this looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 280a41d33081..b0bf5a55ae9a 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -57,7 +57,7 @@ static const struct drm_dmi_panel_orientation_data gpd_win2 = {
>   	.width = 720,
>   	.height = 1280,
>   	.bios_dates = (const char * const []){
> -		"12/07/2017", "05/24/2018", NULL },
> +		"12/07/2017", "05/24/2018", "06/29/2018", NULL },
>   	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
>   };
>   
>
Gabriel Krisman Bertazi Nov. 9, 2018, 3:36 p.m. UTC | #2
Hans de Goede <hdegoede@redhat.com> writes:

> Hi,
>
> On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
>> I just got a new GDP Win2 device with an updated firmware, which still
>> requires this quirk to get the rotation right, so add the new firmware
>> date to the quirk matching table.
>>
>> This should go to drm-misc-next.
>>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>
> Thanks for the patch and this looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Hello,

I suspect this might have drown into the void and never got
applied. can someone merge this?

Sorry if it was applied already.  Couldn't find in any of
the -next or -fixes branches.

Thanks,
Maarten Lankhorst Nov. 15, 2018, 10:05 a.m. UTC | #3
Op 09-11-18 om 16:36 schreef Gabriel Krisman Bertazi:
> Hans de Goede <hdegoede@redhat.com> writes:
>
>> Hi,
>>
>> On 18-10-18 21:31, Gabriel Krisman Bertazi wrote:
>>> I just got a new GDP Win2 device with an updated firmware, which still
>>> requires this quirk to get the rotation right, so add the new firmware
>>> date to the quirk matching table.
>>>
>>> This should go to drm-misc-next.
>>>
>>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>> Thanks for the patch and this looks good to me:
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Hello,
>
> I suspect this might have drown into the void and never got
> applied. can someone merge this?
>
> Sorry if it was applied already.  Couldn't find in any of
> the -next or -fixes branches.
>
> Thanks,
>
Looks like this fell through. I pushed it to drm-misc-next.

Thanks for the patch,

~Maarten
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 280a41d33081..b0bf5a55ae9a 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -57,7 +57,7 @@  static const struct drm_dmi_panel_orientation_data gpd_win2 = {
 	.width = 720,
 	.height = 1280,
 	.bios_dates = (const char * const []){
-		"12/07/2017", "05/24/2018", NULL },
+		"12/07/2017", "05/24/2018", "06/29/2018", NULL },
 	.orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
 };