diff mbox series

[libdrm] tests: skip drmdevice test if the machine doesn't have any drm device

Message ID 20181109191247.10716-1-eric.engestrom@intel.com (mailing list archive)
State New, archived
Headers show
Series [libdrm] tests: skip drmdevice test if the machine doesn't have any drm device | expand

Commit Message

Eric Engestrom Nov. 9, 2018, 7:12 p.m. UTC
Error message was invalid too, negative values aren't the number of
devices, they're errno error codes.

Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
---
This fixes the Gitlab CI; goes from:
https://gitlab.freedesktop.org/mesa/drm/-/jobs/42061
to:
https://gitlab.freedesktop.org/eric/libdrm/-/jobs/42099
---
 tests/drmdevice.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Daniel Stone Nov. 10, 2018, 6:56 p.m. UTC | #1
On Fri, 9 Nov 2018 at 19:13, Eric Engestrom <eric.engestrom@intel.com> wrote:
> Error message was invalid too, negative values aren't the number of
> devices, they're errno error codes.
>
> Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>

Reviewed-by: Daniel Stone <daniels@collabora.com>
diff mbox series

Patch

diff --git a/tests/drmdevice.c b/tests/drmdevice.c
index cdf6e8deaf121899bcbc..f1c1cd3a0338d912f60c 100644
--- a/tests/drmdevice.c
+++ b/tests/drmdevice.c
@@ -115,8 +115,9 @@  main(void)
     max_devices = drmGetDevices2(0, NULL, 0);
 
     if (max_devices <= 0) {
-        printf("drmGetDevices2() has returned %d\n", max_devices);
-        return -1;
+        printf("drmGetDevices2() has not found any devices (errno=%d)\n",
+               -max_devices);
+        return 77;
     }
     printf("--- Devices reported %d ---\n", max_devices);