diff mbox series

drm/pl111: add of_node_put()

Message ID 20181121131723.22431-1-tiny.windzz@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm/pl111: add of_node_put() | expand

Commit Message

Yangtao Li Nov. 21, 2018, 1:17 p.m. UTC
of_find_node_by_path() acquires a reference to the node
returned by it and that reference needs to be dropped by its caller.
bl_idle_init() doesn't do that, so fix it.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 drivers/gpu/drm/pl111/pl111_vexpress.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Anholt Nov. 28, 2018, 5:31 p.m. UTC | #1
Yangtao Li <tiny.windzz@gmail.com> writes:

> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.

The "bl_idle_init" appeared to be copy-and-paste from some other commit
message, so I droppped that bit and pushed.  Thanks!
diff mbox series

Patch

diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c
index 5fa0441bb6df..38c938c9adda 100644
--- a/drivers/gpu/drm/pl111/pl111_vexpress.c
+++ b/drivers/gpu/drm/pl111/pl111_vexpress.c
@@ -55,6 +55,8 @@  int pl111_vexpress_clcd_init(struct device *dev,
 		}
 	}
 
+	of_node_put(root);
+
 	/*
 	 * If there is a coretile HDLCD and it has a driver,
 	 * do not mux the CLCD on the motherboard to the DVI.