From patchwork Thu Nov 29 19:58:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10705267 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BBFC514BD for ; Thu, 29 Nov 2018 19:58:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA6172E911 for ; Thu, 29 Nov 2018 19:58:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99E1B2E97D; Thu, 29 Nov 2018 19:58:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 319772E911 for ; Thu, 29 Nov 2018 19:58:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E16A6E414; Thu, 29 Nov 2018 19:58:42 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw1-xc43.google.com (mail-yw1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E7216E414 for ; Thu, 29 Nov 2018 19:58:41 +0000 (UTC) Received: by mail-yw1-xc43.google.com with SMTP id h32so1297041ywk.2 for ; Thu, 29 Nov 2018 11:58:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HkuhcmnP2XqZAgSg3H2j5Sxm30eXST7E5Z+C56MnO1E=; b=JFe50XeWrh7XFPwtfZ1CNWAPgby1ACwN/7gZYY70vLElqtkfBDx0cr7eTmZ4I4wG6t e+LaDJ977vYsKjgtNwbWgxclQOqMFzjUU9ZHY0gpCNK1+wxtiGx7Mx5HG6932TDqZCLT 2Y7R/6vtafW0fbsvk2UEN8/lxxtEGyrdfki/zfQ2HDB2tcZJ23Ee4Q6v52IBmly8GeMO RQJkyDbzlFNCT4A1v3LKfDMyUFcj0eZAHVQGvrTk18ONZn03JizOvkXYrzAM52V9S0Pk 3LvG0sZTFrHD1fJRKrRAgjru0w07aqDTKui/FVobFdbGuCu86rd+9Y99GJMsqZF3tJOL uabg== X-Gm-Message-State: AA+aEWbkmkL6bbZx9E4FS8sBIjnSWXzxA5YS9Csw2tiYA01a5wOLSVRg j2h1oLAYTYCC2VXPIgg7U8ySyl2Fsmmbgw== X-Google-Smtp-Source: AFSGD/U40GdGx7ipULkXlVLJ7vRoRcFdal+ha5V2Dy+xERopa7QQXM4Iaiik4ydyQ3BxC/k2tronoQ== X-Received: by 2002:a0d:dd52:: with SMTP id g79mr2881025ywe.29.1543521520117; Thu, 29 Nov 2018 11:58:40 -0800 (PST) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id l7sm913929ywk.24.2018.11.29.11.58.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 11:58:39 -0800 (PST) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst Date: Thu, 29 Nov 2018 14:58:33 -0500 Message-Id: <20181129195838.222031-1-sean@poorly.run> X-Mailer: git-send-email 2.20.0.rc0.387.gc7a69e6b6c-goog In-Reply-To: <20181129164651.GM21184@phenom.ffwll.local> References: <20181129164651.GM21184@phenom.ffwll.local> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Corbet , David Airlie , Daniel Vetter , linux-doc@vger.kernel.org, Maxime Ripard , Sean Paul , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Sean Paul We should also get the drivers using the helpers. Seems like a good intermediate TODO item. Changes in v2: - Add line about replacing drm_modest_lock_all() (Daniel) Acked-by: Daniel Vetter Signed-off-by: Sean Paul --- Documentation/gpu/todo.rst | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ab347dec50796..14191b64446df 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -241,6 +241,21 @@ struct drm_gem_object_funcs GEM objects can now have a function table instead of having the callbacks on the DRM driver struct. This is now the preferred way and drivers can be moved over. +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate +--------------------------------------------------------- + +For cases where drivers are attempting to grab the modeset locks with a local +acquire context. Replace the boilerplate code surrounding +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and +DRM_MODESET_LOCK_ALL_END() instead. + +This should also be done for all places where drm_modest_lock_all() is still +used. + +As a reference, take a look at the conversions already completed in drm core. + +Contact: Sean Paul, respective driver maintainers + Core refactorings =================