| Message ID | 20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge/panel: Remove duplicate header | expand |
On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Brajeswar, > > Thank you for the patch. > > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote: > > Remove drm/drm_panel.h which is included more than once > > > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com> > > --- > > drivers/gpu/drm/bridge/panel.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > index 7cbaba213ef6..402b318eeeb2 100644 > > --- a/drivers/gpu/drm/bridge/panel.c > > +++ b/drivers/gpu/drm/bridge/panel.c > > @@ -15,7 +15,6 @@ > > #include <drm/drm_crtc_helper.h> > > #include <drm/drm_encoder.h> > > #include <drm/drm_modeset_helper_vtables.h> > > -#include <drm/drm_panel.h> > > While at it, how about sorting headers alphabetically to make sure this won't > happen again ? > > With that change, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> If no further comment, can we get this patch in queue for 5.1 ? > > > struct panel_bridge { > > struct drm_bridge bridge; > > -- > Regards, > > Laurent Pinchart > > >
On Wed, Jan 30, 2019 at 8:07 PM Brajeswar Ghosh <brajeswar.linux@gmail.com> wrote: > > On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: > > > > Hi Brajeswar, > > > > Thank you for the patch. > > > > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote: > > > Remove drm/drm_panel.h which is included more than once > > > > > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com> > > > --- > > > drivers/gpu/drm/bridge/panel.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > > > index 7cbaba213ef6..402b318eeeb2 100644 > > > --- a/drivers/gpu/drm/bridge/panel.c > > > +++ b/drivers/gpu/drm/bridge/panel.c > > > @@ -15,7 +15,6 @@ > > > #include <drm/drm_crtc_helper.h> > > > #include <drm/drm_encoder.h> > > > #include <drm/drm_modeset_helper_vtables.h> > > > -#include <drm/drm_panel.h> > > > > While at it, how about sorting headers alphabetically to make sure this won't > > happen again ? > > > > With that change, > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > If no further comment, can we get this patch in queue for 5.1 ? You already got a feedback from Laurent. > > > > > > struct panel_bridge { > > > struct drm_bridge bridge; > > > > -- > > Regards, > > > > Laurent Pinchart > > > > > >
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 7cbaba213ef6..402b318eeeb2 100644 --- a/drivers/gpu/drm/bridge/panel.c +++ b/drivers/gpu/drm/bridge/panel.c @@ -15,7 +15,6 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_encoder.h> #include <drm/drm_modeset_helper_vtables.h> -#include <drm/drm_panel.h> struct panel_bridge { struct drm_bridge bridge;
Remove drm/drm_panel.h which is included more than once Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com> --- drivers/gpu/drm/bridge/panel.c | 1 - 1 file changed, 1 deletion(-)