diff mbox series

[v2] gpu: anx7808: fix a missing check in anx78xx_poweron

Message ID 20181225050234.66210-1-kjlu@umn.edu (mailing list archive)
State New, archived
Headers show
Series [v2] gpu: anx7808: fix a missing check in anx78xx_poweron | expand

Commit Message

Kangjie Lu Dec. 25, 2018, 5:02 a.m. UTC 
Both anx78xx_set_bits() and anx78xx_clear_bits() in the poweron process
may fail. The fix inserts checks for their return values.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
 drivers/gpu/drm/bridge/analogix-anx78xx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kangjie Lu Dec. 25, 2018, 5:18 a.m. UTC | #1 
Please ignore this email. I've sent another one.

On Mon, Dec 24, 2018 at 11:02 PM Kangjie Lu <kjlu@umn.edu> wrote:

> Both anx78xx_set_bits() and anx78xx_clear_bits() in the poweron process
> may fail. The fix inserts checks for their return values.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/gpu/drm/bridge/analogix-anx78xx.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c
> b/drivers/gpu/drm/bridge/analogix-anx78xx.c
> index 3b0fe2b188db..4f35aced65a0 100644
> --- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
> +++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c
> @@ -646,6 +646,7 @@ static void anx78xx_poweron(struct anx78xx *anx78xx)
>                                 err);
>                 return;
>         }
> +
>         err = anx78xx_clear_bits(anx78xx->map[I2C_IDX_TX_P2],
>                         SP_POWERDOWN_CTRL_REG,
>                         SP_REGISTER_PD | SP_TOTAL_PD);
> --
> 2.17.2 (Apple Git-113)
>
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c
index 3b0fe2b188db..4f35aced65a0 100644
--- a/drivers/gpu/drm/bridge/analogix-anx78xx.c
+++ b/drivers/gpu/drm/bridge/analogix-anx78xx.c
@@ -646,6 +646,7 @@  static void anx78xx_poweron(struct anx78xx *anx78xx)
 				err);
 		return;
 	}
+
 	err = anx78xx_clear_bits(anx78xx->map[I2C_IDX_TX_P2],
 			SP_POWERDOWN_CTRL_REG,
 			SP_REGISTER_PD | SP_TOTAL_PD);