diff mbox series

[v2,05/14] drm: make drm_file.h self contained

Message ID 20181230174838.32330-6-sam@ravnborg.org (mailing list archive)
State New, archived
Headers show
Series drm: minimize drmP.h dependencies | expand

Commit Message

Sam Ravnborg Dec. 30, 2018, 5:48 p.m. UTC
drm_file.h embed struct idr, so this file need to know
the full type definition.

With this change users of drm_file.h are no longer forced
to include idr.h - a file they usually get from drmP.h

This makes it simpler to remove drmP.h includes

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
---
 include/drm/drm_file.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Noralf Trønnes Jan. 7, 2019, 3:56 p.m. UTC | #1
Den 30.12.2018 18.48, skrev Sam Ravnborg:
> drm_file.h embed struct idr, so this file need to know
> the full type definition.
> 
> With this change users of drm_file.h are no longer forced
> to include idr.h - a file they usually get from drmP.h
> 
> This makes it simpler to remove drmP.h includes
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> ---

Acked-by: Noralf Trønnes <noralf@tronnes.org>
diff mbox series

Patch

diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h
index 84ac79219e4c..bbdb74c3d7ff 100644
--- a/include/drm/drm_file.h
+++ b/include/drm/drm_file.h
@@ -30,6 +30,7 @@ 
 #ifndef _DRM_FILE_H_
 #define _DRM_FILE_H_
 
+#include <linux/idr.h>
 #include <linux/types.h>
 #include <linux/completion.h>