diff mbox series

[3/3] drm/panel: simple: Add Evervision VGG804821 pannel support

Message ID 20190103182658.16377-4-m.felsch@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series drm/panel: simple: Add support for Evervision VGG804821 | expand

Commit Message

Marco Felsch Jan. 3, 2019, 6:26 p.m. UTC
Add support the Evervision VGG804821 800x480 5.0" WVGA TFT panel.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

Comments

Sam Ravnborg Jan. 4, 2019, 4:40 p.m. UTC | #1
Hi Marco.

In $subject pannel => panel

Other than that, bonus points for specifying
all of .flags, .bus_format and .bus_flags

	Sam
Marco Felsch Jan. 14, 2019, 10:28 a.m. UTC | #2
Hi Sam,

On 19-01-04 17:40, Sam Ravnborg wrote:
> Hi Marco.
> 
> In $subject pannel => panel

Thanks for covering that, Thierry can you fix this inline?

Regards,
Marco

> 
> Other than that, bonus points for specifying
> all of .flags, .bus_format and .bus_flags
> 
> 	Sam
>
Marco Felsch April 15, 2019, 3:46 p.m. UTC | #3
Hi Thierry,

gentle ping.

On 19-01-14 11:28, Marco Felsch wrote:
> Hi Sam,
> 
> On 19-01-04 17:40, Sam Ravnborg wrote:
> > Hi Marco.
> > 
> > In $subject pannel => panel
> 
> Thanks for covering that, Thierry can you fix this inline?

Is that doable for you?

Regards,

	Marco

> Regards,
> Marco
> 
> > 
> > Other than that, bonus points for specifying
> > all of .flags, .bus_format and .bus_flags
> > 
> > 	Sam
> > 
> 
>
Sam Ravnborg April 15, 2019, 4:10 p.m. UTC | #4
Hi Marco

On Mon, Apr 15, 2019 at 05:46:48PM +0200, Marco Felsch wrote:
> Hi Thierry,
> 
> gentle ping.
> 
> On 19-01-14 11:28, Marco Felsch wrote:
> > Hi Sam,
> > 
> > On 19-01-04 17:40, Sam Ravnborg wrote:
> > > Hi Marco.
> > > 
> > > In $subject pannel => panel
> > 
> > Thanks for covering that, Thierry can you fix this inline?
> 
> Is that doable for you?

If you resend I will apply. I deleted the original patch-set.
This will allow me to try my first commit to drm-misc :-)

	Sam
Marco Felsch April 15, 2019, 4:59 p.m. UTC | #5
Hi Sam,

thanks for your fast response =)

On 19-04-15 18:10, Sam Ravnborg wrote:
> Hi Marco
> 
> On Mon, Apr 15, 2019 at 05:46:48PM +0200, Marco Felsch wrote:
> > Hi Thierry,
> > 
> > gentle ping.
> > 
> > On 19-01-14 11:28, Marco Felsch wrote:
> > > Hi Sam,
> > > 
> > > On 19-01-04 17:40, Sam Ravnborg wrote:
> > > > Hi Marco.
> > > > 
> > > > In $subject pannel => panel
> > > 
> > > Thanks for covering that, Thierry can you fix this inline?
> > 
> > Is that doable for you?
> 
> If you resend I will apply. I deleted the original patch-set.
> This will allow me to try my first commit to drm-misc :-)

Okay, let me resend it as v2 with your integrated comment.

Regards,

	Marco

> 
> 	Sam
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9c69e739a524..82047490a86f 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1160,6 +1160,33 @@  static const struct panel_desc edt_etm0700g0bdh6 = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
 };
 
+static const struct display_timing evervision_vgg804821_timing = {
+	.pixelclock = { 27600000, 33300000, 50000000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 40, 66, 70 },
+	.hback_porch = { 40, 67, 70 },
+	.hsync_len = { 40, 67, 70 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 6, 10, 10 },
+	.vback_porch = { 7, 11, 11 },
+	.vsync_len = { 7, 11, 11 },
+	.flags = DISPLAY_FLAGS_HSYNC_HIGH | DISPLAY_FLAGS_VSYNC_HIGH |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		 DISPLAY_FLAGS_SYNC_NEGEDGE,
+};
+
+static const struct panel_desc evervision_vgg804821 = {
+	.timings = &evervision_vgg804821_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 108,
+		.height = 64,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
 static const struct drm_display_mode foxlink_fl500wvr00_a0t_mode = {
 	.clock = 32260,
 	.hdisplay = 800,
@@ -2586,6 +2613,9 @@  static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "edt,etm0700g0edh6",
 		.data = &edt_etm0700g0bdh6,
+	}, {
+		.compatible = "evervision,vgg804821",
+		.data = &evervision_vgg804821,
 	}, {
 		.compatible = "foxlink,fl500wvr00-a0t",
 		.data = &foxlink_fl500wvr00_a0t,