| Message ID | 20190108192939.15255-11-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: minimize drmP.h dependencies | expand |
Le mar. 8 janv. 2019 à 20:30, Sam Ravnborg <sam@ravnborg.org> a écrit : I just notice the a typo in the title of the commit message reply ->rely ? > > drmP.h was the only header file in the past and a lot > of files rely on that drmP.h defines everything. > The goal is to one day to delete drmP.h and > as a step towards this it will no longer be included in the > headers files in include/drm/ > > To prepare stm/ for this add dependencies that > othwewise was pulled in by drmP.h from drm_gem_cma_helper.h > > Sort the include list when we anyway modify it. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Acked-by: Noralf Trønnes <noralf@tronnes.org> > Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > Cc: Yannick Fertre <yannick.fertre@st.com> > Cc: Philippe Cornu <philippe.cornu@st.com> > Cc: Vincent Abriou <vincent.abriou@st.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/stm/drv.c | 6 +++++- > drivers/gpu/drm/stm/ltdc.c | 9 ++++++++- > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c > index 8dec001b9d37..9cd6228a18ad 100644 > --- a/drivers/gpu/drm/stm/drv.c > +++ b/drivers/gpu/drm/stm/drv.c > @@ -9,15 +9,19 @@ > */ > > #include <linux/component.h> > +#include <linux/dma-mapping.h> > +#include <linux/module.h> > #include <linux/of_platform.h> > > #include <drm/drm_atomic.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_crtc_helper.h> > #include <drm/drm_fb_helper.h> > -#include <drm/drm_fb_cma_helper.h> > +#include <drm/drm_drv.h> > #include <drm/drm_gem_cma_helper.h> > #include <drm/drm_gem_framebuffer_helper.h> > +#include <drm/drm_fb_cma_helper.h> > +#include <drm/drm_vblank.h> > > #include "ltdc.h" > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 61dd661aa0ac..5cce6c7f35d4 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -10,17 +10,24 @@ > > #include <linux/clk.h> > #include <linux/component.h> > +#include <linux/delay.h> > +#include <linux/interrupt.h> > +#include <linux/module.h> > #include <linux/of_address.h> > #include <linux/of_graph.h> > +#include <linux/platform_device.h> > #include <linux/reset.h> > > #include <drm/drm_atomic.h> > #include <drm/drm_atomic_helper.h> > +#include <drm/drm_bridge.h> > #include <drm/drm_crtc_helper.h> > +#include <drm/drm_device.h> > #include <drm/drm_fb_cma_helper.h> > +#include <drm/drm_fourcc.h> > #include <drm/drm_gem_cma_helper.h> > #include <drm/drm_of.h> > -#include <drm/drm_bridge.h> > +#include <drm/drm_vblank.h> > #include <drm/drm_plane_helper.h> > > #include <video/videomode.h> > -- > 2.12.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Benjamin. On Wed, Jan 09, 2019 at 09:21:39AM +0100, Benjamin Gaignard wrote: > Le mar. 8 janv. 2019 à 20:30, Sam Ravnborg <sam@ravnborg.org> a écrit : > I just notice the a typo in the title of the commit message reply ->rely ? Randy already told me this, but I missed that in the update. Will fix in v4 if this set do not get applied. Sam
diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c index 8dec001b9d37..9cd6228a18ad 100644 --- a/drivers/gpu/drm/stm/drv.c +++ b/drivers/gpu/drm/stm/drv.c @@ -9,15 +9,19 @@ */ #include <linux/component.h> +#include <linux/dma-mapping.h> +#include <linux/module.h> #include <linux/of_platform.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> #include <drm/drm_crtc_helper.h> #include <drm/drm_fb_helper.h> -#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_drv.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_fb_cma_helper.h> +#include <drm/drm_vblank.h> #include "ltdc.h" diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 61dd661aa0ac..5cce6c7f35d4 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -10,17 +10,24 @@ #include <linux/clk.h> #include <linux/component.h> +#include <linux/delay.h> +#include <linux/interrupt.h> +#include <linux/module.h> #include <linux/of_address.h> #include <linux/of_graph.h> +#include <linux/platform_device.h> #include <linux/reset.h> #include <drm/drm_atomic.h> #include <drm/drm_atomic_helper.h> +#include <drm/drm_bridge.h> #include <drm/drm_crtc_helper.h> +#include <drm/drm_device.h> #include <drm/drm_fb_cma_helper.h> +#include <drm/drm_fourcc.h> #include <drm/drm_gem_cma_helper.h> #include <drm/drm_of.h> -#include <drm/drm_bridge.h> +#include <drm/drm_vblank.h> #include <drm/drm_plane_helper.h> #include <video/videomode.h>