| Message ID | 20190117014946.9669-6-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | R-Car DU DPAD support for D3 and E3 | expand |
Hi Laurent, On Thu, Jan 17, 2019 at 3:07 AM Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > The LVDS1 encoder must supply a pixel clock to the DU for the DPAD > output when the LVDS0 encoder is used. Enable it despite its output not > being connected. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > @@ -443,6 +443,8 @@ > }; > > &lvds1 { Would it make sense to add a comment /* Must be enabled to supply a pixel clock to the DU for the DPAD output when lvds0 is used */ also for D3? > + status = "okay"; > + > clocks = <&cpg CPG_MOD 727>, > <&x13_clk>, > <&extal_clk>; Gr{oetje,eeting}s, Geert
Hi Geert, On Thu, Jan 17, 2019 at 11:21:32AM +0100, Geert Uytterhoeven wrote: > On Thu, Jan 17, 2019 at 3:07 AM Laurent Pinchart > <laurent.pinchart+renesas@ideasonboard.com> wrote: > > The LVDS1 encoder must supply a pixel clock to the DU for the DPAD > > output when the LVDS0 encoder is used. Enable it despite its output not > > being connected. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > @@ -443,6 +443,8 @@ > > }; > > > > &lvds1 { > > Would it make sense to add a comment > > /* Must be enabled to supply a pixel clock to the DU for the DPAD > output when lvds0 is used */ > > also for D3? Good point, I'll add it for both. > > + status = "okay"; > > + > > clocks = <&cpg CPG_MOD 727>, > > <&x13_clk>, > > <&extal_clk>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts index 62bdddcbbae7..df5dc23fd252 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts @@ -443,6 +443,8 @@ }; &lvds1 { + status = "okay"; + clocks = <&cpg CPG_MOD 727>, <&x13_clk>, <&extal_clk>;
The LVDS1 encoder must supply a pixel clock to the DU for the DPAD output when the LVDS0 encoder is used. Enable it despite its output not being connected. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 ++ 1 file changed, 2 insertions(+)