| Message ID | 20190120171217.12508-1-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] drm: fix drm_can_sleep() comment | expand |
On Sun, Jan 20, 2019 at 06:12:17PM +0100, Sam Ravnborg wrote: > Reversed logic when writing the original comment, now fixed. > > Fixes: e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h") > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> Thanks, merged. -Daniel > --- > include/drm/drm_util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h > index 8163d35f8327..07b8e9f04599 100644 > --- a/include/drm/drm_util.h > +++ b/include/drm/drm_util.h > @@ -71,7 +71,7 @@ > * FIXME: All users of drm_can_sleep should be removed (see todo.rst) > * > * Returns: > - * True if kgdb is active or we are in an atomic context or irqs are disabled > + * False if kgdb is active, we are in atomic context or irqs are disabled. > */ > static inline bool drm_can_sleep(void) > { > -- > 2.12.0 >
diff --git a/include/drm/drm_util.h b/include/drm/drm_util.h index 8163d35f8327..07b8e9f04599 100644 --- a/include/drm/drm_util.h +++ b/include/drm/drm_util.h @@ -71,7 +71,7 @@ * FIXME: All users of drm_can_sleep should be removed (see todo.rst) * * Returns: - * True if kgdb is active or we are in an atomic context or irqs are disabled + * False if kgdb is active, we are in atomic context or irqs are disabled. */ static inline bool drm_can_sleep(void) {
Reversed logic when writing the original comment, now fixed. Fixes: e9eafcb58921 ("drm: move drm_can_sleep() to drm_util.h") Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> --- include/drm/drm_util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)