From patchwork Thu Jan 24 18:02:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 10779803 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E966E13BF for ; Thu, 24 Jan 2019 18:03:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC9CB32831 for ; Thu, 24 Jan 2019 18:03:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA24032848; Thu, 24 Jan 2019 18:03:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7F2183284B for ; Thu, 24 Jan 2019 18:03:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A17266F204; Thu, 24 Jan 2019 18:03:20 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55F316F206 for ; Thu, 24 Jan 2019 18:03:16 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id v13so7497427wrw.5 for ; Thu, 24 Jan 2019 10:03:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PocOaCnpvnomQAIxw9jxHPQb1zw4adK2COw8rYmymW0=; b=jgZ/+DR8ef4oaKoddIGJimub+rNmt1PKU/svIGgSJfvso9y7GXcMuLmGOPHAzsCko0 0fOT6zBjtgChk+B97ijkzi59A+cxD/wW3291w9cu8mKpHnbA+KSXj5KjFu0TFjCc/+QJ vQzgM4JHj27pXTnAXy0gnwrcsFB1mLa0x3OGMBKG84Q3eB3+JOBQHcwRdkE3173wMbFm bPX27mSwzwsJnWNqHoz4TvWSTaBpJjFwQZ4/RBBs5QvzVsC/axycReXTtuXITjvNXkfO xtzVxuiloAphHZbV4EsNDgmkGBk3kAY3oRG0942kWkb5Uj10dFO9gpEXYMNClFqk743d tJOg== X-Gm-Message-State: AJcUukf4O4oUhyTOCQh8yjm4HOwHPL9kxOx7aH1FPGNbhEldWe7IVQja 1nKJ15mmvl1qNrP4XsYBaAY= X-Google-Smtp-Source: ALg8bN71qWlZs3ZmM6Aql1sJhb8ly1bAvUtrNZaZZMSzQ1dnU/9BzmU3lvl3NIdyG5fRhVaqkvUd0w== X-Received: by 2002:a5d:6152:: with SMTP id y18mr8606607wrt.141.1548352994837; Thu, 24 Jan 2019 10:03:14 -0800 (PST) Received: from localhost (pD9E51040.dip0.t-ipconnect.de. [217.229.16.64]) by smtp.gmail.com with ESMTPSA id x10sm125586802wrn.29.2019.01.24.10.03.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 24 Jan 2019 10:03:14 -0800 (PST) From: Thierry Reding To: Thierry Reding Subject: [PATCH v2 11/13] drm/tegra: vic: Do not clear driver data Date: Thu, 24 Jan 2019 19:02:52 +0100 Message-Id: <20190124180254.20080-12-thierry.reding@gmail.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190124180254.20080-1-thierry.reding@gmail.com> References: <20190124180254.20080-1-thierry.reding@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Dmitry Osipenko , dri-devel@lists.freedesktop.org, Mikko Perttunen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding Upon driver failure, the driver core will take care of clearing the driver data, so there's no need to do so explicitly in the driver. Reviewed-by: Dmitry Osipenko Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/vic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c index 9cb10d1e923a..d20fcbf6196d 100644 --- a/drivers/gpu/drm/tegra/vic.c +++ b/drivers/gpu/drm/tegra/vic.c @@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev) err = host1x_client_register(&vic->client.base); if (err < 0) { dev_err(dev, "failed to register host1x client: %d\n", err); - platform_set_drvdata(pdev, NULL); goto exit_falcon; }