From patchwork Thu Feb 14 04:46:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot via dri-devel X-Patchwork-Id: 10812009 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DA9CE922 for ; Thu, 14 Feb 2019 08:23:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C92F52D8BD for ; Thu, 14 Feb 2019 08:23:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD5422D8C6; Thu, 14 Feb 2019 08:23:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 874AF2D8BD for ; Thu, 14 Feb 2019 08:23:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06DBF89F07; Thu, 14 Feb 2019 08:23:10 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3ABFF6E35D; Thu, 14 Feb 2019 04:46:35 +0000 (UTC) Received: by mail-yb1-xb42.google.com with SMTP id e131so1878599ybh.12; Wed, 13 Feb 2019 20:46:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hO7DSwxzHlBBi4/zT5cSujpYWgbd+Avp3ABtw3OhI0o=; b=D4K7YeLdmCbQrPWzONivYSk7cF/aBLTrIlBiY4M6kleiFsJt4HVCwZbSZ6rGRYvNhd 3xtM1phVdwgcP642a2IgqtQ0gd7k0Z9DlkhoApuE8Rmf/bh5+M6wA4UEWjgjEoW02D0c XY/O5rZZpq8UUqCRVv5T0NwXq8Exqrscm1GjsC4cag14rFqFlpDADUPslHvXbNd6LCA3 o+uiotb9uQR/PFckevWKaEl4NCgA0XTkhEkQ+naqxf4Tjfc7iOG7gOBceL9FG2SbMi8r EXmxpJNnVcKpTva8e3/g087uAVojs08ehtD5980JnrvX094gaGC+FLS/wxcATMhuymhP jXTA== X-Gm-Message-State: AHQUAuYj2RDZXIeXT+DBu06JbrJEcgNglUwZRFVsaegmFBkI4QOcHO23 sdRbfF6BkkC0Ibytdcww20wY05J00FY/Xw== X-Google-Smtp-Source: AHgI3Ia0qW8d+5IAkOCsne/sb//c0YA5CTYhITiwzhkwsD67ys0jc9i5eOb9iRlOM4sbeXiMj4Lkeg== X-Received: by 2002:a25:ab2a:: with SMTP id u39mr1550311ybi.0.1550119594493; Wed, 13 Feb 2019 20:46:34 -0800 (PST) Received: from localhost.localdomain ([191.101.9.198]) by smtp.gmail.com with ESMTPSA id s185sm876056yws.69.2019.02.13.20.46.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 20:46:33 -0800 (PST) To: alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, daniel@ffwll.ch, Rex.Zhu@amd.com, andrey.grodzovsky@amd.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN Date: Wed, 13 Feb 2019 23:46:28 -0500 Message-Id: <20190214044628.26759-1-tsu.yubo@gmail.com> X-Mailer: git-send-email 2.11.0 X-Mailman-Approved-At: Thu, 14 Feb 2019 08:22:46 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hO7DSwxzHlBBi4/zT5cSujpYWgbd+Avp3ABtw3OhI0o=; b=BreapajYsNYQ4iV53Cu619/9OrvYxaeKFZPOy635p/VrN8K1+22TgeMSXf9EEUXkQi a5jRZuCT0nC9LJB9s3MKkir9zogJEydr7v87Z7OqiWMC7D///ZGAkoEdY90c64mpEXEa UShekndl1sXnzblFFx/O0ApEePgmJpKO9Ti6MFdXMWuqt+gacAVoQMJ49wcpN+VbBNwS FIImT3DraDAJXjPZ3rtd2AcxMCegcdi8HU1ojEW5MCTl32poTF0Jk3XhgX8q3P299T39 AYaclwCOlZvBz5dBzNUJ8bHYGJEHA5w2Yn4tS5AVtCqqTy25DsOLL6Ib5rutEjqtsm7B nEVA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Bo YU via dri-devel From: kernel test robot via dri-devel Reply-To: Bo YU Cc: Bo Yu , amd-gfx@lists.freedesktop.org MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Bo Yu Calling "amdgpu_ring_test_helper" without checking return value Signed-off-by: Bo Yu --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 57cb3a51bda7..48465a61516b 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c @@ -4728,7 +4728,9 @@ static int gfx_v8_0_cp_test_all_rings(struct amdgpu_device *adev) for (i = 0; i < adev->gfx.num_compute_rings; i++) { ring = &adev->gfx.compute_ring[i]; - amdgpu_ring_test_helper(ring); + r = amdgpu_ring_test_helper(ring); + if (r) + return r; } return 0;