diff mbox series

[v2,3/3] drm/panel: simple: Add support for VXT VL050-8048NT-C01 panel

Message ID 20190219002706.20077-3-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] dt-bindings: Add vendor prefix for VXT Ltd | expand

Commit Message

Fabio Estevam Feb. 19, 2019, 12:27 a.m. UTC 
Add support for the VXT VL050-8048NT-C01 800x480 panel to the
panel-simple driver. 

This panel is used on some boards manufactured by TechNexion, such as
imx7d-pico.

Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Pass .flags and .bus_flags (Sam)

 drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Fabio Estevam April 1, 2019, 3:21 p.m. UTC | #1 
Hi Thierry,

On Mon, Feb 18, 2019 at 9:27 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Add support for the VXT VL050-8048NT-C01 800x480 panel to the
> panel-simple driver.
>
> This panel is used on some boards manufactured by TechNexion, such as
> imx7d-pico.
>
> Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Any feedback, please?

Trying to get this one upstreamed for four months already and hope to
get it to 5.2.

Thanks
Otavio Salvador April 8, 2019, 2:14 p.m. UTC | #2 
On Mon, Apr 1, 2019 at 12:21 PM Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Feb 18, 2019 at 9:27 PM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Add support for the VXT VL050-8048NT-C01 800x480 panel to the
> > panel-simple driver.
> >
> > This panel is used on some boards manufactured by TechNexion, such as
> > imx7d-pico.
> >
> > Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Any feedback, please?
>
> Trying to get this one upstreamed for four months already and hope to
> get it to 5.2.

Any news on this? It has been waiting for review for a while. Is there
someone else who could review this?
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 9c69e739a524..737cbf3aee11 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2434,6 +2434,32 @@  static const struct panel_desc urt_umsh_8596md_parallel = {
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 };
 
+static const struct drm_display_mode vl050_8048nt_c01_mode = {
+	.clock = 33333,
+	.hdisplay = 800,
+	.hsync_start = 800 + 210,
+	.hsync_end = 800 + 210 + 20,
+	.htotal = 800 + 210 + 20 + 46,
+	.vdisplay =  480,
+	.vsync_start = 480 + 22,
+	.vsync_end = 480 + 22 + 10,
+	.vtotal = 480 + 22 + 10 + 23,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc vl050_8048nt_c01 = {
+	.modes = &vl050_8048nt_c01_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 120,
+		.height = 76,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
 static const struct drm_display_mode winstar_wf35ltiacd_mode = {
 	.clock = 6410,
 	.hdisplay = 320,
@@ -2751,6 +2777,9 @@  static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "urt,umsh-8596md-20t",
 		.data = &urt_umsh_8596md_parallel,
+	}, {
+		.compatible = "vxt,vl050-8048nt-c01",
+		.data = &vl050_8048nt_c01,
 	}, {
 		.compatible = "winstar,wf35ltiacd",
 		.data = &winstar_wf35ltiacd,