diff mbox series

[-next] drm/nouveau/dmem: remove set but not used variable 'drm'

Message ID 20190221033851.70331-1-yuehaibing@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next] drm/nouveau/dmem: remove set but not used variable 'drm' | expand

Commit Message

Yue Haibing Feb. 21, 2019, 3:38 a.m. UTC
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/nouveau/nouveau_dmem.c: In function 'nouveau_dmem_free':
drivers/gpu/drm/nouveau/nouveau_dmem.c:103:22: warning:
 variable 'drm' set but not used [-Wunused-but-set-variable]
  struct nouveau_drm *drm;
                      ^

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ben Skeggs Feb. 21, 2019, 10:11 p.m. UTC | #1
On Thu, 21 Feb 2019 at 13:41, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/nouveau/nouveau_dmem.c: In function 'nouveau_dmem_free':
> drivers/gpu/drm/nouveau/nouveau_dmem.c:103:22: warning:
>  variable 'drm' set but not used [-Wunused-but-set-variable]
>   struct nouveau_drm *drm;
>                       ^
Thanks!  Merged.

>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_dmem.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> index aa9fec80492d..900a302b7ce9 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
> @@ -100,12 +100,10 @@ static void
>  nouveau_dmem_free(struct hmm_devmem *devmem, struct page *page)
>  {
>         struct nouveau_dmem_chunk *chunk;
> -       struct nouveau_drm *drm;
>         unsigned long idx;
>
>         chunk = (void *)hmm_devmem_page_get_drvdata(page);
>         idx = page_to_pfn(page) - chunk->pfn_first;
> -       drm = chunk->drm;
>
>         /*
>          * FIXME:
>
>
>
>
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/nouveau_dmem.c b/drivers/gpu/drm/nouveau/nouveau_dmem.c
index aa9fec80492d..900a302b7ce9 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dmem.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dmem.c
@@ -100,12 +100,10 @@  static void
 nouveau_dmem_free(struct hmm_devmem *devmem, struct page *page)
 {
 	struct nouveau_dmem_chunk *chunk;
-	struct nouveau_drm *drm;
 	unsigned long idx;
 
 	chunk = (void *)hmm_devmem_page_get_drvdata(page);
 	idx = page_to_pfn(page) - chunk->pfn_first;
-	drm = chunk->drm;
 
 	/*
 	 * FIXME: