| Message ID | 20190221155857.19773-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/hibmc: Drop best_encoder | expand |
Den 21.02.2019 16.58, skrev Daniel Vetter: > This is the default for atomic drivers. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- Acked-by: Noralf Trønnes <noralf@tronnes.org> > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > index d2cf7317930a..8c2f9b9cafb3 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > @@ -33,17 +33,10 @@ static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *con > return MODE_OK; > } > > -static struct drm_encoder * > -hibmc_connector_best_encoder(struct drm_connector *connector) > -{ > - return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]); > -} > - > static const struct drm_connector_helper_funcs > hibmc_connector_helper_funcs = { > .get_modes = hibmc_connector_get_modes, > .mode_valid = hibmc_connector_mode_valid, > - .best_encoder = hibmc_connector_best_encoder, > }; > > static const struct drm_connector_funcs hibmc_connector_funcs = { >
On Thu, Feb 21, 2019 at 04:58:56PM +0100, Daniel Vetter wrote: > This is the default for atomic drivers. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
On Thu, Feb 28, 2019 at 02:16:03PM +0100, Noralf Trønnes wrote: > > > Den 21.02.2019 16.58, skrev Daniel Vetter: > > This is the default for atomic drivers. > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Neil Armstrong <narmstrong@baylibre.com> > > Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > Acked-by: Noralf Trønnes <noralf@tronnes.org> Thanks for taking a look, merged to drm-misc-next. -Daniel > > > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > > index d2cf7317930a..8c2f9b9cafb3 100644 > > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > > @@ -33,17 +33,10 @@ static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *con > > return MODE_OK; > > } > > > > -static struct drm_encoder * > > -hibmc_connector_best_encoder(struct drm_connector *connector) > > -{ > > - return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]); > > -} > > - > > static const struct drm_connector_helper_funcs > > hibmc_connector_helper_funcs = { > > .get_modes = hibmc_connector_get_modes, > > .mode_valid = hibmc_connector_mode_valid, > > - .best_encoder = hibmc_connector_best_encoder, > > }; > > > > static const struct drm_connector_funcs hibmc_connector_funcs = { > >
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index d2cf7317930a..8c2f9b9cafb3 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c @@ -33,17 +33,10 @@ static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *con return MODE_OK; } -static struct drm_encoder * -hibmc_connector_best_encoder(struct drm_connector *connector) -{ - return drm_encoder_find(connector->dev, NULL, connector->encoder_ids[0]); -} - static const struct drm_connector_helper_funcs hibmc_connector_helper_funcs = { .get_modes = hibmc_connector_get_modes, .mode_valid = hibmc_connector_mode_valid, - .best_encoder = hibmc_connector_best_encoder, }; static const struct drm_connector_funcs hibmc_connector_funcs = {
This is the default for atomic drivers. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 ------- 1 file changed, 7 deletions(-)