From patchwork Tue Feb 26 19:36:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10831445 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A02121390 for ; Wed, 27 Feb 2019 08:57:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B2602B002 for ; Wed, 27 Feb 2019 08:57:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F2DD2C162; Wed, 27 Feb 2019 08:57:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3D4532B002 for ; Wed, 27 Feb 2019 08:57:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 134666E088; Wed, 27 Feb 2019 08:56:53 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id A784F6E021 for ; Tue, 26 Feb 2019 19:36:35 +0000 (UTC) Received: by mail-pf1-x443.google.com with SMTP id a3so6705930pff.11 for ; Tue, 26 Feb 2019 11:36:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Zxy0XxA1MxzsropNeklSR3wb+dlQlnhChJjlQro53Yk=; b=PG4P1UVNrCZ9LPane18Px8hiwqWKb9ohvuvjbEsXQGSBDdB1A2uqEFE9a/rq1iMhcK ARt5xh/LqBG8B4wuiqtSnA3ZRhUvJ7Pcv7+fUa9nAbOBn6vXa3L4dLyjA3KoeMclUI/c +DcZgHwfjdIAUi9TIktBtip5wnIzd2mBRzFMB8tZVSeGQpefQ4hItQ4VPlkpUmHRQuI/ 5ovZkivZiG1m1cI0hvdejLpwheUKgXc7HZLQlyW/qcO2S+/8GY6u5l1HSFbv48UXFg0k XAJ2I3hHCsYd1xhWE72CZIBTz0S+FYQDP6eZSKX8fdfnLVhpEK+FRs6G5IIrpwjoN8Wc efLg== X-Gm-Message-State: AHQUAuYkpMrE4L6GJgaNGofZYzdtJVfzZF/OUXyDdHTzYlzI8+fx3HzB aLCV2IEQ01ug0G/x0TsyB/Guw2XUyLQ= X-Google-Smtp-Source: AHgI3IZT9yKG8Xkr/0a+hzS3sbn6XFUn51XO6ZefgSuVbDnQlZ7ft839js2vRYXAJogFoNo4PnQtew== X-Received: by 2002:a63:2ad4:: with SMTP id q203mr26606392pgq.43.1551209794912; Tue, 26 Feb 2019 11:36:34 -0800 (PST) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id l79sm28951220pfb.102.2019.02.26.11.36.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 11:36:34 -0800 (PST) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Subject: [PATCH 6/9] drm/bridge: tc358767: Simplify error check in tc_aux_linx_setup() Date: Tue, 26 Feb 2019 11:36:06 -0800 Message-Id: <20190226193609.9862-7-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190226193609.9862-1-andrew.smirnov@gmail.com> References: <20190226193609.9862-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 27 Feb 2019 08:56:29 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zxy0XxA1MxzsropNeklSR3wb+dlQlnhChJjlQro53Yk=; b=ujvWRXMgJdu1SG4HYPw1wKyEkMT7mYayCL5beQCpVSQc2sbYmc+5d3qG3bGcXJZuIy g6btJvd2T1GwQq4QioFb7yZguBI140NCIA7ohfvtEm4Bf42GaK2JAGY9xvRAdOh9iu2E +DwxlaJZo7ccCcHyKOysRdPiDuxIbynPTnkufVZHlHmRs51B98z0MbngyyqsBZ6BXZQA x2+Aw6ShDGzbCy4g0m0DmnjIhb7IW0GaOiNQT6TIclDijWVqsvVBuvk64Pz2E17y92Kd YUvFTxDKvh1WdD4q4YjmnAX7re5LibMDj5PZyDmrcIsJX6wIM0wIvK2R5bgbxNWHoXx8 LxXA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, Laurent Pinchart , Chris Healy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Tc_poll_timeout() can only return -ETIMEDOUT, so checking for other errors is not necessary. Drop it. No functional change intended. Signed-off-by: Andrey Smirnov Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index ea30cec4a0c3..54ff95f66e30 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -569,11 +569,10 @@ static int tc_aux_link_setup(struct tc_data *tc) ret = tc_poll_timeout(tc->regmap, DP_PHY_CTRL, PHY_RDY, PHY_RDY, 1, 1000); - if (ret == -ETIMEDOUT) { + if (ret) { dev_err(tc->dev, "Timeout waiting for PHY to become ready"); return ret; - } else if (ret) - goto err; + } /* Setup AUX link */ tc_write(DP0_AUXCFG1, AUX_RX_FILTER_EN |