| Message ID | 20190311163522.22045-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: Add an entry for the vboxvideo driver | expand |
On Mon, Mar 11, 2019 at 12:35 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been > moved out of staging. > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> > --- > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 81d484891b53..36577f5db872 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4932,6 +4932,13 @@ S: Odd Fixes > F: drivers/gpu/drm/udl/ > T: git git://anongit.freedesktop.org/drm/drm-misc > > +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU > +M: Hans de Goede <hdegoede@redhat.com> > +L: dri-devel@lists.freedesktop.org > +S: Maintained > +F: drivers/gpu/drm/vboxvideo/ > +T: git git://anongit.freedesktop.org/drm/drm-misc > + > DRM DRIVER FOR VMWARE VIRTUAL GPU > M: "VMware Graphics" <linux-graphics-maintainer@vmware.com> > M: Thomas Hellstrom <thellstrom@vmware.com> > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, 11 Mar 2019, Hans de Goede <hdegoede@redhat.com> wrote: > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been > moved out of staging. > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 81d484891b53..36577f5db872 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4932,6 +4932,13 @@ S: Odd Fixes > F: drivers/gpu/drm/udl/ > T: git git://anongit.freedesktop.org/drm/drm-misc > > +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU > +M: Hans de Goede <hdegoede@redhat.com> > +L: dri-devel@lists.freedesktop.org > +S: Maintained > +F: drivers/gpu/drm/vboxvideo/ > +T: git git://anongit.freedesktop.org/drm/drm-misc Please consider adding B: and C: entries, and perhaps W: if applicable. (Basically I'd like *all* DRM drivers to have those.) BR, Jani. > + > DRM DRIVER FOR VMWARE VIRTUAL GPU > M: "VMware Graphics" <linux-graphics-maintainer@vmware.com> > M: Thomas Hellstrom <thellstrom@vmware.com>
On Wed, Mar 13, 2019 at 10:26:37AM +0200, Jani Nikula wrote: > On Mon, 11 Mar 2019, Hans de Goede <hdegoede@redhat.com> wrote: > > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been > > moved out of staging. > > > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > --- > > MAINTAINERS | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 81d484891b53..36577f5db872 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -4932,6 +4932,13 @@ S: Odd Fixes > > F: drivers/gpu/drm/udl/ > > T: git git://anongit.freedesktop.org/drm/drm-misc > > > > +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU > > +M: Hans de Goede <hdegoede@redhat.com> > > +L: dri-devel@lists.freedesktop.org > > +S: Maintained > > +F: drivers/gpu/drm/vboxvideo/ > > +T: git git://anongit.freedesktop.org/drm/drm-misc > > Please consider adding B: and C: entries, and perhaps W: if applicable. > > (Basically I'd like *all* DRM drivers to have those.) Doesn't it fall back to the next level up in that case, to the DRM DRIVERS catchall? If not we should probably fix that ... -Daniel
Hi, On 3/13/19 9:26 AM, Jani Nikula wrote: > On Mon, 11 Mar 2019, Hans de Goede <hdegoede@redhat.com> wrote: >> Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >> moved out of staging. >> >> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> MAINTAINERS | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 81d484891b53..36577f5db872 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -4932,6 +4932,13 @@ S: Odd Fixes >> F: drivers/gpu/drm/udl/ >> T: git git://anongit.freedesktop.org/drm/drm-misc >> >> +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU >> +M: Hans de Goede <hdegoede@redhat.com> >> +L: dri-devel@lists.freedesktop.org >> +S: Maintained >> +F: drivers/gpu/drm/vboxvideo/ >> +T: git git://anongit.freedesktop.org/drm/drm-misc > > Please consider adding B: and C: entries, and perhaps W: if applicable. Should the B: point to bugzilla.kernel.org or bugzilla.freedesktop.org? also most B: entries just point to a bugzilla, without specifying which component to use, which is not really helpful. The B: for i915 seems good, but setting up a similar webpage for each driver seems like a bad idea. I think that we may need some generic howto report drm driver bugs page somewhere ? As for the C: I am more or less the main point of contact and I'm more often not on irc then that I'm on irc since I find that irc distracts me too much. So I think it is better to not have a C: for the vboxvideo driver. Regards, Hans
On Wed, 13 Mar 2019, Daniel Vetter <daniel@ffwll.ch> wrote: > On Wed, Mar 13, 2019 at 10:26:37AM +0200, Jani Nikula wrote: >> On Mon, 11 Mar 2019, Hans de Goede <hdegoede@redhat.com> wrote: >> > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >> > moved out of staging. >> > >> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> >> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> > --- >> > MAINTAINERS | 7 +++++++ >> > 1 file changed, 7 insertions(+) >> > >> > diff --git a/MAINTAINERS b/MAINTAINERS >> > index 81d484891b53..36577f5db872 100644 >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -4932,6 +4932,13 @@ S: Odd Fixes >> > F: drivers/gpu/drm/udl/ >> > T: git git://anongit.freedesktop.org/drm/drm-misc >> > >> > +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU >> > +M: Hans de Goede <hdegoede@redhat.com> >> > +L: dri-devel@lists.freedesktop.org >> > +S: Maintained >> > +F: drivers/gpu/drm/vboxvideo/ >> > +T: git git://anongit.freedesktop.org/drm/drm-misc >> >> Please consider adding B: and C: entries, and perhaps W: if applicable. >> >> (Basically I'd like *all* DRM drivers to have those.) > > Doesn't it fall back to the next level up in that case, to the DRM DRIVERS > catchall? > > If not we should probably fix that ... I have no idea how to use get_maintainer.pl to display that information to begin with... BR, Jani.
On Wed, 13 Mar 2019, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 3/13/19 9:26 AM, Jani Nikula wrote: >> On Mon, 11 Mar 2019, Hans de Goede <hdegoede@redhat.com> wrote: >>> Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >>> moved out of staging. >>> >>> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> >>> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >>> --- >>> MAINTAINERS | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 81d484891b53..36577f5db872 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -4932,6 +4932,13 @@ S: Odd Fixes >>> F: drivers/gpu/drm/udl/ >>> T: git git://anongit.freedesktop.org/drm/drm-misc >>> >>> +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU >>> +M: Hans de Goede <hdegoede@redhat.com> >>> +L: dri-devel@lists.freedesktop.org >>> +S: Maintained >>> +F: drivers/gpu/drm/vboxvideo/ >>> +T: git git://anongit.freedesktop.org/drm/drm-misc >> >> Please consider adding B: and C: entries, and perhaps W: if applicable. > > Should the B: point to bugzilla.kernel.org or bugzilla.freedesktop.org? This is perhaps a point of contention. drm/i915 has completely switched to fdo bugzilla, and we close any kernel.org bugs on sight with instructions to file the bug at fdo. IMHO all of drm would benefit from switching over to fdo bugzilla (or gitlab issues going forward). > also most B: entries just point to a bugzilla, without > specifying which component to use, which is not really helpful. > The B: for i915 seems good, but setting up a similar webpage for > each driver seems like a bad idea. The i915 page needs an overhaul. But you could also use something like: https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel > I think that we may need some > generic howto report drm driver bugs page somewhere ? > > As for the C: I am more or less the main point of contact and I'm > more often not on irc then that I'm on irc since I find that irc > distracts me too much. So I think it is better to not have a C: > for the vboxvideo driver. I think that's fine. Also, I have nothing against merging the patch at hand as-is, and updating the rest later. BR, Jani.
diff --git a/MAINTAINERS b/MAINTAINERS index 81d484891b53..36577f5db872 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4932,6 +4932,13 @@ S: Odd Fixes F: drivers/gpu/drm/udl/ T: git git://anongit.freedesktop.org/drm/drm-misc +DRM DRIVER FOR VIRTUALBOX VIRTUAL GPU +M: Hans de Goede <hdegoede@redhat.com> +L: dri-devel@lists.freedesktop.org +S: Maintained +F: drivers/gpu/drm/vboxvideo/ +T: git git://anongit.freedesktop.org/drm/drm-misc + DRM DRIVER FOR VMWARE VIRTUAL GPU M: "VMware Graphics" <linux-graphics-maintainer@vmware.com> M: Thomas Hellstrom <thellstrom@vmware.com>