From patchwork Wed Mar 20 08:11:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 10860965 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7A8CB17E9 for ; Wed, 20 Mar 2019 08:11:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 630BA29A83 for ; Wed, 20 Mar 2019 08:11:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 52BA929A49; Wed, 20 Mar 2019 08:11:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D5D5329A49 for ; Wed, 20 Mar 2019 08:11:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 77F9E89C1A; Wed, 20 Mar 2019 08:11:16 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EC5E89C1A for ; Wed, 20 Mar 2019 08:11:15 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id o10so18443035wmc.1 for ; Wed, 20 Mar 2019 01:11:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eFtdP05d2Yd7J7Kr65hCVTF0i81Ds1QiBjoleRYSdg4=; b=etZvkR6iDs4jjDSlIrimHubmbkhQ5z7BvKyiC83plBHwX2nofIAaV6D5o/r7H89aL9 vqnpPa3GkUUXgURFczbR4T4iQkKPvq9FIYSv4gOqDR4+yhPxgjESJrCFUjS5sOc+AH9j N9msHXGWY29h3astRa+00MWY+5MjS1V6wzliRcNFuvKuGVqjDOLMDugQG6rVY8kQdtlD mq+xkwq0tUhG4KcYfh7riUvbGCWqK8LRPu0OhV+kaTM7/byV7/ZItOcXCRlmSlaG6JrN eZUOkoAY8NDhHngk+Nig6A2gbkfb0YrHaXD0C3wlS7ZZY1hc24JMfeKLOSuxHh5/pKI9 MOyw== X-Gm-Message-State: APjAAAWoqXsLQ4R3j2tupFzGvtv6hI/LKy7X3vIi4U5i1gbCD2COlvl5 D77m9hZREubRPwRmz4SvtZVbpXXKbQHwDO1m X-Google-Smtp-Source: APXvYqwtuUEVnsZxXKA7EBFNRqaDkSSEbJFykQuv8l1AVpJLIqATxrOaPDhf5tfS1n6BAtUIMwowGw== X-Received: by 2002:a1c:7e51:: with SMTP id z78mr7111964wmc.82.1553069473794; Wed, 20 Mar 2019 01:11:13 -0700 (PDT) Received: from localhost.localdomain (176-150-251-154.abo.bbox.fr. [176.150.251.154]) by smtp.gmail.com with ESMTPSA id 12sm3640670wme.25.2019.03.20.01.11.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Mar 2019 01:11:13 -0700 (PDT) From: Neil Armstrong To: daniel@ffwll.ch Subject: [PATCH] drm/meson: fix TMDS clock filtering for DMT monitors Date: Wed, 20 Mar 2019 09:11:10 +0100 Message-Id: <20190320081110.1718-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eFtdP05d2Yd7J7Kr65hCVTF0i81Ds1QiBjoleRYSdg4=; b=OqNlY2d8zJN+yt4ujTovEzqj1DCk9qg2euOx/Lyzn+sh05433TflHUP6VmiPx+csOE aWrhIEzdYnMqQeADMxEvbPvo97EsJSQSWkulxhsK45lDWTgOtDf03FLQ5kTL+LwFLuA+ P1BHwnyK4Kc/8PqivblcrR9HQ5ivXCqggJTd/inIj9hDemRhx0lUjaar/g45i5GSA0vV 2iwsaJSgNpRqS6cj/aGaSNvZWq0x7DYkAbw2zikY5W7wwJhlCr/nv8H3iyp/gBzjOchS 7BuSjEiwjLqAKr9gZKGsl0i74iIzOwutoBqsNdrDbOquL+QEYO1wkzH8Ww8SUCkNkVJh xa0A== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Jourdan , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP DMT monitors does not necessarely report a maximum TMDS clock in a VSDB EDID extension. In this case, all modes are wrongly rejected, including the DRM fallback EDID. This patch only rejects modes whith clock > max_tmds_clock if the max_tmds_clock is specified. This will only reject 4:2:0 HDMI2.0 modes, who reports a clock > max_tmds_clock. Reported-by: Maxime Jourdan Fixes: d7d8fb7046b6 ("drm/meson: add HDMI div40 TMDS mode") Signed-off-by: Neil Armstrong Tested-by: Maxime Jourdan Reviewed-by: Maxime Jourdan --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index e28814f4ea6c..563953ec6ad0 100644 --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c @@ -569,7 +569,8 @@ dw_hdmi_mode_valid(struct drm_connector *connector, DRM_DEBUG_DRIVER("Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode)); /* If sink max TMDS clock, we reject the mode */ - if (mode->clock > connector->display_info.max_tmds_clock) + if (connector->display_info.max_tmds_clock && + mode->clock > connector->display_info.max_tmds_clock) return MODE_BAD; /* Check against non-VIC supported modes */