From patchwork Fri Mar 22 03:28:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10867679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2CE83925 for ; Sun, 24 Mar 2019 21:02:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1B16C28CA8 for ; Sun, 24 Mar 2019 21:02:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F68F28E33; Sun, 24 Mar 2019 21:02:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B046928CA8 for ; Sun, 24 Mar 2019 21:02:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 865DA6E590; Sun, 24 Mar 2019 21:02:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72D846E237 for ; Fri, 22 Mar 2019 03:29:33 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id h8so498689pgp.6 for ; Thu, 21 Mar 2019 20:29:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1SpLWn2GNZxw8TpsUtWTa95KkSKBcIOU+P/XIiFsSiI=; b=rwzJsan7+76fWpPoshha+gj4piUgxIEA7HnAo/qK7XWYS/TKQlG8qEij1oFnua5Jzi rKoJrQAL2CXkHITI5G4aLoJuawT0ceVKF/oVJBuu2E3CSz1G0gq5/DkOrpcIzrGwiO85 AxsylpxavcvmoD8TbumbfxUJL/m2VzSVWFfIDy57YzuQciUSHmzXHR5HnGzUTx9zTPNr 6jGb0yAZ+2GdU+AEVeuonhwSCWF+jfdRwpAoFpWeJkFjUiH1BifKNK9cEWvNPpP35ELe P2+oI/QUG+4A66CnWDry12/fEyPhrjMAWZd7/rtJv00FYI0fvDr+59l25Eoo+UxTPon7 x+ag== X-Gm-Message-State: APjAAAVz/5kd2/uWS/oPwk2yG0F3tC1T4WWZ+RmZbOJMwHROaSiqF/wC jCArYzz97DvOp0u5J8jlJ6+nj5I/9bM= X-Google-Smtp-Source: APXvYqwDNKLTMzuI6cUfCSzer7pg5nvTND+OyJIR6wrp6alk+O0roVaCrjZib/qKZ5KWhlhfVnhE9w== X-Received: by 2002:a63:d5f:: with SMTP id 31mr6692027pgn.274.1553225372709; Thu, 21 Mar 2019 20:29:32 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id o76sm16154476pfa.156.2019.03.21.20.29.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 20:29:32 -0700 (PDT) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 13/15] drm/bridge: tc358767: Simplify tc_aux_wait_busy() Date: Thu, 21 Mar 2019 20:28:59 -0700 Message-Id: <20190322032901.12045-14-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190322032901.12045-1-andrew.smirnov@gmail.com> References: <20190322032901.12045-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 24 Mar 2019 21:01:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1SpLWn2GNZxw8TpsUtWTa95KkSKBcIOU+P/XIiFsSiI=; b=ExBJCigHEwuSNm8pFYe5VfRDt3bPfhu1chj0ZBLPO7EvUOwWM0hKSzvPggK8vO7irL vKLPf4b/aFg346Os1URvrw556chW+wPGtsrG/U2ELc8Z0fKA5sopu4uwMRqdH+pSOgP0 ZIbyRzMtSv18l4cHrbMfTu42mYN65RB20wMSSLht38RbRcaTLW/DQlXOT6jtyUVOlpit w0WDnrKfEwEn/n7KBCrhEA2/qS9RlfAawXsVgFaluIa1mYYWuduq++3qu665+LkH+44v k1ltbSzxg9id4vrhzvXZ3oolD52ZPIGIf4OiYmTx43R5QJUCuFLB0ncTOYjwf4aWHD9B JfoA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Andrey Gusakov , linux-kernel@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , Chris Healy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP We never pass anything but 100 as timeout_ms to tc_aux_wait_busy(), so we may as well hardcode that value and simplify function's signature. Signed-off-by: Andrey Smirnov Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Tomi Valkeinen Cc: Andrey Gusakov Cc: Philipp Zabel Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index f66a1c4a2047..07d568761463 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -280,10 +280,9 @@ static inline int tc_poll_timeout(struct tc_data *tc, unsigned int addr, sleep_us, timeout_us); } -static int tc_aux_wait_busy(struct tc_data *tc, unsigned int timeout_ms) +static int tc_aux_wait_busy(struct tc_data *tc) { - return tc_poll_timeout(tc, DP0_AUXSTATUS, AUX_BUSY, 0, - 1000, 1000 * timeout_ms); + return tc_poll_timeout(tc, DP0_AUXSTATUS, AUX_BUSY, 0, 1000, 100000); } static int tc_aux_write_data(struct tc_data *tc, const void *data, @@ -354,7 +353,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, u32 auxstatus; int ret; - ret = tc_aux_wait_busy(tc, 100); + ret = tc_aux_wait_busy(tc); if (ret) return ret; @@ -381,7 +380,7 @@ static ssize_t tc_aux_transfer(struct drm_dp_aux *aux, if (ret) return ret; - ret = tc_aux_wait_busy(tc, 100); + ret = tc_aux_wait_busy(tc); if (ret) return ret;