From patchwork Fri Mar 22 03:29:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10867665 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C9101390 for ; Sun, 24 Mar 2019 21:02:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE8CA28CA8 for ; Sun, 24 Mar 2019 21:02:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E317B28D92; Sun, 24 Mar 2019 21:02:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8FD6828CA8 for ; Sun, 24 Mar 2019 21:02:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B461F6E55C; Sun, 24 Mar 2019 21:01:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDC466E238 for ; Fri, 22 Mar 2019 03:29:34 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id a22so473709pgg.13 for ; Thu, 21 Mar 2019 20:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U2pUVl85WTK27TjuFsywFRLpzvqMpXhlPibWJ+DDAXE=; b=nwNEWFlJF2jNa3niIapPJpp6988o/3UY5L+lgnm9f+LR3oz4abfLIWLhqbuo52BWvX +T7vRGYW5PJL2+/fPxG2iFDnYgzbZyncWHoCbUzT72f7yuNlB/stqJ9iIMpOro8RXc/O CN07Sh5tQUCzsUzdJ3WsunsVruZTYmLhnCFctsjTl2p3H1OIGFkmMuLaDLbjgzv9xsr5 hGGgsIff8H8V/0J6PlrDUElgOTeDOkHc2w1hNw1gZMvDo+V8cxzYBZx8g/e5qA1YWHle M6W1eKcNCDlofFrlv0dwKeoyPVocGKA7KAbNLpM/eL1tHbHWohjNzCoYotTh0WBn9OJq cHWw== X-Gm-Message-State: APjAAAVKzUTLN+W4xrPYxZkUrvIKl8MaW/khhLiNoaMIm8nZMmE+OYTM n1PphxpmvdvO5LbsRX1qUtFdjgHUkMs= X-Google-Smtp-Source: APXvYqxIMiSuNyLWsnL1btTMzjK+GscDB8j6pHTo2ESUDPbJiryENsUL7aJdNxKDDDXXoWJOyAYMEQ== X-Received: by 2002:a65:6489:: with SMTP id e9mr6682897pgv.260.1553225374020; Thu, 21 Mar 2019 20:29:34 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id o76sm16154476pfa.156.2019.03.21.20.29.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 20:29:33 -0700 (PDT) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 14/15] drm/bridge: tc358767: Drop unnecessary 8 byte buffer Date: Thu, 21 Mar 2019 20:29:00 -0700 Message-Id: <20190322032901.12045-15-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190322032901.12045-1-andrew.smirnov@gmail.com> References: <20190322032901.12045-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 24 Mar 2019 21:01:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U2pUVl85WTK27TjuFsywFRLpzvqMpXhlPibWJ+DDAXE=; b=Y6l7lu8WDnNblQcW320Lc/MAAmqLRFPcHr4H0wAUI19FU5whViPeIMu61YW0eoLoWX n0/xZK42iLTuX02jmb7RTkFf0cKtvW4M2t/GjlS92uWVLVldaqxzV6LkVuza5TVlfP8s bHNJRDQxbFadDQ2pzAv6Qiy1RZn9kEOtoEYDX4A+vsyuXNoAue+gH1HKZf1a9KBN0AXT ShAPVHzVLeEK6Eb8YL+eDfHRZUCBLI48C45ESjDNm2DveiD8wvmUw8gsZ95btWo7p2AZ JgUS54t/yUwSN79jX8cdmS+himUmkEtD/uzBNBmVn3Fd7q4CQz+YfhpRWdWZks3eWWb1 pYOQ== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Andrey Gusakov , linux-kernel@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , Chris Healy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP tc_get_display_props() never reads more than a byte via AUX, so there's no need to reserve 8 for that purpose. No function change intended. Signed-off-by: Andrey Smirnov Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Tomi Valkeinen Cc: Andrey Gusakov Cc: Philipp Zabel Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org --- drivers/gpu/drm/bridge/tc358767.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 07d568761463..b106e6181a5f 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -664,8 +664,7 @@ static int tc_aux_link_setup(struct tc_data *tc) static int tc_get_display_props(struct tc_data *tc) { int ret; - /* temp buffer */ - u8 tmp[8]; + u8 reg; /* Read DP Rx Link Capability */ ret = drm_dp_link_probe(&tc->aux, &tc->link.base); @@ -681,21 +680,21 @@ static int tc_get_display_props(struct tc_data *tc) tc->link.base.num_lanes = 2; } - ret = drm_dp_dpcd_readb(&tc->aux, DP_MAX_DOWNSPREAD, tmp); + ret = drm_dp_dpcd_readb(&tc->aux, DP_MAX_DOWNSPREAD, ®); if (ret < 0) goto err_dpcd_read; - tc->link.spread = tmp[0] & DP_MAX_DOWNSPREAD_0_5; + tc->link.spread = reg & DP_MAX_DOWNSPREAD_0_5; - ret = drm_dp_dpcd_readb(&tc->aux, DP_MAIN_LINK_CHANNEL_CODING, tmp); + ret = drm_dp_dpcd_readb(&tc->aux, DP_MAIN_LINK_CHANNEL_CODING, ®); if (ret < 0) goto err_dpcd_read; tc->link.scrambler_dis = false; /* read assr */ - ret = drm_dp_dpcd_readb(&tc->aux, DP_EDP_CONFIGURATION_SET, tmp); + ret = drm_dp_dpcd_readb(&tc->aux, DP_EDP_CONFIGURATION_SET, ®); if (ret < 0) goto err_dpcd_read; - tc->link.assr = tmp[0] & DP_ALTERNATE_SCRAMBLER_RESET_ENABLE; + tc->link.assr = reg & DP_ALTERNATE_SCRAMBLER_RESET_ENABLE; dev_dbg(tc->dev, "DPCD rev: %d.%d, rate: %s, lanes: %d, framing: %s\n", tc->link.base.revision >> 4, tc->link.base.revision & 0x0f,