From patchwork Sun Mar 24 23:16:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 10868169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D71D81390 for ; Mon, 25 Mar 2019 08:12:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7CEC2925F for ; Mon, 25 Mar 2019 08:12:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BC5C12928B; Mon, 25 Mar 2019 08:12:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6DF682927F for ; Mon, 25 Mar 2019 08:12:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34FAF6E675; Mon, 25 Mar 2019 08:12:00 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mta-p6.oit.umn.edu (mta-p6.oit.umn.edu [134.84.196.206]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5A416E632 for ; Sun, 24 Mar 2019 23:16:09 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id A0D6396D for ; Sun, 24 Mar 2019 23:16:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HSHi94z19EEp for ; Sun, 24 Mar 2019 18:16:08 -0500 (CDT) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 7574195E for ; Sun, 24 Mar 2019 18:16:08 -0500 (CDT) Received: by mail-io1-f71.google.com with SMTP id c2so6549946ioh.11 for ; Sun, 24 Mar 2019 16:16:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UMAQnPK8j5lO5BOxxgj71E79FbIAa75eJ6alCWr8K1k=; b=iRndfefMPSF/y4kyu4L/DCVN6ijts90qAzXcJkIrhuJjZta9vA5jKaNq2OxOEaQ6Sy jmusIPzC+lISnfEs3Kxn9RvnaVLGXFd3ynpQ6q+UkCUv6ECqQs55IvdZEZ55dkbrboNL OcqUxxtCXSAkIzpOWV2IMSqyXBueMVV++LPtUmDPbXxppIGqDpjDjcLU79YYh3INLMn9 vx7ENWKTZ40dJH71IanwHy2/NMxuqlaCN9JHzWQkF3L2pPXO1V8XVEufsEX8ne7UKuB0 c8rCC3mCdm3vf/retIkvfFfwXi5u9cawSqwr8miSlTMHytVXVgBTXTTF+4G677+tXxoc Y+rg== X-Gm-Message-State: APjAAAUn8esWRDHz6fS7JHylKoLSCREHpVIJcXhhp1GceS/9OGUzVZAf XPEtFBPSUu34ErTJUPxUwSs7jRh5/XgEBl+UBTQ8x/v7Jp5Ejqzz7wLXfWG5WNLtyqHUdOoykcg lLsT6Lf24YNC9F4Pa1sBiKiDo/+45+HQ/ X-Received: by 2002:a24:66c8:: with SMTP id k191mr9041390itc.20.1553469367962; Sun, 24 Mar 2019 16:16:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQmdvSQx0UEc7t6VCyV20zttcRLKZUoiSr/ZW9vSuUpYzSY3m3DYXu4MH75EjHhgiz+c0+pw== X-Received: by 2002:a24:66c8:: with SMTP id k191mr9041383itc.20.1553469367773; Sun, 24 Mar 2019 16:16:07 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id g186sm8731444iof.41.2019.03.24.16.16.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 16:16:06 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Subject: [PATCH] gpu: v3d: fix a missing check of pm_runtime_get_sync Date: Sun, 24 Mar 2019 18:16:02 -0500 Message-Id: <20190324231602.2436-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Mon, 25 Mar 2019 08:11:58 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=UMAQnPK8j5lO5BOxxgj71E79FbIAa75eJ6alCWr8K1k=; b=p6FDm876+CtOb/WltSl9lshn+E4ZUw6BKrh0KCI2oxFFnrbPVDnkvvDE3hupwAH9sc rN9uUgROqngd3IrnGtE4VC0Q5gVPT8cZBKYCIcD1nTKk/QZvgdokrS2ZfW9e1ZOKXgx4 d7MaYScWMo4kbmOoS/GoJWaWtTxH/8ilwZmcoS3HG8AZ4HjF1E01AVVsMy+weCoy6Gvp MeaNDDz/ZFaXQEdSaxj7wspCXzIMIIP+4ZBLK8ETxyLxYJurkg5M6rxSYvZjvRaUatCS xo2Wc1WJqcKYUDPxcrQLHHcCO6tZclOWFrSgkMIu9y4W/AXWKY+D3VViBmvU64HXu8sx nXRw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, pakki001@umn.edu MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP pm_runtime_get_sync could fail and thus deserves a check. The patch adds such a check and return its error code upstream if it indeed failed. Signed-off-by: Kangjie Lu Reviewed-by: Mukesh Ojha --- drivers/gpu/drm/v3d/v3d_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index f0afcec72c34..99daad11fac2 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -101,6 +101,8 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data, return -EINVAL; ret = pm_runtime_get_sync(v3d->dev); + if (ret < 0) + return ret; if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 && args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) { args->value = V3D_CORE_READ(0, offset);