diff mbox series

[v7,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

Message ID 20190326070933.2735-1-hanxu5@huaqin.corp-partner.google.com (mailing list archive)
State New, archived
Headers show
Series [v7,1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel | expand

Commit Message

Jerry Han March 26, 2019, 7:09 a.m. UTC 
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
panel.

V7:
- Add the information of the reviewer
- Remove unnecessary delays, The udelay_range code gracefully returns
    without hitting the scheduler on a delay of 0. (Derek)
- Merge the same data structures, like display_mode and off_cmds (Derek)
- Optimize the processing of results returned by
    devm_gpiod_get_optional (Derek)

V6:
- Add the information of the reviewer (Sam)
- Delete unnecessary header files #include <linux/fb.h> (Sam)
- The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
- ADD static, set_gpios function is not used outside this module (Sam)

V5:
- Added changelog

V4:
- Frefix all function maes with boe_ (Sam)
- Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
- Sort include lines alphabetically (Sam)
- Fixed entries in the makefile must be sorted alphabetically (Sam)
- Add send_mipi_cmds function to avoid duplicating the code (Sam)
- Add the necessary delay(reset_delay_t5) between reset and sending
    the initialization command (Rock wang)

V3:
- Remove unnecessary delays in sending initialization commands (Jitao Shi)

V2:
- Use SPDX identifier (Sam)
- Use necessary header files replace drmP.h (Sam)
- Delete unnecessary header files #include <linux/err.h> (Sam)
- Specifies a GPIOs array to control the reset timing,
    instead of reading "dsi-reset-sequence" data from DTS (Sam)
- Delete backlight_disable() function when already disabled (Sam)
- Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
- Move the necessary data in the DTS to the current file,
    like porch, display_mode and Init code etc. (Sam)
- Add compatible device "boe,himax8279d10p" (Sam)

Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Derek Basehore <dbasehore@chromium.org>
Cc: Jitao Shi <jitao.shi@mediatek.com>
Cc: Rock wang <rock_wang@himax.com.cn>
---
 MAINTAINERS                                  |    6 +
 drivers/gpu/drm/panel/Kconfig                |   11 +
 drivers/gpu/drm/panel/Makefile               |    1 +
 drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++
 4 files changed, 1068 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c

Comments

Derek Basehore March 27, 2019, 3:11 a.m. UTC | #1 
On Tue, Mar 26, 2019 at 12:09 AM Jerry Han <jerry.han.hq@gmail.com> wrote:
>
> Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> panel.
>
> V7:
> - Add the information of the reviewer
> - Remove unnecessary delays, The udelay_range code gracefully returns
>     without hitting the scheduler on a delay of 0. (Derek)
> - Merge the same data structures, like display_mode and off_cmds (Derek)
> - Optimize the processing of results returned by
>     devm_gpiod_get_optional (Derek)

Looks good to me overall. There's still some duplication on values
like number of lanes, but that's not a blocking concern for me.

>
> V6:
> - Add the information of the reviewer (Sam)
> - Delete unnecessary header files #include <linux/fb.h> (Sam)
> - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
> - ADD static, set_gpios function is not used outside this module (Sam)
>
> V5:
> - Added changelog
>
> V4:
> - Frefix all function maes with boe_ (Sam)
> - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
> - Sort include lines alphabetically (Sam)
> - Fixed entries in the makefile must be sorted alphabetically (Sam)
> - Add send_mipi_cmds function to avoid duplicating the code (Sam)
> - Add the necessary delay(reset_delay_t5) between reset and sending
>     the initialization command (Rock wang)
>
> V3:
> - Remove unnecessary delays in sending initialization commands (Jitao Shi)
>
> V2:
> - Use SPDX identifier (Sam)
> - Use necessary header files replace drmP.h (Sam)
> - Delete unnecessary header files #include <linux/err.h> (Sam)
> - Specifies a GPIOs array to control the reset timing,
>     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> - Delete backlight_disable() function when already disabled (Sam)
> - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
> - Move the necessary data in the DTS to the current file,
>     like porch, display_mode and Init code etc. (Sam)
> - Add compatible device "boe,himax8279d10p" (Sam)
>
> Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Reviewed-by: Derek Basehore <dbasehore@chromium.org>
> Cc: Jitao Shi <jitao.shi@mediatek.com>
> Cc: Rock wang <rock_wang@himax.com.cn>
> ---
>  MAINTAINERS                                  |    6 +
>  drivers/gpu/drm/panel/Kconfig                |   11 +
>  drivers/gpu/drm/panel/Makefile               |    1 +
>  drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++
>  4 files changed, 1068 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f8e63bcc4c1c..267468ca72bb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4816,6 +4816,12 @@ T:       git git://anongit.freedesktop.org/drm/drm-misc
>  S:     Maintained
>  F:     drivers/gpu/drm/bochs/
>
> +DRM DRIVER FOR BOE HIMAX8279D PANELS
> +M:     Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> +S:     Maintained
> +F:     drivers/gpu/drm/panel/panel-boe-himax8279d.c
> +F:     Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> +
>  DRM DRIVER FOR FARADAY TVE200 TV ENCODER
>  M:     Linus Walleij <linus.walleij@linaro.org>
>  T:     git git://anongit.freedesktop.org/drm/drm-misc
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index f53f817356db..fe2f87cc6627 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -17,6 +17,17 @@ config DRM_PANEL_ARM_VERSATILE
>           reference designs. The panel is detected using special registers
>           in the Versatile family syscon registers.
>
> +config DRM_PANEL_BOE_HIMAX8279D
> +       tristate "Boe Himax8279d panel"
> +       depends on OF
> +       depends on DRM_MIPI_DSI
> +       depends on BACKLIGHT_CLASS_DEVICE
> +       help
> +         Say Y here if you want to enable support for Boe Himax8279d
> +         TFT-LCD modules. The panel has a 1200x1920 resolution and uses
> +         24 bit RGB per pixel. It provides a MIPI DSI interface to
> +         the host and has a built-in LED backlight.
> +
>  config DRM_PANEL_LVDS
>         tristate "Generic LVDS panel driver"
>         depends on OF
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index 7834947a53b0..c4814b6f069e 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o
> +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
>  obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
>  obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
>  obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o
> diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> new file mode 100644
> index 000000000000..ff5a89e38fd7
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> @@ -0,0 +1,1050 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd
> + *
> + * Author: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> + *
> + */
> +
> +#include <linux/backlight.h>
> +#include <linux/delay.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +
> +#include <linux/gpio/consumer.h>
> +#include <linux/regulator/consumer.h>
> +
> +#include <drm/drm_device.h>
> +#include <drm/drm_mipi_dsi.h>
> +#include <drm/drm_modes.h>
> +#include <drm/drm_panel.h>
> +#include <drm/drm_print.h>
> +
> +#include <video/mipi_display.h>
> +
> +struct panel_cmd {
> +       size_t len;
> +       const char *data;
> +};
> +
> +#define _INIT_CMD(...) { \
> +       .len = sizeof((char[]){__VA_ARGS__}), \
> +       .data = (char[]){__VA_ARGS__} }
> +
> +struct panel_desc {
> +       const struct drm_display_mode *display_mode;
> +       unsigned int bpc;
> +       unsigned int width_mm;
> +       unsigned int height_mm;
> +
> +       unsigned int delay_t1;
> +       unsigned int reset_delay_t2;
> +       unsigned int reset_delay_t3;
> +       unsigned int reset_delay_t4;
> +       unsigned int reset_delay_t5;
> +
> +       unsigned long mode_flags;
> +       enum mipi_dsi_pixel_format format;
> +       unsigned int lanes;
> +       const struct panel_cmd *on_cmds;
> +       const struct panel_cmd *off_cmds;
> +};
> +
> +struct panel_info {
> +       struct drm_panel base;
> +       struct mipi_dsi_device *link;
> +       const struct panel_desc *desc;
> +
> +       struct backlight_device *backlight;
> +       struct gpio_desc *enable_gpio;
> +       struct gpio_desc *pp33_gpio;
> +       struct gpio_desc *pp18_gpio;
> +
> +       bool prepared;
> +       bool enabled;
> +};
> +
> +static inline struct panel_info *to_panel_info(struct drm_panel *panel)
> +{
> +       return container_of(panel, struct panel_info, base);
> +}
> +
> +static void set_gpios(struct panel_info *pinfo, int enable)
> +{
> +       gpiod_set_value(pinfo->enable_gpio, enable);
> +       gpiod_set_value(pinfo->pp33_gpio, enable);
> +       gpiod_set_value(pinfo->pp18_gpio, enable);
> +}
> +
> +static int send_mipi_cmds(struct drm_panel *panel, const struct panel_cmd *cmds)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       unsigned int i = 0;
> +       int err;
> +
> +       if (!cmds)
> +               return -EFAULT;
> +
> +       for (i = 0; cmds[i].len != 0; i++) {
> +               const struct panel_cmd *cmd = &cmds[i];
> +
> +               if (cmd->len == 2)
> +                       err = mipi_dsi_dcs_write(pinfo->link,
> +                                                   cmd->data[1], NULL, 0);
> +               else
> +                       err = mipi_dsi_dcs_write(pinfo->link,
> +                                                   cmd->data[1], cmd->data + 2,
> +                                                   cmd->len - 2);
> +
> +               if (err < 0)
> +                       return err;
> +
> +               usleep_range((cmd->data[0]) * 1000,
> +                           (1 + cmd->data[0]) * 1000);
> +       }
> +
> +       return 0;
> +}
> +
> +static int boe_panel_disable(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +
> +       backlight_disable(pinfo->backlight);
> +
> +       pinfo->enabled = false;
> +
> +       return 0;
> +}
> +
> +static int boe_panel_unprepare(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       int err;
> +
> +       if (!pinfo->prepared)
> +               return 0;
> +
> +       /* send off code */
> +       err = send_mipi_cmds(panel, pinfo->desc->off_cmds);
> +       if (err < 0) {
> +               DRM_DEV_ERROR(panel->dev,
> +                               "failed to send DCS Off Code: %d\n", err);
> +               goto poweroff;
> +       }
> +
> +       set_gpios(pinfo, 0);
> +
> +       pinfo->prepared = false;
> +
> +       return 0;
> +
> +poweroff:
> +       set_gpios(pinfo, 0);
> +       return err;
> +}
> +
> +static int boe_panel_prepare(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       const struct panel_desc *desc = pinfo->desc;
> +       int err;
> +
> +       if (pinfo->prepared)
> +               return 0;
> +
> +       gpiod_set_value(pinfo->pp18_gpio, 1);
> +       /* T1 (> 5ms) */
> +       usleep_range(desc->delay_t1, 1000 + desc->delay_t1);
> +       gpiod_set_value(pinfo->pp33_gpio, 1);
> +
> +       /* reset sequence */
> +       usleep_range(desc->reset_delay_t2, 1000 + desc->reset_delay_t2);
> +
> +       gpiod_set_value(pinfo->enable_gpio, 1);
> +       usleep_range(desc->reset_delay_t3, 1000 + desc->reset_delay_t3);
> +       gpiod_set_value(pinfo->enable_gpio, 0);
> +
> +       usleep_range(desc->reset_delay_t4, 1000 + desc->reset_delay_t4);
> +       gpiod_set_value(pinfo->enable_gpio, 1);
> +
> +       usleep_range(desc->reset_delay_t5, 1000 + desc->reset_delay_t5);
> +
> +       /* send init code */
> +       err = send_mipi_cmds(panel, pinfo->desc->on_cmds);
> +       if (err < 0) {
> +               DRM_DEV_ERROR(panel->dev,
> +                               "failed to send DCS Init Code: %d\n", err);
> +               goto poweroff;
> +       }
> +
> +       pinfo->prepared = true;
> +
> +       return 0;
> +
> +poweroff:
> +       set_gpios(pinfo, 0);
> +       return err;
> +}
> +
> +static int boe_panel_enable(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       int ret;
> +
> +       if (pinfo->enabled)
> +               return 0;
> +
> +       ret = backlight_enable(pinfo->backlight);
> +       if (ret) {
> +               DRM_DEV_ERROR(panel->drm->dev,
> +                               "Failed to enable backlight %d\n", ret);
> +               return ret;
> +       }
> +
> +       pinfo->enabled = true;
> +
> +       return 0;
> +}
> +
> +static int boe_panel_get_modes(struct drm_panel *panel)
> +{
> +       struct panel_info *pinfo = to_panel_info(panel);
> +       const struct drm_display_mode *m = pinfo->desc->display_mode;
> +       struct drm_display_mode *mode;
> +
> +       mode = drm_mode_duplicate(panel->drm, m);
> +       if (!mode) {
> +               DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%u@%u\n",
> +                               m->hdisplay, m->vdisplay, m->vrefresh);
> +               return -ENOMEM;
> +       }
> +
> +       drm_mode_set_name(mode);
> +
> +       drm_mode_probed_add(panel->connector, mode);
> +
> +       panel->connector->display_info.width_mm = pinfo->desc->width_mm;
> +       panel->connector->display_info.height_mm = pinfo->desc->height_mm;
> +       panel->connector->display_info.bpc = pinfo->desc->bpc;
> +
> +       return 1;
> +}
> +
> +static const struct drm_panel_funcs panel_funcs = {
> +       .disable = boe_panel_disable,
> +       .unprepare = boe_panel_unprepare,
> +       .prepare = boe_panel_prepare,
> +       .enable = boe_panel_enable,
> +       .get_modes = boe_panel_get_modes,
> +};
> +
> +static const struct drm_display_mode default_display_mode = {
> +       .clock = 159420,
> +       .hdisplay = 1200,
> +       .hsync_start = 1200 + 80,
> +       .hsync_end = 1200 + 80 + 60,
> +       .htotal = 1200 + 80 + 60 + 24,
> +       .vdisplay = 1920,
> +       .vsync_start = 1920 + 10,
> +       .vsync_end = 1920 + 10 + 14,
> +       .vtotal = 1920 + 10 + 14 + 4,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_cmd default_off_cmds[] = {
> +       _INIT_CMD(0x00, 0x28),
> +       _INIT_CMD(0x01, 0x10),
> +
> +       {},
> +};
> +
> +/* 8 inch */
> +static const struct panel_cmd boe_himax8279d8p_on_cmds[] = {
> +       _INIT_CMD(0x22, 0x10),
> +       _INIT_CMD(0x00, 0xB0, 0x05),
> +       _INIT_CMD(0x00, 0xB1, 0xE5),
> +       _INIT_CMD(0x00, 0xB3, 0x52),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x88),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x50),
> +       _INIT_CMD(0x00, 0xB6, 0x03),
> +       _INIT_CMD(0x00, 0xBA, 0x8B),
> +       _INIT_CMD(0x00, 0xBF, 0x15),
> +       _INIT_CMD(0x00, 0xC0, 0x0F),
> +       _INIT_CMD(0x00, 0xC2, 0x0C),
> +       _INIT_CMD(0x00, 0xC3, 0x02),
> +       _INIT_CMD(0x00, 0xC4, 0x0C),
> +       _INIT_CMD(0x00, 0xC5, 0x02),
> +       _INIT_CMD(0x00, 0xB0, 0x01),
> +       _INIT_CMD(0x00, 0xE0, 0x26),
> +       _INIT_CMD(0x00, 0xE1, 0x26),
> +       _INIT_CMD(0x00, 0xDC, 0x00),
> +       _INIT_CMD(0x00, 0xDD, 0x00),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x26),
> +       _INIT_CMD(0x00, 0xC8, 0x00),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xD2, 0x04),
> +       _INIT_CMD(0x00, 0xD3, 0x04),
> +       _INIT_CMD(0x00, 0xE6, 0x03),
> +       _INIT_CMD(0x00, 0xE7, 0x03),
> +       _INIT_CMD(0x00, 0xC4, 0x08),
> +       _INIT_CMD(0x00, 0xC5, 0x08),
> +       _INIT_CMD(0x00, 0xD8, 0x07),
> +       _INIT_CMD(0x00, 0xD9, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x06),
> +       _INIT_CMD(0x00, 0xC3, 0x06),
> +       _INIT_CMD(0x00, 0xD6, 0x05),
> +       _INIT_CMD(0x00, 0xD7, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x0C),
> +       _INIT_CMD(0x00, 0xC1, 0x0C),
> +       _INIT_CMD(0x00, 0xD4, 0x0B),
> +       _INIT_CMD(0x00, 0xD5, 0x0B),
> +       _INIT_CMD(0x00, 0xCA, 0x0A),
> +       _INIT_CMD(0x00, 0xCB, 0x0A),
> +       _INIT_CMD(0x00, 0xDE, 0x09),
> +       _INIT_CMD(0x00, 0xDF, 0x09),
> +       _INIT_CMD(0x00, 0xC6, 0x26),
> +       _INIT_CMD(0x00, 0xC7, 0x26),
> +       _INIT_CMD(0x00, 0xCE, 0x00),
> +       _INIT_CMD(0x00, 0xCF, 0x00),
> +       _INIT_CMD(0x00, 0xDA, 0x26),
> +       _INIT_CMD(0x00, 0xDB, 0x26),
> +       _INIT_CMD(0x00, 0xE2, 0x00),
> +       _INIT_CMD(0x00, 0xE3, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x02),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xC1, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x0D),
> +       _INIT_CMD(0x00, 0xC3, 0x18),
> +       _INIT_CMD(0x00, 0xC4, 0x27),
> +       _INIT_CMD(0x00, 0xC5, 0x28),
> +       _INIT_CMD(0x00, 0xC6, 0x30),
> +       _INIT_CMD(0x00, 0xC7, 0x2E),
> +       _INIT_CMD(0x00, 0xC8, 0x2F),
> +       _INIT_CMD(0x00, 0xC9, 0x1A),
> +       _INIT_CMD(0x00, 0xCA, 0x20),
> +       _INIT_CMD(0x00, 0xCB, 0x29),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x32),
> +       _INIT_CMD(0x00, 0xCE, 0x33),
> +       _INIT_CMD(0x00, 0xCF, 0x31),
> +       _INIT_CMD(0x00, 0xD0, 0x06),
> +       _INIT_CMD(0x00, 0xD2, 0x00),
> +       _INIT_CMD(0x00, 0xD3, 0x07),
> +       _INIT_CMD(0x00, 0xD4, 0x12),
> +       _INIT_CMD(0x00, 0xD5, 0x26),
> +       _INIT_CMD(0x00, 0xD6, 0x3D),
> +       _INIT_CMD(0x00, 0xD7, 0x3F),
> +       _INIT_CMD(0x00, 0xD8, 0x3F),
> +       _INIT_CMD(0x00, 0xD9, 0x3F),
> +       _INIT_CMD(0x00, 0xDA, 0x3F),
> +       _INIT_CMD(0x00, 0xDB, 0x3F),
> +       _INIT_CMD(0x00, 0xDC, 0x3F),
> +       _INIT_CMD(0x00, 0xDD, 0x3F),
> +       _INIT_CMD(0x00, 0xDE, 0x3F),
> +       _INIT_CMD(0x00, 0xDF, 0x3A),
> +       _INIT_CMD(0x00, 0xE0, 0x37),
> +       _INIT_CMD(0x00, 0xE1, 0x35),
> +       _INIT_CMD(0x00, 0xE2, 0x07),
> +       _INIT_CMD(0x00, 0xB0, 0x03),
> +       _INIT_CMD(0x00, 0xC8, 0x0B),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xC3, 0x00),
> +       _INIT_CMD(0x00, 0xE7, 0x00),
> +       _INIT_CMD(0x00, 0xC5, 0x2A),
> +       _INIT_CMD(0x00, 0xDE, 0x2A),
> +       _INIT_CMD(0x00, 0xCA, 0x43),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xE4, 0xC0),
> +       _INIT_CMD(0x00, 0xE5, 0x0D),
> +       _INIT_CMD(0x00, 0xCB, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x06),
> +       _INIT_CMD(0x00, 0xB8, 0xA5),
> +       _INIT_CMD(0x00, 0xC0, 0xA5),
> +       _INIT_CMD(0x00, 0xC7, 0x0F),
> +       _INIT_CMD(0x00, 0xD5, 0x32),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xBC, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x07),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x08),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x05, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x09),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0A),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0B),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x05, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0C),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x05, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x64, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x08),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x0A, 0xB8, 0x68),
> +       _INIT_CMD(0x78, 0x11),
> +       _INIT_CMD(0x14, 0x29),
> +
> +       {},
> +};
> +
> +static const struct panel_desc boe_himax8279d8p_panel_desc = {
> +       .display_mode = &default_display_mode,
> +       .bpc = 8,
> +       .width_mm = 107,
> +       .height_mm = 172,
> +       .delay_t1 = 5000,
> +       .reset_delay_t2 = 14000,
> +       .reset_delay_t3 = 1000,
> +       .reset_delay_t4 = 1000,
> +       .reset_delay_t5 = 5000,
> +       .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +                       MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +       .format = MIPI_DSI_FMT_RGB888,
> +       .lanes = 4,
> +       .on_cmds = boe_himax8279d8p_on_cmds,
> +       .off_cmds = default_off_cmds,
> +};
> +
> +/* 10 inch */
> +static const struct panel_cmd boe_himax8279d10p_on_cmds[] = {
> +       _INIT_CMD(0x00, 0xB0, 0x05),
> +       _INIT_CMD(0x00, 0xB1, 0xE5),
> +       _INIT_CMD(0x00, 0xB3, 0x52),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x88),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x50),
> +       _INIT_CMD(0x00, 0xB6, 0x03),
> +       _INIT_CMD(0x00, 0xBA, 0x8B),
> +       _INIT_CMD(0x00, 0xBF, 0x1A),
> +       _INIT_CMD(0x00, 0xC0, 0x0F),
> +       _INIT_CMD(0x00, 0xC2, 0x0C),
> +       _INIT_CMD(0x00, 0xC3, 0x02),
> +       _INIT_CMD(0x00, 0xC4, 0x0C),
> +       _INIT_CMD(0x00, 0xC5, 0x02),
> +       _INIT_CMD(0x00, 0xB0, 0x01),
> +       _INIT_CMD(0x00, 0xE0, 0x26),
> +       _INIT_CMD(0x00, 0xE1, 0x26),
> +       _INIT_CMD(0x00, 0xDC, 0x00),
> +       _INIT_CMD(0x00, 0xDD, 0x00),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x26),
> +       _INIT_CMD(0x00, 0xC8, 0x00),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xD2, 0x04),
> +       _INIT_CMD(0x00, 0xD3, 0x04),
> +       _INIT_CMD(0x00, 0xE6, 0x03),
> +       _INIT_CMD(0x00, 0xE7, 0x03),
> +       _INIT_CMD(0x00, 0xC4, 0x08),
> +       _INIT_CMD(0x00, 0xC5, 0x08),
> +       _INIT_CMD(0x00, 0xD8, 0x07),
> +       _INIT_CMD(0x00, 0xD9, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x06),
> +       _INIT_CMD(0x00, 0xC3, 0x06),
> +       _INIT_CMD(0x00, 0xD6, 0x05),
> +       _INIT_CMD(0x00, 0xD7, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x0C),
> +       _INIT_CMD(0x00, 0xC1, 0x0C),
> +       _INIT_CMD(0x00, 0xD4, 0x0B),
> +       _INIT_CMD(0x00, 0xD5, 0x0B),
> +       _INIT_CMD(0x00, 0xCA, 0x0A),
> +       _INIT_CMD(0x00, 0xCB, 0x0A),
> +       _INIT_CMD(0x00, 0xDE, 0x09),
> +       _INIT_CMD(0x00, 0xDF, 0x09),
> +       _INIT_CMD(0x00, 0xC6, 0x26),
> +       _INIT_CMD(0x00, 0xC7, 0x26),
> +       _INIT_CMD(0x00, 0xCE, 0x00),
> +       _INIT_CMD(0x00, 0xCF, 0x00),
> +       _INIT_CMD(0x00, 0xDA, 0x26),
> +       _INIT_CMD(0x00, 0xDB, 0x26),
> +       _INIT_CMD(0x00, 0xE2, 0x00),
> +       _INIT_CMD(0x00, 0xE3, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x02),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xC1, 0x07),
> +       _INIT_CMD(0x00, 0xC2, 0x0D),
> +       _INIT_CMD(0x00, 0xC3, 0x18),
> +       _INIT_CMD(0x00, 0xC4, 0x27),
> +       _INIT_CMD(0x00, 0xC5, 0x28),
> +       _INIT_CMD(0x00, 0xC6, 0x30),
> +       _INIT_CMD(0x00, 0xC7, 0x2E),
> +       _INIT_CMD(0x00, 0xC8, 0x2F),
> +       _INIT_CMD(0x00, 0xC9, 0x1A),
> +       _INIT_CMD(0x00, 0xCA, 0x20),
> +       _INIT_CMD(0x00, 0xCB, 0x29),
> +       _INIT_CMD(0x00, 0xCC, 0x26),
> +       _INIT_CMD(0x00, 0xCD, 0x32),
> +       _INIT_CMD(0x00, 0xCE, 0x33),
> +       _INIT_CMD(0x00, 0xCF, 0x31),
> +       _INIT_CMD(0x00, 0xD0, 0x06),
> +       _INIT_CMD(0x00, 0xD2, 0x00),
> +       _INIT_CMD(0x00, 0xD3, 0x07),
> +       _INIT_CMD(0x00, 0xD4, 0x12),
> +       _INIT_CMD(0x00, 0xD5, 0x26),
> +       _INIT_CMD(0x00, 0xD6, 0x3D),
> +       _INIT_CMD(0x00, 0xD7, 0x3F),
> +       _INIT_CMD(0x00, 0xD8, 0x3F),
> +       _INIT_CMD(0x00, 0xD9, 0x3F),
> +       _INIT_CMD(0x00, 0xDA, 0x3F),
> +       _INIT_CMD(0x00, 0xDB, 0x3F),
> +       _INIT_CMD(0x00, 0xDC, 0x3F),
> +       _INIT_CMD(0x00, 0xDD, 0x3F),
> +       _INIT_CMD(0x00, 0xDE, 0x3F),
> +       _INIT_CMD(0x00, 0xDF, 0x3A),
> +       _INIT_CMD(0x00, 0xE0, 0x37),
> +       _INIT_CMD(0x00, 0xE1, 0x35),
> +       _INIT_CMD(0x00, 0xE2, 0x07),
> +       _INIT_CMD(0x00, 0xB0, 0x03),
> +       _INIT_CMD(0x00, 0xC8, 0x0B),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xC3, 0x00),
> +       _INIT_CMD(0x00, 0xE7, 0x00),
> +       _INIT_CMD(0x00, 0xC5, 0x2A),
> +       _INIT_CMD(0x00, 0xDE, 0x2A),
> +       _INIT_CMD(0x00, 0xCA, 0x43),
> +       _INIT_CMD(0x00, 0xC9, 0x07),
> +       _INIT_CMD(0x00, 0xE4, 0xC0),
> +       _INIT_CMD(0x00, 0xE5, 0x0D),
> +       _INIT_CMD(0x00, 0xCB, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x06),
> +       _INIT_CMD(0x00, 0xB8, 0xA5),
> +       _INIT_CMD(0x00, 0xC0, 0xA5),
> +       _INIT_CMD(0x00, 0xC7, 0x0F),
> +       _INIT_CMD(0x00, 0xD5, 0x32),
> +       _INIT_CMD(0x00, 0xB8, 0x00),
> +       _INIT_CMD(0x00, 0xC0, 0x00),
> +       _INIT_CMD(0x00, 0xBC, 0x00),
> +       _INIT_CMD(0x00, 0xB0, 0x07),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x08),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x00, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x09),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0A),
> +       _INIT_CMD(0x00, 0xB1, 0x00),
> +       _INIT_CMD(0x00, 0xB2, 0x09),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x2F),
> +       _INIT_CMD(0x00, 0xB5, 0x44),
> +       _INIT_CMD(0x00, 0xB6, 0x52),
> +       _INIT_CMD(0x00, 0xB7, 0x6A),
> +       _INIT_CMD(0x00, 0xB8, 0x8A),
> +       _INIT_CMD(0x00, 0xB9, 0xCA),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x87),
> +       _INIT_CMD(0x00, 0xBC, 0x06),
> +       _INIT_CMD(0x00, 0xBD, 0x0A),
> +       _INIT_CMD(0x00, 0xBE, 0x9B),
> +       _INIT_CMD(0x00, 0xBF, 0x0C),
> +       _INIT_CMD(0x00, 0xC0, 0x3D),
> +       _INIT_CMD(0x00, 0xC1, 0x71),
> +       _INIT_CMD(0x00, 0xC2, 0x90),
> +       _INIT_CMD(0x00, 0xC3, 0xA0),
> +       _INIT_CMD(0x00, 0xC4, 0xA8),
> +       _INIT_CMD(0x00, 0xC5, 0xB1),
> +       _INIT_CMD(0x00, 0xC6, 0xBB),
> +       _INIT_CMD(0x00, 0xC7, 0xC0),
> +       _INIT_CMD(0x00, 0xC8, 0xC4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0B),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x08),
> +       _INIT_CMD(0x00, 0xB3, 0x19),
> +       _INIT_CMD(0x00, 0xB4, 0x31),
> +       _INIT_CMD(0x00, 0xB5, 0x46),
> +       _INIT_CMD(0x00, 0xB6, 0x55),
> +       _INIT_CMD(0x00, 0xB7, 0x6E),
> +       _INIT_CMD(0x00, 0xB8, 0x92),
> +       _INIT_CMD(0x00, 0xB9, 0xD4),
> +       _INIT_CMD(0x00, 0xBA, 0x1B),
> +       _INIT_CMD(0x00, 0xBB, 0x9B),
> +       _INIT_CMD(0x00, 0xBC, 0x28),
> +       _INIT_CMD(0x00, 0xBD, 0x2D),
> +       _INIT_CMD(0x00, 0xBE, 0xC3),
> +       _INIT_CMD(0x00, 0xBF, 0x2F),
> +       _INIT_CMD(0x00, 0xC0, 0x62),
> +       _INIT_CMD(0x00, 0xC1, 0x99),
> +       _INIT_CMD(0x00, 0xC2, 0xAB),
> +       _INIT_CMD(0x00, 0xC3, 0xBF),
> +       _INIT_CMD(0x00, 0xC4, 0xCF),
> +       _INIT_CMD(0x00, 0xC5, 0xDF),
> +       _INIT_CMD(0x00, 0xC6, 0xF0),
> +       _INIT_CMD(0x00, 0xC7, 0xF9),
> +       _INIT_CMD(0x00, 0xC8, 0xFC),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x0C),
> +       _INIT_CMD(0x00, 0xB1, 0x04),
> +       _INIT_CMD(0x00, 0xB2, 0x05),
> +       _INIT_CMD(0x00, 0xB3, 0x17),
> +       _INIT_CMD(0x00, 0xB4, 0x2E),
> +       _INIT_CMD(0x00, 0xB5, 0x42),
> +       _INIT_CMD(0x00, 0xB6, 0x51),
> +       _INIT_CMD(0x00, 0xB7, 0x69),
> +       _INIT_CMD(0x00, 0xB8, 0x88),
> +       _INIT_CMD(0x00, 0xB9, 0xC9),
> +       _INIT_CMD(0x00, 0xBA, 0x0C),
> +       _INIT_CMD(0x00, 0xBB, 0x86),
> +       _INIT_CMD(0x00, 0xBC, 0x03),
> +       _INIT_CMD(0x00, 0xBD, 0x08),
> +       _INIT_CMD(0x00, 0xBE, 0x95),
> +       _INIT_CMD(0x00, 0xBF, 0x05),
> +       _INIT_CMD(0x00, 0xC0, 0x35),
> +       _INIT_CMD(0x00, 0xC1, 0x62),
> +       _INIT_CMD(0x00, 0xC2, 0x81),
> +       _INIT_CMD(0x00, 0xC3, 0x96),
> +       _INIT_CMD(0x00, 0xC4, 0x9E),
> +       _INIT_CMD(0x00, 0xC5, 0xA5),
> +       _INIT_CMD(0x00, 0xC6, 0xAD),
> +       _INIT_CMD(0x00, 0xC7, 0xB1),
> +       _INIT_CMD(0x00, 0xC8, 0xB4),
> +       _INIT_CMD(0x00, 0xC9, 0x00),
> +       _INIT_CMD(0x00, 0xCA, 0x00),
> +       _INIT_CMD(0x00, 0xCB, 0x16),
> +       _INIT_CMD(0x00, 0xCC, 0xAF),
> +       _INIT_CMD(0x00, 0xCD, 0xFF),
> +       _INIT_CMD(0x00, 0xCE, 0xFF),
> +       _INIT_CMD(0x00, 0xB0, 0x00),
> +       _INIT_CMD(0x00, 0xB3, 0x08),
> +       _INIT_CMD(0x00, 0xB0, 0x04),
> +       _INIT_CMD(0x64, 0xB8, 0x68),
> +
> +       {},
> +};
> +
> +static const struct panel_desc boe_himax8279d10p_panel_desc = {
> +       .display_mode = &default_display_mode,
> +       .bpc = 8,
> +       .width_mm = 135,
> +       .height_mm = 216,
> +       .delay_t1 = 5000,
> +       .reset_delay_t2 = 14000,
> +       .reset_delay_t3 = 1000,
> +       .reset_delay_t4 = 1000,
> +       .reset_delay_t5 = 5000,
> +       .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> +                       MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +       .format = MIPI_DSI_FMT_RGB888,
> +       .lanes = 4,
> +       .on_cmds = boe_himax8279d10p_on_cmds,
> +       .off_cmds = default_off_cmds,
> +};
> +
> +static const struct of_device_id panel_of_match[] = {
> +       { .compatible = "boe,himax8279d8p",
> +         .data = &boe_himax8279d8p_panel_desc
> +       }, { .compatible = "boe,himax8279d10p",
> +         .data = &boe_himax8279d10p_panel_desc
> +       }, {
> +               /* sentinel */
> +       }
> +};
> +MODULE_DEVICE_TABLE(of, panel_of_match);
> +
> +static int panel_add(struct panel_info *pinfo)
> +{
> +       struct device *dev = &pinfo->link->dev;
> +       int ret;
> +
> +       pinfo->pp18_gpio = devm_gpiod_get_optional(dev, "pp18", GPIOD_OUT_HIGH);
> +       if (IS_ERR(pinfo->pp18_gpio)) {
> +               ret = PTR_ERR(pinfo->pp18_gpio);
> +               if (ret != -EPROBE_DEFER)
> +                       DRM_DEV_ERROR(dev, "failed to get pp18 gpio: %d\n",
> +                                       ret);
> +               return ret;
> +       }
> +
> +       pinfo->pp33_gpio = devm_gpiod_get_optional(dev, "pp33", GPIOD_OUT_HIGH);
> +       if (IS_ERR(pinfo->pp33_gpio)) {
> +               ret = PTR_ERR(pinfo->pp33_gpio);
> +               if (ret != -EPROBE_DEFER)
> +                       DRM_DEV_ERROR(dev, "failed to get pp33 gpio: %d\n",
> +                                       ret);
> +               return ret;
> +       }
> +
> +       pinfo->enable_gpio = devm_gpiod_get_optional(dev, "enable",
> +                                                       GPIOD_OUT_HIGH);
> +       if (IS_ERR(pinfo->enable_gpio)) {
> +               ret = PTR_ERR(pinfo->enable_gpio);
> +               if (ret != -EPROBE_DEFER)
> +                       DRM_DEV_ERROR(dev, "failed to get enable gpio: %d\n",
> +                                       ret);
> +               return ret;
> +       }
> +
> +       pinfo->backlight = devm_of_find_backlight(dev);
> +       if (IS_ERR(pinfo->backlight))
> +               return PTR_ERR(pinfo->backlight);
> +
> +       drm_panel_init(&pinfo->base);
> +       pinfo->base.funcs = &panel_funcs;
> +       pinfo->base.dev = &pinfo->link->dev;
> +
> +       ret = drm_panel_add(&pinfo->base);
> +       if (ret < 0)
> +               return ret;
> +
> +       return 0;
> +}
> +
> +static void panel_del(struct panel_info *pinfo)
> +{
> +       if (pinfo->base.dev)
> +               drm_panel_remove(&pinfo->base);
> +}
> +
> +static int panel_probe(struct mipi_dsi_device *dsi)
> +{
> +       struct panel_info *pinfo;
> +       const struct panel_desc *desc;
> +       int err;
> +
> +       pinfo = devm_kzalloc(&dsi->dev, sizeof(*pinfo), GFP_KERNEL);
> +       if (!pinfo)
> +               return -ENOMEM;
> +
> +       desc = of_device_get_match_data(&dsi->dev);
> +       dsi->mode_flags = desc->mode_flags;
> +       dsi->format = desc->format;
> +       dsi->lanes = desc->lanes;
> +       pinfo->desc = desc;
> +
> +       pinfo->link = dsi;
> +       mipi_dsi_set_drvdata(dsi, pinfo);
> +
> +       err = panel_add(pinfo);
> +       if (err < 0)
> +               return err;
> +
> +       return mipi_dsi_attach(dsi);
> +}
> +
> +static int panel_remove(struct mipi_dsi_device *dsi)
> +{
> +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
> +       int err;
> +
> +       err = boe_panel_unprepare(&pinfo->base);
> +       if (err < 0)
> +               DRM_DEV_ERROR(&dsi->dev, "failed to unprepare panel: %d\n",
> +                               err);
> +
> +       err = boe_panel_disable(&pinfo->base);
> +       if (err < 0)
> +               DRM_DEV_ERROR(&dsi->dev, "failed to disable panel: %d\n", err);
> +
> +       err = mipi_dsi_detach(dsi);
> +       if (err < 0)
> +               DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI host: %d\n",
> +                               err);
> +
> +       drm_panel_detach(&pinfo->base);
> +       panel_del(pinfo);
> +
> +       return 0;
> +}
> +
> +static void panel_shutdown(struct mipi_dsi_device *dsi)
> +{
> +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
> +
> +       boe_panel_disable(&pinfo->base);
> +       boe_panel_unprepare(&pinfo->base);
> +}
> +
> +static struct mipi_dsi_driver panel_driver = {
> +       .driver = {
> +               .name = "panel-boe-himax8279d",
> +               .of_match_table = panel_of_match,
> +       },
> +       .probe = panel_probe,
> +       .remove = panel_remove,
> +       .shutdown = panel_shutdown,
> +};
> +module_mipi_dsi_driver(panel_driver);
> +
> +MODULE_AUTHOR("Jerry Han <hanxu5@huaqin.corp-partner.google.com>");
> +MODULE_DESCRIPTION("Boe Himax8279d driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.17.1
>
Jerry Han April 9, 2019, 2:07 a.m. UTC | #2 
Dear ALL:

Are there any questions about this submission?

   1.   If there are questions? What changes do I need to make
   2.   If it's okay.  When the code will show up in drm-musc (git://
   anongit.freedesktop.org/drm/drm-misc).

Can you give me some advice?

thanks


dbasehore . <dbasehore@chromium.org> 于2019年3月27日周三 上午11:12写道：

> On Tue, Mar 26, 2019 at 12:09 AM Jerry Han <jerry.han.hq@gmail.com> wrote:
> >
> > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> > panel.
> >
> > V7:
> > - Add the information of the reviewer
> > - Remove unnecessary delays, The udelay_range code gracefully returns
> >     without hitting the scheduler on a delay of 0. (Derek)
> > - Merge the same data structures, like display_mode and off_cmds (Derek)
> > - Optimize the processing of results returned by
> >     devm_gpiod_get_optional (Derek)
>
> Looks good to me overall. There's still some duplication on values
> like number of lanes, but that's not a blocking concern for me.
>
> >
> > V6:
> > - Add the information of the reviewer (Sam)
> > - Delete unnecessary header files #include <linux/fb.h> (Sam)
> > - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them
> (Sam)
> > - ADD static, set_gpios function is not used outside this module (Sam)
> >
> > V5:
> > - Added changelog
> >
> > V4:
> > - Frefix all function maes with boe_ (Sam)
> > - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
> > - Sort include lines alphabetically (Sam)
> > - Fixed entries in the makefile must be sorted alphabetically (Sam)
> > - Add send_mipi_cmds function to avoid duplicating the code (Sam)
> > - Add the necessary delay(reset_delay_t5) between reset and sending
> >     the initialization command (Rock wang)
> >
> > V3:
> > - Remove unnecessary delays in sending initialization commands (Jitao
> Shi)
> >
> > V2:
> > - Use SPDX identifier (Sam)
> > - Use necessary header files replace drmP.h (Sam)
> > - Delete unnecessary header files #include <linux/err.h> (Sam)
> > - Specifies a GPIOs array to control the reset timing,
> >     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> > - Delete backlight_disable() function when already disabled (Sam)
> > - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
> > - Move the necessary data in the DTS to the current file,
> >     like porch, display_mode and Init code etc. (Sam)
> > - Add compatible device "boe,himax8279d10p" (Sam)
> >
> > Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > Reviewed-by: Derek Basehore <dbasehore@chromium.org>
> > Cc: Jitao Shi <jitao.shi@mediatek.com>
> > Cc: Rock wang <rock_wang@himax.com.cn>
> > ---
> >  MAINTAINERS                                  |    6 +
> >  drivers/gpu/drm/panel/Kconfig                |   11 +
> >  drivers/gpu/drm/panel/Makefile               |    1 +
> >  drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++
> >  4 files changed, 1068 insertions(+)
> >  create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f8e63bcc4c1c..267468ca72bb 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4816,6 +4816,12 @@ T:       git git://
> anongit.freedesktop.org/drm/drm-misc
> >  S:     Maintained
> >  F:     drivers/gpu/drm/bochs/
> >
> > +DRM DRIVER FOR BOE HIMAX8279D PANELS
> > +M:     Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> > +S:     Maintained
> > +F:     drivers/gpu/drm/panel/panel-boe-himax8279d.c
> > +F:
>  Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
> > +
> >  DRM DRIVER FOR FARADAY TVE200 TV ENCODER
> >  M:     Linus Walleij <linus.walleij@linaro.org>
> >  T:     git git://anongit.freedesktop.org/drm/drm-misc
> > diff --git a/drivers/gpu/drm/panel/Kconfig
> b/drivers/gpu/drm/panel/Kconfig
> > index f53f817356db..fe2f87cc6627 100644
> > --- a/drivers/gpu/drm/panel/Kconfig
> > +++ b/drivers/gpu/drm/panel/Kconfig
> > @@ -17,6 +17,17 @@ config DRM_PANEL_ARM_VERSATILE
> >           reference designs. The panel is detected using special
> registers
> >           in the Versatile family syscon registers.
> >
> > +config DRM_PANEL_BOE_HIMAX8279D
> > +       tristate "Boe Himax8279d panel"
> > +       depends on OF
> > +       depends on DRM_MIPI_DSI
> > +       depends on BACKLIGHT_CLASS_DEVICE
> > +       help
> > +         Say Y here if you want to enable support for Boe Himax8279d
> > +         TFT-LCD modules. The panel has a 1200x1920 resolution and uses
> > +         24 bit RGB per pixel. It provides a MIPI DSI interface to
> > +         the host and has a built-in LED backlight.
> > +
> >  config DRM_PANEL_LVDS
> >         tristate "Generic LVDS panel driver"
> >         depends on OF
> > diff --git a/drivers/gpu/drm/panel/Makefile
> b/drivers/gpu/drm/panel/Makefile
> > index 7834947a53b0..c4814b6f069e 100644
> > --- a/drivers/gpu/drm/panel/Makefile
> > +++ b/drivers/gpu/drm/panel/Makefile
> > @@ -1,5 +1,6 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >  obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o
> > +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
> >  obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
> >  obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
> >  obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o
> > diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> > new file mode 100644
> > index 000000000000..ff5a89e38fd7
> > --- /dev/null
> > +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> > @@ -0,0 +1,1050 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd
> > + *
> > + * Author: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
> > + *
> > + */
> > +
> > +#include <linux/backlight.h>
> > +#include <linux/delay.h>
> > +#include <linux/kernel.h>
> > +#include <linux/module.h>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
> > +
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/regulator/consumer.h>
> > +
> > +#include <drm/drm_device.h>
> > +#include <drm/drm_mipi_dsi.h>
> > +#include <drm/drm_modes.h>
> > +#include <drm/drm_panel.h>
> > +#include <drm/drm_print.h>
> > +
> > +#include <video/mipi_display.h>
> > +
> > +struct panel_cmd {
> > +       size_t len;
> > +       const char *data;
> > +};
> > +
> > +#define _INIT_CMD(...) { \
> > +       .len = sizeof((char[]){__VA_ARGS__}), \
> > +       .data = (char[]){__VA_ARGS__} }
> > +
> > +struct panel_desc {
> > +       const struct drm_display_mode *display_mode;
> > +       unsigned int bpc;
> > +       unsigned int width_mm;
> > +       unsigned int height_mm;
> > +
> > +       unsigned int delay_t1;
> > +       unsigned int reset_delay_t2;
> > +       unsigned int reset_delay_t3;
> > +       unsigned int reset_delay_t4;
> > +       unsigned int reset_delay_t5;
> > +
> > +       unsigned long mode_flags;
> > +       enum mipi_dsi_pixel_format format;
> > +       unsigned int lanes;
> > +       const struct panel_cmd *on_cmds;
> > +       const struct panel_cmd *off_cmds;
> > +};
> > +
> > +struct panel_info {
> > +       struct drm_panel base;
> > +       struct mipi_dsi_device *link;
> > +       const struct panel_desc *desc;
> > +
> > +       struct backlight_device *backlight;
> > +       struct gpio_desc *enable_gpio;
> > +       struct gpio_desc *pp33_gpio;
> > +       struct gpio_desc *pp18_gpio;
> > +
> > +       bool prepared;
> > +       bool enabled;
> > +};
> > +
> > +static inline struct panel_info *to_panel_info(struct drm_panel *panel)
> > +{
> > +       return container_of(panel, struct panel_info, base);
> > +}
> > +
> > +static void set_gpios(struct panel_info *pinfo, int enable)
> > +{
> > +       gpiod_set_value(pinfo->enable_gpio, enable);
> > +       gpiod_set_value(pinfo->pp33_gpio, enable);
> > +       gpiod_set_value(pinfo->pp18_gpio, enable);
> > +}
> > +
> > +static int send_mipi_cmds(struct drm_panel *panel, const struct
> panel_cmd *cmds)
> > +{
> > +       struct panel_info *pinfo = to_panel_info(panel);
> > +       unsigned int i = 0;
> > +       int err;
> > +
> > +       if (!cmds)
> > +               return -EFAULT;
> > +
> > +       for (i = 0; cmds[i].len != 0; i++) {
> > +               const struct panel_cmd *cmd = &cmds[i];
> > +
> > +               if (cmd->len == 2)
> > +                       err = mipi_dsi_dcs_write(pinfo->link,
> > +                                                   cmd->data[1], NULL,
> 0);
> > +               else
> > +                       err = mipi_dsi_dcs_write(pinfo->link,
> > +                                                   cmd->data[1],
> cmd->data + 2,
> > +                                                   cmd->len - 2);
> > +
> > +               if (err < 0)
> > +                       return err;
> > +
> > +               usleep_range((cmd->data[0]) * 1000,
> > +                           (1 + cmd->data[0]) * 1000);
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> > +static int boe_panel_disable(struct drm_panel *panel)
> > +{
> > +       struct panel_info *pinfo = to_panel_info(panel);
> > +
> > +       backlight_disable(pinfo->backlight);
> > +
> > +       pinfo->enabled = false;
> > +
> > +       return 0;
> > +}
> > +
> > +static int boe_panel_unprepare(struct drm_panel *panel)
> > +{
> > +       struct panel_info *pinfo = to_panel_info(panel);
> > +       int err;
> > +
> > +       if (!pinfo->prepared)
> > +               return 0;
> > +
> > +       /* send off code */
> > +       err = send_mipi_cmds(panel, pinfo->desc->off_cmds);
> > +       if (err < 0) {
> > +               DRM_DEV_ERROR(panel->dev,
> > +                               "failed to send DCS Off Code: %d\n",
> err);
> > +               goto poweroff;
> > +       }
> > +
> > +       set_gpios(pinfo, 0);
> > +
> > +       pinfo->prepared = false;
> > +
> > +       return 0;
> > +
> > +poweroff:
> > +       set_gpios(pinfo, 0);
> > +       return err;
> > +}
> > +
> > +static int boe_panel_prepare(struct drm_panel *panel)
> > +{
> > +       struct panel_info *pinfo = to_panel_info(panel);
> > +       const struct panel_desc *desc = pinfo->desc;
> > +       int err;
> > +
> > +       if (pinfo->prepared)
> > +               return 0;
> > +
> > +       gpiod_set_value(pinfo->pp18_gpio, 1);
> > +       /* T1 (> 5ms) */
> > +       usleep_range(desc->delay_t1, 1000 + desc->delay_t1);
> > +       gpiod_set_value(pinfo->pp33_gpio, 1);
> > +
> > +       /* reset sequence */
> > +       usleep_range(desc->reset_delay_t2, 1000 + desc->reset_delay_t2);
> > +
> > +       gpiod_set_value(pinfo->enable_gpio, 1);
> > +       usleep_range(desc->reset_delay_t3, 1000 + desc->reset_delay_t3);
> > +       gpiod_set_value(pinfo->enable_gpio, 0);
> > +
> > +       usleep_range(desc->reset_delay_t4, 1000 + desc->reset_delay_t4);
> > +       gpiod_set_value(pinfo->enable_gpio, 1);
> > +
> > +       usleep_range(desc->reset_delay_t5, 1000 + desc->reset_delay_t5);
> > +
> > +       /* send init code */
> > +       err = send_mipi_cmds(panel, pinfo->desc->on_cmds);
> > +       if (err < 0) {
> > +               DRM_DEV_ERROR(panel->dev,
> > +                               "failed to send DCS Init Code: %d\n",
> err);
> > +               goto poweroff;
> > +       }
> > +
> > +       pinfo->prepared = true;
> > +
> > +       return 0;
> > +
> > +poweroff:
> > +       set_gpios(pinfo, 0);
> > +       return err;
> > +}
> > +
> > +static int boe_panel_enable(struct drm_panel *panel)
> > +{
> > +       struct panel_info *pinfo = to_panel_info(panel);
> > +       int ret;
> > +
> > +       if (pinfo->enabled)
> > +               return 0;
> > +
> > +       ret = backlight_enable(pinfo->backlight);
> > +       if (ret) {
> > +               DRM_DEV_ERROR(panel->drm->dev,
> > +                               "Failed to enable backlight %d\n", ret);
> > +               return ret;
> > +       }
> > +
> > +       pinfo->enabled = true;
> > +
> > +       return 0;
> > +}
> > +
> > +static int boe_panel_get_modes(struct drm_panel *panel)
> > +{
> > +       struct panel_info *pinfo = to_panel_info(panel);
> > +       const struct drm_display_mode *m = pinfo->desc->display_mode;
> > +       struct drm_display_mode *mode;
> > +
> > +       mode = drm_mode_duplicate(panel->drm, m);
> > +       if (!mode) {
> > +               DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%u@
> %u\n",
> > +                               m->hdisplay, m->vdisplay, m->vrefresh);
> > +               return -ENOMEM;
> > +       }
> > +
> > +       drm_mode_set_name(mode);
> > +
> > +       drm_mode_probed_add(panel->connector, mode);
> > +
> > +       panel->connector->display_info.width_mm = pinfo->desc->width_mm;
> > +       panel->connector->display_info.height_mm =
> pinfo->desc->height_mm;
> > +       panel->connector->display_info.bpc = pinfo->desc->bpc;
> > +
> > +       return 1;
> > +}
> > +
> > +static const struct drm_panel_funcs panel_funcs = {
> > +       .disable = boe_panel_disable,
> > +       .unprepare = boe_panel_unprepare,
> > +       .prepare = boe_panel_prepare,
> > +       .enable = boe_panel_enable,
> > +       .get_modes = boe_panel_get_modes,
> > +};
> > +
> > +static const struct drm_display_mode default_display_mode = {
> > +       .clock = 159420,
> > +       .hdisplay = 1200,
> > +       .hsync_start = 1200 + 80,
> > +       .hsync_end = 1200 + 80 + 60,
> > +       .htotal = 1200 + 80 + 60 + 24,
> > +       .vdisplay = 1920,
> > +       .vsync_start = 1920 + 10,
> > +       .vsync_end = 1920 + 10 + 14,
> > +       .vtotal = 1920 + 10 + 14 + 4,
> > +       .vrefresh = 60,
> > +};
> > +
> > +static const struct panel_cmd default_off_cmds[] = {
> > +       _INIT_CMD(0x00, 0x28),
> > +       _INIT_CMD(0x01, 0x10),
> > +
> > +       {},
> > +};
> > +
> > +/* 8 inch */
> > +static const struct panel_cmd boe_himax8279d8p_on_cmds[] = {
> > +       _INIT_CMD(0x22, 0x10),
> > +       _INIT_CMD(0x00, 0xB0, 0x05),
> > +       _INIT_CMD(0x00, 0xB1, 0xE5),
> > +       _INIT_CMD(0x00, 0xB3, 0x52),
> > +       _INIT_CMD(0x00, 0xB0, 0x00),
> > +       _INIT_CMD(0x00, 0xB3, 0x88),
> > +       _INIT_CMD(0x00, 0xB0, 0x04),
> > +       _INIT_CMD(0x00, 0xB8, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x00),
> > +       _INIT_CMD(0x00, 0xB2, 0x50),
> > +       _INIT_CMD(0x00, 0xB6, 0x03),
> > +       _INIT_CMD(0x00, 0xBA, 0x8B),
> > +       _INIT_CMD(0x00, 0xBF, 0x15),
> > +       _INIT_CMD(0x00, 0xC0, 0x0F),
> > +       _INIT_CMD(0x00, 0xC2, 0x0C),
> > +       _INIT_CMD(0x00, 0xC3, 0x02),
> > +       _INIT_CMD(0x00, 0xC4, 0x0C),
> > +       _INIT_CMD(0x00, 0xC5, 0x02),
> > +       _INIT_CMD(0x00, 0xB0, 0x01),
> > +       _INIT_CMD(0x00, 0xE0, 0x26),
> > +       _INIT_CMD(0x00, 0xE1, 0x26),
> > +       _INIT_CMD(0x00, 0xDC, 0x00),
> > +       _INIT_CMD(0x00, 0xDD, 0x00),
> > +       _INIT_CMD(0x00, 0xCC, 0x26),
> > +       _INIT_CMD(0x00, 0xCD, 0x26),
> > +       _INIT_CMD(0x00, 0xC8, 0x00),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xD2, 0x04),
> > +       _INIT_CMD(0x00, 0xD3, 0x04),
> > +       _INIT_CMD(0x00, 0xE6, 0x03),
> > +       _INIT_CMD(0x00, 0xE7, 0x03),
> > +       _INIT_CMD(0x00, 0xC4, 0x08),
> > +       _INIT_CMD(0x00, 0xC5, 0x08),
> > +       _INIT_CMD(0x00, 0xD8, 0x07),
> > +       _INIT_CMD(0x00, 0xD9, 0x07),
> > +       _INIT_CMD(0x00, 0xC2, 0x06),
> > +       _INIT_CMD(0x00, 0xC3, 0x06),
> > +       _INIT_CMD(0x00, 0xD6, 0x05),
> > +       _INIT_CMD(0x00, 0xD7, 0x05),
> > +       _INIT_CMD(0x00, 0xC0, 0x0C),
> > +       _INIT_CMD(0x00, 0xC1, 0x0C),
> > +       _INIT_CMD(0x00, 0xD4, 0x0B),
> > +       _INIT_CMD(0x00, 0xD5, 0x0B),
> > +       _INIT_CMD(0x00, 0xCA, 0x0A),
> > +       _INIT_CMD(0x00, 0xCB, 0x0A),
> > +       _INIT_CMD(0x00, 0xDE, 0x09),
> > +       _INIT_CMD(0x00, 0xDF, 0x09),
> > +       _INIT_CMD(0x00, 0xC6, 0x26),
> > +       _INIT_CMD(0x00, 0xC7, 0x26),
> > +       _INIT_CMD(0x00, 0xCE, 0x00),
> > +       _INIT_CMD(0x00, 0xCF, 0x00),
> > +       _INIT_CMD(0x00, 0xDA, 0x26),
> > +       _INIT_CMD(0x00, 0xDB, 0x26),
> > +       _INIT_CMD(0x00, 0xE2, 0x00),
> > +       _INIT_CMD(0x00, 0xE3, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x02),
> > +       _INIT_CMD(0x00, 0xC0, 0x00),
> > +       _INIT_CMD(0x00, 0xC1, 0x07),
> > +       _INIT_CMD(0x00, 0xC2, 0x0D),
> > +       _INIT_CMD(0x00, 0xC3, 0x18),
> > +       _INIT_CMD(0x00, 0xC4, 0x27),
> > +       _INIT_CMD(0x00, 0xC5, 0x28),
> > +       _INIT_CMD(0x00, 0xC6, 0x30),
> > +       _INIT_CMD(0x00, 0xC7, 0x2E),
> > +       _INIT_CMD(0x00, 0xC8, 0x2F),
> > +       _INIT_CMD(0x00, 0xC9, 0x1A),
> > +       _INIT_CMD(0x00, 0xCA, 0x20),
> > +       _INIT_CMD(0x00, 0xCB, 0x29),
> > +       _INIT_CMD(0x00, 0xCC, 0x26),
> > +       _INIT_CMD(0x00, 0xCD, 0x32),
> > +       _INIT_CMD(0x00, 0xCE, 0x33),
> > +       _INIT_CMD(0x00, 0xCF, 0x31),
> > +       _INIT_CMD(0x00, 0xD0, 0x06),
> > +       _INIT_CMD(0x00, 0xD2, 0x00),
> > +       _INIT_CMD(0x00, 0xD3, 0x07),
> > +       _INIT_CMD(0x00, 0xD4, 0x12),
> > +       _INIT_CMD(0x00, 0xD5, 0x26),
> > +       _INIT_CMD(0x00, 0xD6, 0x3D),
> > +       _INIT_CMD(0x00, 0xD7, 0x3F),
> > +       _INIT_CMD(0x00, 0xD8, 0x3F),
> > +       _INIT_CMD(0x00, 0xD9, 0x3F),
> > +       _INIT_CMD(0x00, 0xDA, 0x3F),
> > +       _INIT_CMD(0x00, 0xDB, 0x3F),
> > +       _INIT_CMD(0x00, 0xDC, 0x3F),
> > +       _INIT_CMD(0x00, 0xDD, 0x3F),
> > +       _INIT_CMD(0x00, 0xDE, 0x3F),
> > +       _INIT_CMD(0x00, 0xDF, 0x3A),
> > +       _INIT_CMD(0x00, 0xE0, 0x37),
> > +       _INIT_CMD(0x00, 0xE1, 0x35),
> > +       _INIT_CMD(0x00, 0xE2, 0x07),
> > +       _INIT_CMD(0x00, 0xB0, 0x03),
> > +       _INIT_CMD(0x00, 0xC8, 0x0B),
> > +       _INIT_CMD(0x00, 0xC9, 0x07),
> > +       _INIT_CMD(0x00, 0xC3, 0x00),
> > +       _INIT_CMD(0x00, 0xE7, 0x00),
> > +       _INIT_CMD(0x00, 0xC5, 0x2A),
> > +       _INIT_CMD(0x00, 0xDE, 0x2A),
> > +       _INIT_CMD(0x00, 0xCA, 0x43),
> > +       _INIT_CMD(0x00, 0xC9, 0x07),
> > +       _INIT_CMD(0x00, 0xE4, 0xC0),
> > +       _INIT_CMD(0x00, 0xE5, 0x0D),
> > +       _INIT_CMD(0x00, 0xCB, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x06),
> > +       _INIT_CMD(0x00, 0xB8, 0xA5),
> > +       _INIT_CMD(0x00, 0xC0, 0xA5),
> > +       _INIT_CMD(0x00, 0xC7, 0x0F),
> > +       _INIT_CMD(0x00, 0xD5, 0x32),
> > +       _INIT_CMD(0x00, 0xB8, 0x00),
> > +       _INIT_CMD(0x00, 0xC0, 0x00),
> > +       _INIT_CMD(0x00, 0xBC, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x07),
> > +       _INIT_CMD(0x00, 0xB1, 0x00),
> > +       _INIT_CMD(0x00, 0xB2, 0x09),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x2F),
> > +       _INIT_CMD(0x00, 0xB5, 0x44),
> > +       _INIT_CMD(0x00, 0xB6, 0x52),
> > +       _INIT_CMD(0x00, 0xB7, 0x6A),
> > +       _INIT_CMD(0x00, 0xB8, 0x8A),
> > +       _INIT_CMD(0x00, 0xB9, 0xCA),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x05, 0xBB, 0x87),
> > +       _INIT_CMD(0x00, 0xBC, 0x06),
> > +       _INIT_CMD(0x00, 0xBD, 0x0A),
> > +       _INIT_CMD(0x00, 0xBE, 0x9B),
> > +       _INIT_CMD(0x00, 0xBF, 0x0C),
> > +       _INIT_CMD(0x00, 0xC0, 0x3D),
> > +       _INIT_CMD(0x00, 0xC1, 0x71),
> > +       _INIT_CMD(0x00, 0xC2, 0x90),
> > +       _INIT_CMD(0x00, 0xC3, 0xA0),
> > +       _INIT_CMD(0x00, 0xC4, 0xA8),
> > +       _INIT_CMD(0x00, 0xC5, 0xB1),
> > +       _INIT_CMD(0x00, 0xC6, 0xBB),
> > +       _INIT_CMD(0x00, 0xC7, 0xC0),
> > +       _INIT_CMD(0x00, 0xC8, 0xC4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x08),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x08),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x31),
> > +       _INIT_CMD(0x00, 0xB5, 0x46),
> > +       _INIT_CMD(0x00, 0xB6, 0x55),
> > +       _INIT_CMD(0x00, 0xB7, 0x6E),
> > +       _INIT_CMD(0x00, 0xB8, 0x92),
> > +       _INIT_CMD(0x00, 0xB9, 0xD4),
> > +       _INIT_CMD(0x00, 0xBA, 0x1B),
> > +       _INIT_CMD(0x05, 0xBB, 0x9B),
> > +       _INIT_CMD(0x00, 0xBC, 0x28),
> > +       _INIT_CMD(0x00, 0xBD, 0x2D),
> > +       _INIT_CMD(0x00, 0xBE, 0xC3),
> > +       _INIT_CMD(0x00, 0xBF, 0x2F),
> > +       _INIT_CMD(0x00, 0xC0, 0x62),
> > +       _INIT_CMD(0x00, 0xC1, 0x99),
> > +       _INIT_CMD(0x00, 0xC2, 0xAB),
> > +       _INIT_CMD(0x00, 0xC3, 0xBF),
> > +       _INIT_CMD(0x00, 0xC4, 0xCF),
> > +       _INIT_CMD(0x00, 0xC5, 0xDF),
> > +       _INIT_CMD(0x00, 0xC6, 0xF0),
> > +       _INIT_CMD(0x00, 0xC7, 0xF9),
> > +       _INIT_CMD(0x00, 0xC8, 0xFC),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x09),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x05),
> > +       _INIT_CMD(0x00, 0xB3, 0x17),
> > +       _INIT_CMD(0x00, 0xB4, 0x2E),
> > +       _INIT_CMD(0x00, 0xB5, 0x42),
> > +       _INIT_CMD(0x00, 0xB6, 0x51),
> > +       _INIT_CMD(0x00, 0xB7, 0x69),
> > +       _INIT_CMD(0x00, 0xB8, 0x88),
> > +       _INIT_CMD(0x00, 0xB9, 0xC9),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x05, 0xBB, 0x86),
> > +       _INIT_CMD(0x00, 0xBC, 0x03),
> > +       _INIT_CMD(0x00, 0xBD, 0x08),
> > +       _INIT_CMD(0x00, 0xBE, 0x95),
> > +       _INIT_CMD(0x00, 0xBF, 0x05),
> > +       _INIT_CMD(0x00, 0xC0, 0x35),
> > +       _INIT_CMD(0x00, 0xC1, 0x62),
> > +       _INIT_CMD(0x00, 0xC2, 0x81),
> > +       _INIT_CMD(0x00, 0xC3, 0x96),
> > +       _INIT_CMD(0x00, 0xC4, 0x9E),
> > +       _INIT_CMD(0x00, 0xC5, 0xA5),
> > +       _INIT_CMD(0x00, 0xC6, 0xAD),
> > +       _INIT_CMD(0x00, 0xC7, 0xB1),
> > +       _INIT_CMD(0x00, 0xC8, 0xB4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x0A),
> > +       _INIT_CMD(0x00, 0xB1, 0x00),
> > +       _INIT_CMD(0x00, 0xB2, 0x09),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x2F),
> > +       _INIT_CMD(0x00, 0xB5, 0x44),
> > +       _INIT_CMD(0x00, 0xB6, 0x52),
> > +       _INIT_CMD(0x00, 0xB7, 0x6A),
> > +       _INIT_CMD(0x00, 0xB8, 0x8A),
> > +       _INIT_CMD(0x00, 0xB9, 0xCA),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x05, 0xBB, 0x87),
> > +       _INIT_CMD(0x00, 0xBC, 0x06),
> > +       _INIT_CMD(0x00, 0xBD, 0x0A),
> > +       _INIT_CMD(0x00, 0xBE, 0x9B),
> > +       _INIT_CMD(0x00, 0xBF, 0x0C),
> > +       _INIT_CMD(0x00, 0xC0, 0x3D),
> > +       _INIT_CMD(0x00, 0xC1, 0x71),
> > +       _INIT_CMD(0x00, 0xC2, 0x90),
> > +       _INIT_CMD(0x00, 0xC3, 0xA0),
> > +       _INIT_CMD(0x00, 0xC4, 0xA8),
> > +       _INIT_CMD(0x00, 0xC5, 0xB1),
> > +       _INIT_CMD(0x00, 0xC6, 0xBB),
> > +       _INIT_CMD(0x00, 0xC7, 0xC0),
> > +       _INIT_CMD(0x00, 0xC8, 0xC4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x0B),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x08),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x31),
> > +       _INIT_CMD(0x00, 0xB5, 0x46),
> > +       _INIT_CMD(0x00, 0xB6, 0x55),
> > +       _INIT_CMD(0x00, 0xB7, 0x6E),
> > +       _INIT_CMD(0x00, 0xB8, 0x92),
> > +       _INIT_CMD(0x00, 0xB9, 0xD4),
> > +       _INIT_CMD(0x00, 0xBA, 0x1B),
> > +       _INIT_CMD(0x05, 0xBB, 0x9B),
> > +       _INIT_CMD(0x00, 0xBC, 0x28),
> > +       _INIT_CMD(0x00, 0xBD, 0x2D),
> > +       _INIT_CMD(0x00, 0xBE, 0xC3),
> > +       _INIT_CMD(0x00, 0xBF, 0x2F),
> > +       _INIT_CMD(0x00, 0xC0, 0x62),
> > +       _INIT_CMD(0x00, 0xC1, 0x99),
> > +       _INIT_CMD(0x00, 0xC2, 0xAB),
> > +       _INIT_CMD(0x00, 0xC3, 0xBF),
> > +       _INIT_CMD(0x00, 0xC4, 0xCF),
> > +       _INIT_CMD(0x00, 0xC5, 0xDF),
> > +       _INIT_CMD(0x00, 0xC6, 0xF0),
> > +       _INIT_CMD(0x00, 0xC7, 0xF9),
> > +       _INIT_CMD(0x00, 0xC8, 0xFC),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x0C),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x05),
> > +       _INIT_CMD(0x00, 0xB3, 0x17),
> > +       _INIT_CMD(0x00, 0xB4, 0x2E),
> > +       _INIT_CMD(0x00, 0xB5, 0x42),
> > +       _INIT_CMD(0x00, 0xB6, 0x51),
> > +       _INIT_CMD(0x00, 0xB7, 0x69),
> > +       _INIT_CMD(0x00, 0xB8, 0x88),
> > +       _INIT_CMD(0x00, 0xB9, 0xC9),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x05, 0xBB, 0x86),
> > +       _INIT_CMD(0x00, 0xBC, 0x03),
> > +       _INIT_CMD(0x00, 0xBD, 0x08),
> > +       _INIT_CMD(0x00, 0xBE, 0x95),
> > +       _INIT_CMD(0x00, 0xBF, 0x05),
> > +       _INIT_CMD(0x00, 0xC0, 0x35),
> > +       _INIT_CMD(0x00, 0xC1, 0x62),
> > +       _INIT_CMD(0x00, 0xC2, 0x81),
> > +       _INIT_CMD(0x00, 0xC3, 0x96),
> > +       _INIT_CMD(0x00, 0xC4, 0x9E),
> > +       _INIT_CMD(0x00, 0xC5, 0xA5),
> > +       _INIT_CMD(0x00, 0xC6, 0xAD),
> > +       _INIT_CMD(0x00, 0xC7, 0xB1),
> > +       _INIT_CMD(0x00, 0xC8, 0xB4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x64, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x00),
> > +       _INIT_CMD(0x00, 0xB3, 0x08),
> > +       _INIT_CMD(0x00, 0xB0, 0x04),
> > +       _INIT_CMD(0x0A, 0xB8, 0x68),
> > +       _INIT_CMD(0x78, 0x11),
> > +       _INIT_CMD(0x14, 0x29),
> > +
> > +       {},
> > +};
> > +
> > +static const struct panel_desc boe_himax8279d8p_panel_desc = {
> > +       .display_mode = &default_display_mode,
> > +       .bpc = 8,
> > +       .width_mm = 107,
> > +       .height_mm = 172,
> > +       .delay_t1 = 5000,
> > +       .reset_delay_t2 = 14000,
> > +       .reset_delay_t3 = 1000,
> > +       .reset_delay_t4 = 1000,
> > +       .reset_delay_t5 = 5000,
> > +       .mode_flags = MIPI_DSI_MODE_VIDEO |
> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > +                       MIPI_DSI_CLOCK_NON_CONTINUOUS |
> MIPI_DSI_MODE_LPM,
> > +       .format = MIPI_DSI_FMT_RGB888,
> > +       .lanes = 4,
> > +       .on_cmds = boe_himax8279d8p_on_cmds,
> > +       .off_cmds = default_off_cmds,
> > +};
> > +
> > +/* 10 inch */
> > +static const struct panel_cmd boe_himax8279d10p_on_cmds[] = {
> > +       _INIT_CMD(0x00, 0xB0, 0x05),
> > +       _INIT_CMD(0x00, 0xB1, 0xE5),
> > +       _INIT_CMD(0x00, 0xB3, 0x52),
> > +       _INIT_CMD(0x00, 0xB0, 0x00),
> > +       _INIT_CMD(0x00, 0xB3, 0x88),
> > +       _INIT_CMD(0x00, 0xB0, 0x04),
> > +       _INIT_CMD(0x00, 0xB8, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x00),
> > +       _INIT_CMD(0x00, 0xB2, 0x50),
> > +       _INIT_CMD(0x00, 0xB6, 0x03),
> > +       _INIT_CMD(0x00, 0xBA, 0x8B),
> > +       _INIT_CMD(0x00, 0xBF, 0x1A),
> > +       _INIT_CMD(0x00, 0xC0, 0x0F),
> > +       _INIT_CMD(0x00, 0xC2, 0x0C),
> > +       _INIT_CMD(0x00, 0xC3, 0x02),
> > +       _INIT_CMD(0x00, 0xC4, 0x0C),
> > +       _INIT_CMD(0x00, 0xC5, 0x02),
> > +       _INIT_CMD(0x00, 0xB0, 0x01),
> > +       _INIT_CMD(0x00, 0xE0, 0x26),
> > +       _INIT_CMD(0x00, 0xE1, 0x26),
> > +       _INIT_CMD(0x00, 0xDC, 0x00),
> > +       _INIT_CMD(0x00, 0xDD, 0x00),
> > +       _INIT_CMD(0x00, 0xCC, 0x26),
> > +       _INIT_CMD(0x00, 0xCD, 0x26),
> > +       _INIT_CMD(0x00, 0xC8, 0x00),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xD2, 0x04),
> > +       _INIT_CMD(0x00, 0xD3, 0x04),
> > +       _INIT_CMD(0x00, 0xE6, 0x03),
> > +       _INIT_CMD(0x00, 0xE7, 0x03),
> > +       _INIT_CMD(0x00, 0xC4, 0x08),
> > +       _INIT_CMD(0x00, 0xC5, 0x08),
> > +       _INIT_CMD(0x00, 0xD8, 0x07),
> > +       _INIT_CMD(0x00, 0xD9, 0x07),
> > +       _INIT_CMD(0x00, 0xC2, 0x06),
> > +       _INIT_CMD(0x00, 0xC3, 0x06),
> > +       _INIT_CMD(0x00, 0xD6, 0x05),
> > +       _INIT_CMD(0x00, 0xD7, 0x05),
> > +       _INIT_CMD(0x00, 0xC0, 0x0C),
> > +       _INIT_CMD(0x00, 0xC1, 0x0C),
> > +       _INIT_CMD(0x00, 0xD4, 0x0B),
> > +       _INIT_CMD(0x00, 0xD5, 0x0B),
> > +       _INIT_CMD(0x00, 0xCA, 0x0A),
> > +       _INIT_CMD(0x00, 0xCB, 0x0A),
> > +       _INIT_CMD(0x00, 0xDE, 0x09),
> > +       _INIT_CMD(0x00, 0xDF, 0x09),
> > +       _INIT_CMD(0x00, 0xC6, 0x26),
> > +       _INIT_CMD(0x00, 0xC7, 0x26),
> > +       _INIT_CMD(0x00, 0xCE, 0x00),
> > +       _INIT_CMD(0x00, 0xCF, 0x00),
> > +       _INIT_CMD(0x00, 0xDA, 0x26),
> > +       _INIT_CMD(0x00, 0xDB, 0x26),
> > +       _INIT_CMD(0x00, 0xE2, 0x00),
> > +       _INIT_CMD(0x00, 0xE3, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x02),
> > +       _INIT_CMD(0x00, 0xC0, 0x00),
> > +       _INIT_CMD(0x00, 0xC1, 0x07),
> > +       _INIT_CMD(0x00, 0xC2, 0x0D),
> > +       _INIT_CMD(0x00, 0xC3, 0x18),
> > +       _INIT_CMD(0x00, 0xC4, 0x27),
> > +       _INIT_CMD(0x00, 0xC5, 0x28),
> > +       _INIT_CMD(0x00, 0xC6, 0x30),
> > +       _INIT_CMD(0x00, 0xC7, 0x2E),
> > +       _INIT_CMD(0x00, 0xC8, 0x2F),
> > +       _INIT_CMD(0x00, 0xC9, 0x1A),
> > +       _INIT_CMD(0x00, 0xCA, 0x20),
> > +       _INIT_CMD(0x00, 0xCB, 0x29),
> > +       _INIT_CMD(0x00, 0xCC, 0x26),
> > +       _INIT_CMD(0x00, 0xCD, 0x32),
> > +       _INIT_CMD(0x00, 0xCE, 0x33),
> > +       _INIT_CMD(0x00, 0xCF, 0x31),
> > +       _INIT_CMD(0x00, 0xD0, 0x06),
> > +       _INIT_CMD(0x00, 0xD2, 0x00),
> > +       _INIT_CMD(0x00, 0xD3, 0x07),
> > +       _INIT_CMD(0x00, 0xD4, 0x12),
> > +       _INIT_CMD(0x00, 0xD5, 0x26),
> > +       _INIT_CMD(0x00, 0xD6, 0x3D),
> > +       _INIT_CMD(0x00, 0xD7, 0x3F),
> > +       _INIT_CMD(0x00, 0xD8, 0x3F),
> > +       _INIT_CMD(0x00, 0xD9, 0x3F),
> > +       _INIT_CMD(0x00, 0xDA, 0x3F),
> > +       _INIT_CMD(0x00, 0xDB, 0x3F),
> > +       _INIT_CMD(0x00, 0xDC, 0x3F),
> > +       _INIT_CMD(0x00, 0xDD, 0x3F),
> > +       _INIT_CMD(0x00, 0xDE, 0x3F),
> > +       _INIT_CMD(0x00, 0xDF, 0x3A),
> > +       _INIT_CMD(0x00, 0xE0, 0x37),
> > +       _INIT_CMD(0x00, 0xE1, 0x35),
> > +       _INIT_CMD(0x00, 0xE2, 0x07),
> > +       _INIT_CMD(0x00, 0xB0, 0x03),
> > +       _INIT_CMD(0x00, 0xC8, 0x0B),
> > +       _INIT_CMD(0x00, 0xC9, 0x07),
> > +       _INIT_CMD(0x00, 0xC3, 0x00),
> > +       _INIT_CMD(0x00, 0xE7, 0x00),
> > +       _INIT_CMD(0x00, 0xC5, 0x2A),
> > +       _INIT_CMD(0x00, 0xDE, 0x2A),
> > +       _INIT_CMD(0x00, 0xCA, 0x43),
> > +       _INIT_CMD(0x00, 0xC9, 0x07),
> > +       _INIT_CMD(0x00, 0xE4, 0xC0),
> > +       _INIT_CMD(0x00, 0xE5, 0x0D),
> > +       _INIT_CMD(0x00, 0xCB, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x06),
> > +       _INIT_CMD(0x00, 0xB8, 0xA5),
> > +       _INIT_CMD(0x00, 0xC0, 0xA5),
> > +       _INIT_CMD(0x00, 0xC7, 0x0F),
> > +       _INIT_CMD(0x00, 0xD5, 0x32),
> > +       _INIT_CMD(0x00, 0xB8, 0x00),
> > +       _INIT_CMD(0x00, 0xC0, 0x00),
> > +       _INIT_CMD(0x00, 0xBC, 0x00),
> > +       _INIT_CMD(0x00, 0xB0, 0x07),
> > +       _INIT_CMD(0x00, 0xB1, 0x00),
> > +       _INIT_CMD(0x00, 0xB2, 0x09),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x2F),
> > +       _INIT_CMD(0x00, 0xB5, 0x44),
> > +       _INIT_CMD(0x00, 0xB6, 0x52),
> > +       _INIT_CMD(0x00, 0xB7, 0x6A),
> > +       _INIT_CMD(0x00, 0xB8, 0x8A),
> > +       _INIT_CMD(0x00, 0xB9, 0xCA),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x00, 0xBB, 0x87),
> > +       _INIT_CMD(0x00, 0xBC, 0x06),
> > +       _INIT_CMD(0x00, 0xBD, 0x0A),
> > +       _INIT_CMD(0x00, 0xBE, 0x9B),
> > +       _INIT_CMD(0x00, 0xBF, 0x0C),
> > +       _INIT_CMD(0x00, 0xC0, 0x3D),
> > +       _INIT_CMD(0x00, 0xC1, 0x71),
> > +       _INIT_CMD(0x00, 0xC2, 0x90),
> > +       _INIT_CMD(0x00, 0xC3, 0xA0),
> > +       _INIT_CMD(0x00, 0xC4, 0xA8),
> > +       _INIT_CMD(0x00, 0xC5, 0xB1),
> > +       _INIT_CMD(0x00, 0xC6, 0xBB),
> > +       _INIT_CMD(0x00, 0xC7, 0xC0),
> > +       _INIT_CMD(0x00, 0xC8, 0xC4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x08),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x08),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x31),
> > +       _INIT_CMD(0x00, 0xB5, 0x46),
> > +       _INIT_CMD(0x00, 0xB6, 0x55),
> > +       _INIT_CMD(0x00, 0xB7, 0x6E),
> > +       _INIT_CMD(0x00, 0xB8, 0x92),
> > +       _INIT_CMD(0x00, 0xB9, 0xD4),
> > +       _INIT_CMD(0x00, 0xBA, 0x1B),
> > +       _INIT_CMD(0x00, 0xBB, 0x9B),
> > +       _INIT_CMD(0x00, 0xBC, 0x28),
> > +       _INIT_CMD(0x00, 0xBD, 0x2D),
> > +       _INIT_CMD(0x00, 0xBE, 0xC3),
> > +       _INIT_CMD(0x00, 0xBF, 0x2F),
> > +       _INIT_CMD(0x00, 0xC0, 0x62),
> > +       _INIT_CMD(0x00, 0xC1, 0x99),
> > +       _INIT_CMD(0x00, 0xC2, 0xAB),
> > +       _INIT_CMD(0x00, 0xC3, 0xBF),
> > +       _INIT_CMD(0x00, 0xC4, 0xCF),
> > +       _INIT_CMD(0x00, 0xC5, 0xDF),
> > +       _INIT_CMD(0x00, 0xC6, 0xF0),
> > +       _INIT_CMD(0x00, 0xC7, 0xF9),
> > +       _INIT_CMD(0x00, 0xC8, 0xFC),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x09),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x05),
> > +       _INIT_CMD(0x00, 0xB3, 0x17),
> > +       _INIT_CMD(0x00, 0xB4, 0x2E),
> > +       _INIT_CMD(0x00, 0xB5, 0x42),
> > +       _INIT_CMD(0x00, 0xB6, 0x51),
> > +       _INIT_CMD(0x00, 0xB7, 0x69),
> > +       _INIT_CMD(0x00, 0xB8, 0x88),
> > +       _INIT_CMD(0x00, 0xB9, 0xC9),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x00, 0xBB, 0x86),
> > +       _INIT_CMD(0x00, 0xBC, 0x03),
> > +       _INIT_CMD(0x00, 0xBD, 0x08),
> > +       _INIT_CMD(0x00, 0xBE, 0x95),
> > +       _INIT_CMD(0x00, 0xBF, 0x05),
> > +       _INIT_CMD(0x00, 0xC0, 0x35),
> > +       _INIT_CMD(0x00, 0xC1, 0x62),
> > +       _INIT_CMD(0x00, 0xC2, 0x81),
> > +       _INIT_CMD(0x00, 0xC3, 0x96),
> > +       _INIT_CMD(0x00, 0xC4, 0x9E),
> > +       _INIT_CMD(0x00, 0xC5, 0xA5),
> > +       _INIT_CMD(0x00, 0xC6, 0xAD),
> > +       _INIT_CMD(0x00, 0xC7, 0xB1),
> > +       _INIT_CMD(0x00, 0xC8, 0xB4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x0A),
> > +       _INIT_CMD(0x00, 0xB1, 0x00),
> > +       _INIT_CMD(0x00, 0xB2, 0x09),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x2F),
> > +       _INIT_CMD(0x00, 0xB5, 0x44),
> > +       _INIT_CMD(0x00, 0xB6, 0x52),
> > +       _INIT_CMD(0x00, 0xB7, 0x6A),
> > +       _INIT_CMD(0x00, 0xB8, 0x8A),
> > +       _INIT_CMD(0x00, 0xB9, 0xCA),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x00, 0xBB, 0x87),
> > +       _INIT_CMD(0x00, 0xBC, 0x06),
> > +       _INIT_CMD(0x00, 0xBD, 0x0A),
> > +       _INIT_CMD(0x00, 0xBE, 0x9B),
> > +       _INIT_CMD(0x00, 0xBF, 0x0C),
> > +       _INIT_CMD(0x00, 0xC0, 0x3D),
> > +       _INIT_CMD(0x00, 0xC1, 0x71),
> > +       _INIT_CMD(0x00, 0xC2, 0x90),
> > +       _INIT_CMD(0x00, 0xC3, 0xA0),
> > +       _INIT_CMD(0x00, 0xC4, 0xA8),
> > +       _INIT_CMD(0x00, 0xC5, 0xB1),
> > +       _INIT_CMD(0x00, 0xC6, 0xBB),
> > +       _INIT_CMD(0x00, 0xC7, 0xC0),
> > +       _INIT_CMD(0x00, 0xC8, 0xC4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x0B),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x08),
> > +       _INIT_CMD(0x00, 0xB3, 0x19),
> > +       _INIT_CMD(0x00, 0xB4, 0x31),
> > +       _INIT_CMD(0x00, 0xB5, 0x46),
> > +       _INIT_CMD(0x00, 0xB6, 0x55),
> > +       _INIT_CMD(0x00, 0xB7, 0x6E),
> > +       _INIT_CMD(0x00, 0xB8, 0x92),
> > +       _INIT_CMD(0x00, 0xB9, 0xD4),
> > +       _INIT_CMD(0x00, 0xBA, 0x1B),
> > +       _INIT_CMD(0x00, 0xBB, 0x9B),
> > +       _INIT_CMD(0x00, 0xBC, 0x28),
> > +       _INIT_CMD(0x00, 0xBD, 0x2D),
> > +       _INIT_CMD(0x00, 0xBE, 0xC3),
> > +       _INIT_CMD(0x00, 0xBF, 0x2F),
> > +       _INIT_CMD(0x00, 0xC0, 0x62),
> > +       _INIT_CMD(0x00, 0xC1, 0x99),
> > +       _INIT_CMD(0x00, 0xC2, 0xAB),
> > +       _INIT_CMD(0x00, 0xC3, 0xBF),
> > +       _INIT_CMD(0x00, 0xC4, 0xCF),
> > +       _INIT_CMD(0x00, 0xC5, 0xDF),
> > +       _INIT_CMD(0x00, 0xC6, 0xF0),
> > +       _INIT_CMD(0x00, 0xC7, 0xF9),
> > +       _INIT_CMD(0x00, 0xC8, 0xFC),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x0C),
> > +       _INIT_CMD(0x00, 0xB1, 0x04),
> > +       _INIT_CMD(0x00, 0xB2, 0x05),
> > +       _INIT_CMD(0x00, 0xB3, 0x17),
> > +       _INIT_CMD(0x00, 0xB4, 0x2E),
> > +       _INIT_CMD(0x00, 0xB5, 0x42),
> > +       _INIT_CMD(0x00, 0xB6, 0x51),
> > +       _INIT_CMD(0x00, 0xB7, 0x69),
> > +       _INIT_CMD(0x00, 0xB8, 0x88),
> > +       _INIT_CMD(0x00, 0xB9, 0xC9),
> > +       _INIT_CMD(0x00, 0xBA, 0x0C),
> > +       _INIT_CMD(0x00, 0xBB, 0x86),
> > +       _INIT_CMD(0x00, 0xBC, 0x03),
> > +       _INIT_CMD(0x00, 0xBD, 0x08),
> > +       _INIT_CMD(0x00, 0xBE, 0x95),
> > +       _INIT_CMD(0x00, 0xBF, 0x05),
> > +       _INIT_CMD(0x00, 0xC0, 0x35),
> > +       _INIT_CMD(0x00, 0xC1, 0x62),
> > +       _INIT_CMD(0x00, 0xC2, 0x81),
> > +       _INIT_CMD(0x00, 0xC3, 0x96),
> > +       _INIT_CMD(0x00, 0xC4, 0x9E),
> > +       _INIT_CMD(0x00, 0xC5, 0xA5),
> > +       _INIT_CMD(0x00, 0xC6, 0xAD),
> > +       _INIT_CMD(0x00, 0xC7, 0xB1),
> > +       _INIT_CMD(0x00, 0xC8, 0xB4),
> > +       _INIT_CMD(0x00, 0xC9, 0x00),
> > +       _INIT_CMD(0x00, 0xCA, 0x00),
> > +       _INIT_CMD(0x00, 0xCB, 0x16),
> > +       _INIT_CMD(0x00, 0xCC, 0xAF),
> > +       _INIT_CMD(0x00, 0xCD, 0xFF),
> > +       _INIT_CMD(0x00, 0xCE, 0xFF),
> > +       _INIT_CMD(0x00, 0xB0, 0x00),
> > +       _INIT_CMD(0x00, 0xB3, 0x08),
> > +       _INIT_CMD(0x00, 0xB0, 0x04),
> > +       _INIT_CMD(0x64, 0xB8, 0x68),
> > +
> > +       {},
> > +};
> > +
> > +static const struct panel_desc boe_himax8279d10p_panel_desc = {
> > +       .display_mode = &default_display_mode,
> > +       .bpc = 8,
> > +       .width_mm = 135,
> > +       .height_mm = 216,
> > +       .delay_t1 = 5000,
> > +       .reset_delay_t2 = 14000,
> > +       .reset_delay_t3 = 1000,
> > +       .reset_delay_t4 = 1000,
> > +       .reset_delay_t5 = 5000,
> > +       .mode_flags = MIPI_DSI_MODE_VIDEO |
> MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > +                       MIPI_DSI_CLOCK_NON_CONTINUOUS |
> MIPI_DSI_MODE_LPM,
> > +       .format = MIPI_DSI_FMT_RGB888,
> > +       .lanes = 4,
> > +       .on_cmds = boe_himax8279d10p_on_cmds,
> > +       .off_cmds = default_off_cmds,
> > +};
> > +
> > +static const struct of_device_id panel_of_match[] = {
> > +       { .compatible = "boe,himax8279d8p",
> > +         .data = &boe_himax8279d8p_panel_desc
> > +       }, { .compatible = "boe,himax8279d10p",
> > +         .data = &boe_himax8279d10p_panel_desc
> > +       }, {
> > +               /* sentinel */
> > +       }
> > +};
> > +MODULE_DEVICE_TABLE(of, panel_of_match);
> > +
> > +static int panel_add(struct panel_info *pinfo)
> > +{
> > +       struct device *dev = &pinfo->link->dev;
> > +       int ret;
> > +
> > +       pinfo->pp18_gpio = devm_gpiod_get_optional(dev, "pp18",
> GPIOD_OUT_HIGH);
> > +       if (IS_ERR(pinfo->pp18_gpio)) {
> > +               ret = PTR_ERR(pinfo->pp18_gpio);
> > +               if (ret != -EPROBE_DEFER)
> > +                       DRM_DEV_ERROR(dev, "failed to get pp18 gpio:
> %d\n",
> > +                                       ret);
> > +               return ret;
> > +       }
> > +
> > +       pinfo->pp33_gpio = devm_gpiod_get_optional(dev, "pp33",
> GPIOD_OUT_HIGH);
> > +       if (IS_ERR(pinfo->pp33_gpio)) {
> > +               ret = PTR_ERR(pinfo->pp33_gpio);
> > +               if (ret != -EPROBE_DEFER)
> > +                       DRM_DEV_ERROR(dev, "failed to get pp33 gpio:
> %d\n",
> > +                                       ret);
> > +               return ret;
> > +       }
> > +
> > +       pinfo->enable_gpio = devm_gpiod_get_optional(dev, "enable",
> > +                                                       GPIOD_OUT_HIGH);
> > +       if (IS_ERR(pinfo->enable_gpio)) {
> > +               ret = PTR_ERR(pinfo->enable_gpio);
> > +               if (ret != -EPROBE_DEFER)
> > +                       DRM_DEV_ERROR(dev, "failed to get enable gpio:
> %d\n",
> > +                                       ret);
> > +               return ret;
> > +       }
> > +
> > +       pinfo->backlight = devm_of_find_backlight(dev);
> > +       if (IS_ERR(pinfo->backlight))
> > +               return PTR_ERR(pinfo->backlight);
> > +
> > +       drm_panel_init(&pinfo->base);
> > +       pinfo->base.funcs = &panel_funcs;
> > +       pinfo->base.dev = &pinfo->link->dev;
> > +
> > +       ret = drm_panel_add(&pinfo->base);
> > +       if (ret < 0)
> > +               return ret;
> > +
> > +       return 0;
> > +}
> > +
> > +static void panel_del(struct panel_info *pinfo)
> > +{
> > +       if (pinfo->base.dev)
> > +               drm_panel_remove(&pinfo->base);
> > +}
> > +
> > +static int panel_probe(struct mipi_dsi_device *dsi)
> > +{
> > +       struct panel_info *pinfo;
> > +       const struct panel_desc *desc;
> > +       int err;
> > +
> > +       pinfo = devm_kzalloc(&dsi->dev, sizeof(*pinfo), GFP_KERNEL);
> > +       if (!pinfo)
> > +               return -ENOMEM;
> > +
> > +       desc = of_device_get_match_data(&dsi->dev);
> > +       dsi->mode_flags = desc->mode_flags;
> > +       dsi->format = desc->format;
> > +       dsi->lanes = desc->lanes;
> > +       pinfo->desc = desc;
> > +
> > +       pinfo->link = dsi;
> > +       mipi_dsi_set_drvdata(dsi, pinfo);
> > +
> > +       err = panel_add(pinfo);
> > +       if (err < 0)
> > +               return err;
> > +
> > +       return mipi_dsi_attach(dsi);
> > +}
> > +
> > +static int panel_remove(struct mipi_dsi_device *dsi)
> > +{
> > +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
> > +       int err;
> > +
> > +       err = boe_panel_unprepare(&pinfo->base);
> > +       if (err < 0)
> > +               DRM_DEV_ERROR(&dsi->dev, "failed to unprepare panel:
> %d\n",
> > +                               err);
> > +
> > +       err = boe_panel_disable(&pinfo->base);
> > +       if (err < 0)
> > +               DRM_DEV_ERROR(&dsi->dev, "failed to disable panel:
> %d\n", err);
> > +
> > +       err = mipi_dsi_detach(dsi);
> > +       if (err < 0)
> > +               DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI
> host: %d\n",
> > +                               err);
> > +
> > +       drm_panel_detach(&pinfo->base);
> > +       panel_del(pinfo);
> > +
> > +       return 0;
> > +}
> > +
> > +static void panel_shutdown(struct mipi_dsi_device *dsi)
> > +{
> > +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
> > +
> > +       boe_panel_disable(&pinfo->base);
> > +       boe_panel_unprepare(&pinfo->base);
> > +}
> > +
> > +static struct mipi_dsi_driver panel_driver = {
> > +       .driver = {
> > +               .name = "panel-boe-himax8279d",
> > +               .of_match_table = panel_of_match,
> > +       },
> > +       .probe = panel_probe,
> > +       .remove = panel_remove,
> > +       .shutdown = panel_shutdown,
> > +};
> > +module_mipi_dsi_driver(panel_driver);
> > +
> > +MODULE_AUTHOR("Jerry Han <hanxu5@huaqin.corp-partner.google.com>");
> > +MODULE_DESCRIPTION("Boe Himax8279d driver");
> > +MODULE_LICENSE("GPL v2");
> > --
> > 2.17.1
> >
>
<div dir="ltr"><div dir="ltr">Dear ALL:<div><br><div><p class="gmail-tgt" style="box-sizing:border-box;margin:0px;padding:0px;min-height:26px;line-height:25.9875px;color:rgb(51,51,51);font-family:Arial,&quot;Microsoft YaHei&quot;,&quot;\005fae\008f6f\0096c5\009ed1&quot;,&quot;\005b8b\004f53&quot;,&quot;Malgun Gothic&quot;,Meiryo,sans-serif;font-variant-numeric:normal;font-variant-east-asian:normal;text-align:justify;background-color:rgb(247,248,250)"><span class="gmail-tgt" style="box-sizing:border-box;min-height:26px;line-height:26px">Are there any questions about this submission?</span></p><ol><li> 

<span class="gmail-tgt" style="box-sizing:border-box;min-height:26px;line-height:25.9875px;font-size:13.6px;font-variant-numeric:normal;font-variant-east-asian:normal">If there are questions? </span><span class="gmail-tgt" style="box-sizing:border-box;min-height:26px;line-height:25.9875px;font-size:13.6px;font-variant-numeric:normal;font-variant-east-asian:normal">What changes do I need to make</span></li><li><span class="gmail-tgt" style="box-sizing:border-box;min-height:26px;line-height:25.9875px;font-size:13.6px;font-variant-numeric:normal;font-variant-east-asian:normal"><span class="gmail-tgt" style="box-sizing:border-box;min-height:26px;line-height:25.9875px;font-size:13.6px;font-variant-numeric:normal;font-variant-east-asian:normal">  If it&#39;s okay.  </span><span class="gmail-tgt" style="box-sizing:border-box;min-height:26px;line-height:25.9875px;font-size:13.6px;font-variant-numeric:normal;font-variant-east-asian:normal">When the code will show up in drm-musc (git://<a href="http://anongit.freedesktop.org/drm/drm-misc">anongit.freedesktop.org/drm/drm-misc</a>).</span></span></li></ol><div><span style="font-size:13.6px">Can you give me some advice?</span></div><div><br></div><div><span style="font-size:13.6px">thanks</span></div><p></p></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">dbasehore . &lt;<a href="mailto:dbasehore@chromium.org">dbasehore@chromium.org</a>&gt; 于2019年3月27日周三 上午11:12写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Mar 26, 2019 at 12:09 AM Jerry Han &lt;<a href="mailto:jerry.han.hq@gmail.com" target="_blank">jerry.han.hq@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Support Boe Himax8279d 8.0&quot; 1200x1920 TFT LCD panel, it is a MIPI DSI<br>
&gt; panel.<br>
&gt;<br>
&gt; V7:<br>
&gt; - Add the information of the reviewer<br>
&gt; - Remove unnecessary delays, The udelay_range code gracefully returns<br>
&gt;     without hitting the scheduler on a delay of 0. (Derek)<br>
&gt; - Merge the same data structures, like display_mode and off_cmds (Derek)<br>
&gt; - Optimize the processing of results returned by<br>
&gt;     devm_gpiod_get_optional (Derek)<br>
<br>
Looks good to me overall. There&#39;s still some duplication on values<br>
like number of lanes, but that&#39;s not a blocking concern for me.<br>
<br>
&gt;<br>
&gt; V6:<br>
&gt; - Add the information of the reviewer (Sam)<br>
&gt; - Delete unnecessary header files #include &lt;linux/fb.h&gt; (Sam)<br>
&gt; - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)<br>
&gt; - ADD static, set_gpios function is not used outside this module (Sam)<br>
&gt;<br>
&gt; V5:<br>
&gt; - Added changelog<br>
&gt;<br>
&gt; V4:<br>
&gt; - Frefix all function maes with boe_ (Sam)<br>
&gt; - Fsed &quot;enable_gpio&quot; replace &quot;reset_gpio&quot;, Make it look clearer (Sam)<br>
&gt; - Sort include lines alphabetically (Sam)<br>
&gt; - Fixed entries in the makefile must be sorted alphabetically (Sam)<br>
&gt; - Add send_mipi_cmds function to avoid duplicating the code (Sam)<br>
&gt; - Add the necessary delay(reset_delay_t5) between reset and sending<br>
&gt;     the initialization command (Rock wang)<br>
&gt;<br>
&gt; V3:<br>
&gt; - Remove unnecessary delays in sending initialization commands (Jitao Shi)<br>
&gt;<br>
&gt; V2:<br>
&gt; - Use SPDX identifier (Sam)<br>
&gt; - Use necessary header files replace drmP.h (Sam)<br>
&gt; - Delete unnecessary header files #include &lt;linux/err.h&gt; (Sam)<br>
&gt; - Specifies a GPIOs array to control the reset timing,<br>
&gt;     instead of reading &quot;dsi-reset-sequence&quot; data from DTS (Sam)<br>
&gt; - Delete backlight_disable() function when already disabled (Sam)<br>
&gt; - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)<br>
&gt; - Move the necessary data in the DTS to the current file,<br>
&gt;     like porch, display_mode and Init code etc. (Sam)<br>
&gt; - Add compatible device &quot;boe,himax8279d10p&quot; (Sam)<br>
&gt;<br>
&gt; Signed-off-by: Jerry Han &lt;<a href="mailto:hanxu5@huaqin.corp-partner.google.com" target="_blank">hanxu5@huaqin.corp-partner.google.com</a>&gt;<br>
&gt; Reviewed-by: Sam Ravnborg &lt;<a href="mailto:sam@ravnborg.org" target="_blank">sam@ravnborg.org</a>&gt;<br>
&gt; Reviewed-by: Derek Basehore &lt;<a href="mailto:dbasehore@chromium.org" target="_blank">dbasehore@chromium.org</a>&gt;<br>
&gt; Cc: Jitao Shi &lt;<a href="mailto:jitao.shi@mediatek.com" target="_blank">jitao.shi@mediatek.com</a>&gt;<br>
&gt; Cc: Rock wang &lt;<a href="mailto:rock_wang@himax.com.cn" target="_blank">rock_wang@himax.com.cn</a>&gt;<br>
&gt; ---<br>
&gt;  MAINTAINERS                                  |    6 +<br>
&gt;  drivers/gpu/drm/panel/Kconfig                |   11 +<br>
&gt;  drivers/gpu/drm/panel/Makefile               |    1 +<br>
&gt;  drivers/gpu/drm/panel/panel-boe-himax8279d.c | 1050 ++++++++++++++++++<br>
&gt;  4 files changed, 1068 insertions(+)<br>
&gt;  create mode 100644 drivers/gpu/drm/panel/panel-boe-himax8279d.c<br>
&gt;<br>
&gt; diff --git a/MAINTAINERS b/MAINTAINERS<br>
&gt; index f8e63bcc4c1c..267468ca72bb 100644<br>
&gt; --- a/MAINTAINERS<br>
&gt; +++ b/MAINTAINERS<br>
&gt; @@ -4816,6 +4816,12 @@ T:       git git://<a href="http://anongit.freedesktop.org/drm/drm-misc" rel="noreferrer" target="_blank">anongit.freedesktop.org/drm/drm-misc</a><br>
&gt;  S:     Maintained<br>
&gt;  F:     drivers/gpu/drm/bochs/<br>
&gt;<br>
&gt; +DRM DRIVER FOR BOE HIMAX8279D PANELS<br>
&gt; +M:     Jerry Han &lt;<a href="mailto:hanxu5@huaqin.corp-partner.google.com" target="_blank">hanxu5@huaqin.corp-partner.google.com</a>&gt;<br>
&gt; +S:     Maintained<br>
&gt; +F:     drivers/gpu/drm/panel/panel-boe-himax8279d.c<br>
&gt; +F:     Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt<br>
&gt; +<br>
&gt;  DRM DRIVER FOR FARADAY TVE200 TV ENCODER<br>
&gt;  M:     Linus Walleij &lt;<a href="mailto:linus.walleij@linaro.org" target="_blank">linus.walleij@linaro.org</a>&gt;<br>
&gt;  T:     git git://<a href="http://anongit.freedesktop.org/drm/drm-misc" rel="noreferrer" target="_blank">anongit.freedesktop.org/drm/drm-misc</a><br>
&gt; diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig<br>
&gt; index f53f817356db..fe2f87cc6627 100644<br>
&gt; --- a/drivers/gpu/drm/panel/Kconfig<br>
&gt; +++ b/drivers/gpu/drm/panel/Kconfig<br>
&gt; @@ -17,6 +17,17 @@ config DRM_PANEL_ARM_VERSATILE<br>
&gt;           reference designs. The panel is detected using special registers<br>
&gt;           in the Versatile family syscon registers.<br>
&gt;<br>
&gt; +config DRM_PANEL_BOE_HIMAX8279D<br>
&gt; +       tristate &quot;Boe Himax8279d panel&quot;<br>
&gt; +       depends on OF<br>
&gt; +       depends on DRM_MIPI_DSI<br>
&gt; +       depends on BACKLIGHT_CLASS_DEVICE<br>
&gt; +       help<br>
&gt; +         Say Y here if you want to enable support for Boe Himax8279d<br>
&gt; +         TFT-LCD modules. The panel has a 1200x1920 resolution and uses<br>
&gt; +         24 bit RGB per pixel. It provides a MIPI DSI interface to<br>
&gt; +         the host and has a built-in LED backlight.<br>
&gt; +<br>
&gt;  config DRM_PANEL_LVDS<br>
&gt;         tristate &quot;Generic LVDS panel driver&quot;<br>
&gt;         depends on OF<br>
&gt; diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile<br>
&gt; index 7834947a53b0..c4814b6f069e 100644<br>
&gt; --- a/drivers/gpu/drm/panel/Makefile<br>
&gt; +++ b/drivers/gpu/drm/panel/Makefile<br>
&gt; @@ -1,5 +1,6 @@<br>
&gt;  # SPDX-License-Identifier: GPL-2.0<br>
&gt;  obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o<br>
&gt; +obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o<br>
&gt;  obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o<br>
&gt;  obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o<br>
&gt;  obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o<br>
&gt; diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c<br>
&gt; new file mode 100644<br>
&gt; index 000000000000..ff5a89e38fd7<br>
&gt; --- /dev/null<br>
&gt; +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c<br>
&gt; @@ -0,0 +1,1050 @@<br>
&gt; +// SPDX-License-Identifier: GPL-2.0<br>
&gt; +/*<br>
&gt; + * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd<br>
&gt; + *<br>
&gt; + * Author: Jerry Han &lt;<a href="mailto:hanxu5@huaqin.corp-partner.google.com" target="_blank">hanxu5@huaqin.corp-partner.google.com</a>&gt;<br>
&gt; + *<br>
&gt; + */<br>
&gt; +<br>
&gt; +#include &lt;linux/backlight.h&gt;<br>
&gt; +#include &lt;linux/delay.h&gt;<br>
&gt; +#include &lt;linux/kernel.h&gt;<br>
&gt; +#include &lt;linux/module.h&gt;<br>
&gt; +#include &lt;linux/of.h&gt;<br>
&gt; +#include &lt;linux/of_device.h&gt;<br>
&gt; +<br>
&gt; +#include &lt;linux/gpio/consumer.h&gt;<br>
&gt; +#include &lt;linux/regulator/consumer.h&gt;<br>
&gt; +<br>
&gt; +#include &lt;drm/drm_device.h&gt;<br>
&gt; +#include &lt;drm/drm_mipi_dsi.h&gt;<br>
&gt; +#include &lt;drm/drm_modes.h&gt;<br>
&gt; +#include &lt;drm/drm_panel.h&gt;<br>
&gt; +#include &lt;drm/drm_print.h&gt;<br>
&gt; +<br>
&gt; +#include &lt;video/mipi_display.h&gt;<br>
&gt; +<br>
&gt; +struct panel_cmd {<br>
&gt; +       size_t len;<br>
&gt; +       const char *data;<br>
&gt; +};<br>
&gt; +<br>
&gt; +#define _INIT_CMD(...) { \<br>
&gt; +       .len = sizeof((char[]){__VA_ARGS__}), \<br>
&gt; +       .data = (char[]){__VA_ARGS__} }<br>
&gt; +<br>
&gt; +struct panel_desc {<br>
&gt; +       const struct drm_display_mode *display_mode;<br>
&gt; +       unsigned int bpc;<br>
&gt; +       unsigned int width_mm;<br>
&gt; +       unsigned int height_mm;<br>
&gt; +<br>
&gt; +       unsigned int delay_t1;<br>
&gt; +       unsigned int reset_delay_t2;<br>
&gt; +       unsigned int reset_delay_t3;<br>
&gt; +       unsigned int reset_delay_t4;<br>
&gt; +       unsigned int reset_delay_t5;<br>
&gt; +<br>
&gt; +       unsigned long mode_flags;<br>
&gt; +       enum mipi_dsi_pixel_format format;<br>
&gt; +       unsigned int lanes;<br>
&gt; +       const struct panel_cmd *on_cmds;<br>
&gt; +       const struct panel_cmd *off_cmds;<br>
&gt; +};<br>
&gt; +<br>
&gt; +struct panel_info {<br>
&gt; +       struct drm_panel base;<br>
&gt; +       struct mipi_dsi_device *link;<br>
&gt; +       const struct panel_desc *desc;<br>
&gt; +<br>
&gt; +       struct backlight_device *backlight;<br>
&gt; +       struct gpio_desc *enable_gpio;<br>
&gt; +       struct gpio_desc *pp33_gpio;<br>
&gt; +       struct gpio_desc *pp18_gpio;<br>
&gt; +<br>
&gt; +       bool prepared;<br>
&gt; +       bool enabled;<br>
&gt; +};<br>
&gt; +<br>
&gt; +static inline struct panel_info *to_panel_info(struct drm_panel *panel)<br>
&gt; +{<br>
&gt; +       return container_of(panel, struct panel_info, base);<br>
&gt; +}<br>
&gt; +<br>
&gt; +static void set_gpios(struct panel_info *pinfo, int enable)<br>
&gt; +{<br>
&gt; +       gpiod_set_value(pinfo-&gt;enable_gpio, enable);<br>
&gt; +       gpiod_set_value(pinfo-&gt;pp33_gpio, enable);<br>
&gt; +       gpiod_set_value(pinfo-&gt;pp18_gpio, enable);<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int send_mipi_cmds(struct drm_panel *panel, const struct panel_cmd *cmds)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = to_panel_info(panel);<br>
&gt; +       unsigned int i = 0;<br>
&gt; +       int err;<br>
&gt; +<br>
&gt; +       if (!cmds)<br>
&gt; +               return -EFAULT;<br>
&gt; +<br>
&gt; +       for (i = 0; cmds[i].len != 0; i++) {<br>
&gt; +               const struct panel_cmd *cmd = &amp;cmds[i];<br>
&gt; +<br>
&gt; +               if (cmd-&gt;len == 2)<br>
&gt; +                       err = mipi_dsi_dcs_write(pinfo-&gt;link,<br>
&gt; +                                                   cmd-&gt;data[1], NULL, 0);<br>
&gt; +               else<br>
&gt; +                       err = mipi_dsi_dcs_write(pinfo-&gt;link,<br>
&gt; +                                                   cmd-&gt;data[1], cmd-&gt;data + 2,<br>
&gt; +                                                   cmd-&gt;len - 2);<br>
&gt; +<br>
&gt; +               if (err &lt; 0)<br>
&gt; +                       return err;<br>
&gt; +<br>
&gt; +               usleep_range((cmd-&gt;data[0]) * 1000,<br>
&gt; +                           (1 + cmd-&gt;data[0]) * 1000);<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int boe_panel_disable(struct drm_panel *panel)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = to_panel_info(panel);<br>
&gt; +<br>
&gt; +       backlight_disable(pinfo-&gt;backlight);<br>
&gt; +<br>
&gt; +       pinfo-&gt;enabled = false;<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int boe_panel_unprepare(struct drm_panel *panel)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = to_panel_info(panel);<br>
&gt; +       int err;<br>
&gt; +<br>
&gt; +       if (!pinfo-&gt;prepared)<br>
&gt; +               return 0;<br>
&gt; +<br>
&gt; +       /* send off code */<br>
&gt; +       err = send_mipi_cmds(panel, pinfo-&gt;desc-&gt;off_cmds);<br>
&gt; +       if (err &lt; 0) {<br>
&gt; +               DRM_DEV_ERROR(panel-&gt;dev,<br>
&gt; +                               &quot;failed to send DCS Off Code: %d\n&quot;, err);<br>
&gt; +               goto poweroff;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       set_gpios(pinfo, 0);<br>
&gt; +<br>
&gt; +       pinfo-&gt;prepared = false;<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +<br>
&gt; +poweroff:<br>
&gt; +       set_gpios(pinfo, 0);<br>
&gt; +       return err;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int boe_panel_prepare(struct drm_panel *panel)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = to_panel_info(panel);<br>
&gt; +       const struct panel_desc *desc = pinfo-&gt;desc;<br>
&gt; +       int err;<br>
&gt; +<br>
&gt; +       if (pinfo-&gt;prepared)<br>
&gt; +               return 0;<br>
&gt; +<br>
&gt; +       gpiod_set_value(pinfo-&gt;pp18_gpio, 1);<br>
&gt; +       /* T1 (&gt; 5ms) */<br>
&gt; +       usleep_range(desc-&gt;delay_t1, 1000 + desc-&gt;delay_t1);<br>
&gt; +       gpiod_set_value(pinfo-&gt;pp33_gpio, 1);<br>
&gt; +<br>
&gt; +       /* reset sequence */<br>
&gt; +       usleep_range(desc-&gt;reset_delay_t2, 1000 + desc-&gt;reset_delay_t2);<br>
&gt; +<br>
&gt; +       gpiod_set_value(pinfo-&gt;enable_gpio, 1);<br>
&gt; +       usleep_range(desc-&gt;reset_delay_t3, 1000 + desc-&gt;reset_delay_t3);<br>
&gt; +       gpiod_set_value(pinfo-&gt;enable_gpio, 0);<br>
&gt; +<br>
&gt; +       usleep_range(desc-&gt;reset_delay_t4, 1000 + desc-&gt;reset_delay_t4);<br>
&gt; +       gpiod_set_value(pinfo-&gt;enable_gpio, 1);<br>
&gt; +<br>
&gt; +       usleep_range(desc-&gt;reset_delay_t5, 1000 + desc-&gt;reset_delay_t5);<br>
&gt; +<br>
&gt; +       /* send init code */<br>
&gt; +       err = send_mipi_cmds(panel, pinfo-&gt;desc-&gt;on_cmds);<br>
&gt; +       if (err &lt; 0) {<br>
&gt; +               DRM_DEV_ERROR(panel-&gt;dev,<br>
&gt; +                               &quot;failed to send DCS Init Code: %d\n&quot;, err);<br>
&gt; +               goto poweroff;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       pinfo-&gt;prepared = true;<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +<br>
&gt; +poweroff:<br>
&gt; +       set_gpios(pinfo, 0);<br>
&gt; +       return err;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int boe_panel_enable(struct drm_panel *panel)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = to_panel_info(panel);<br>
&gt; +       int ret;<br>
&gt; +<br>
&gt; +       if (pinfo-&gt;enabled)<br>
&gt; +               return 0;<br>
&gt; +<br>
&gt; +       ret = backlight_enable(pinfo-&gt;backlight);<br>
&gt; +       if (ret) {<br>
&gt; +               DRM_DEV_ERROR(panel-&gt;drm-&gt;dev,<br>
&gt; +                               &quot;Failed to enable backlight %d\n&quot;, ret);<br>
&gt; +               return ret;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       pinfo-&gt;enabled = true;<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int boe_panel_get_modes(struct drm_panel *panel)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = to_panel_info(panel);<br>
&gt; +       const struct drm_display_mode *m = pinfo-&gt;desc-&gt;display_mode;<br>
&gt; +       struct drm_display_mode *mode;<br>
&gt; +<br>
&gt; +       mode = drm_mode_duplicate(panel-&gt;drm, m);<br>
&gt; +       if (!mode) {<br>
&gt; +               DRM_DEV_ERROR(panel-&gt;drm-&gt;dev, &quot;failed to add mode %ux%u@%u\n&quot;,<br>
&gt; +                               m-&gt;hdisplay, m-&gt;vdisplay, m-&gt;vrefresh);<br>
&gt; +               return -ENOMEM;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       drm_mode_set_name(mode);<br>
&gt; +<br>
&gt; +       drm_mode_probed_add(panel-&gt;connector, mode);<br>
&gt; +<br>
&gt; +       panel-&gt;connector-&gt;display_info.width_mm = pinfo-&gt;desc-&gt;width_mm;<br>
&gt; +       panel-&gt;connector-&gt;display_info.height_mm = pinfo-&gt;desc-&gt;height_mm;<br>
&gt; +       panel-&gt;connector-&gt;display_info.bpc = pinfo-&gt;desc-&gt;bpc;<br>
&gt; +<br>
&gt; +       return 1;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static const struct drm_panel_funcs panel_funcs = {<br>
&gt; +       .disable = boe_panel_disable,<br>
&gt; +       .unprepare = boe_panel_unprepare,<br>
&gt; +       .prepare = boe_panel_prepare,<br>
&gt; +       .enable = boe_panel_enable,<br>
&gt; +       .get_modes = boe_panel_get_modes,<br>
&gt; +};<br>
&gt; +<br>
&gt; +static const struct drm_display_mode default_display_mode = {<br>
&gt; +       .clock = 159420,<br>
&gt; +       .hdisplay = 1200,<br>
&gt; +       .hsync_start = 1200 + 80,<br>
&gt; +       .hsync_end = 1200 + 80 + 60,<br>
&gt; +       .htotal = 1200 + 80 + 60 + 24,<br>
&gt; +       .vdisplay = 1920,<br>
&gt; +       .vsync_start = 1920 + 10,<br>
&gt; +       .vsync_end = 1920 + 10 + 14,<br>
&gt; +       .vtotal = 1920 + 10 + 14 + 4,<br>
&gt; +       .vrefresh = 60,<br>
&gt; +};<br>
&gt; +<br>
&gt; +static const struct panel_cmd default_off_cmds[] = {<br>
&gt; +       _INIT_CMD(0x00, 0x28),<br>
&gt; +       _INIT_CMD(0x01, 0x10),<br>
&gt; +<br>
&gt; +       {},<br>
&gt; +};<br>
&gt; +<br>
&gt; +/* 8 inch */<br>
&gt; +static const struct panel_cmd boe_himax8279d8p_on_cmds[] = {<br>
&gt; +       _INIT_CMD(0x22, 0x10),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0xE5),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x52),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x88),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x50),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x8B),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x15),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x0F),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x02),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x02),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x01),<br>
&gt; +       _INIT_CMD(0x00, 0xE0, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xE1, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xDC, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xDD, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xD2, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xD3, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xE6, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xE7, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xD8, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xD9, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xD6, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xD7, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xD4, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xD5, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xDE, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xDF, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCF, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xDA, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xDB, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xE2, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xE3, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x02),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x0D),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x18),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x27),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x28),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0x30),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0x2E),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x1A),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x20),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x29),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0x32),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0x33),<br>
&gt; +       _INIT_CMD(0x00, 0xCF, 0x31),<br>
&gt; +       _INIT_CMD(0x00, 0xD0, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xD2, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xD3, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xD4, 0x12),<br>
&gt; +       _INIT_CMD(0x00, 0xD5, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xD6, 0x3D),<br>
&gt; +       _INIT_CMD(0x00, 0xD7, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xD8, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xD9, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDA, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDB, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDC, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDD, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDE, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDF, 0x3A),<br>
&gt; +       _INIT_CMD(0x00, 0xE0, 0x37),<br>
&gt; +       _INIT_CMD(0x00, 0xE1, 0x35),<br>
&gt; +       _INIT_CMD(0x00, 0xE2, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xE7, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x2A),<br>
&gt; +       _INIT_CMD(0x00, 0xDE, 0x2A),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x43),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xE4, 0xC0),<br>
&gt; +       _INIT_CMD(0x00, 0xE5, 0x0D),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0x0F),<br>
&gt; +       _INIT_CMD(0x00, 0xD5, 0x32),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x44),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x52),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6A),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x8A),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xCA),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x05, 0xBB, 0x87),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x3D),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x71),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x90),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xA0),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xA8),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xBB),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xC0),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xC4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x31),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x46),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x55),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6E),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x92),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xD4),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x1B),<br>
&gt; +       _INIT_CMD(0x05, 0xBB, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x28),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x2D),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0xC3),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x99),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0xAB),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xBF),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xCF),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xDF),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xF0),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xF9),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xFC),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x17),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2E),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x42),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x51),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x69),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x88),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xC9),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x05, 0xBB, 0x86),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x95),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x35),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x81),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x96),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x9E),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xAD),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xB4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x44),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x52),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6A),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x8A),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xCA),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x05, 0xBB, 0x87),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x3D),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x71),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x90),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xA0),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xA8),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xBB),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xC0),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xC4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x31),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x46),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x55),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6E),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x92),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xD4),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x1B),<br>
&gt; +       _INIT_CMD(0x05, 0xBB, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x28),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x2D),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0xC3),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x99),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0xAB),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xBF),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xCF),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xDF),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xF0),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xF9),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xFC),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x17),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2E),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x42),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x51),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x69),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x88),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xC9),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x05, 0xBB, 0x86),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x95),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x35),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x81),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x96),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x9E),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xAD),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xB4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x64, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x04),<br>
&gt; +       _INIT_CMD(0x0A, 0xB8, 0x68),<br>
&gt; +       _INIT_CMD(0x78, 0x11),<br>
&gt; +       _INIT_CMD(0x14, 0x29),<br>
&gt; +<br>
&gt; +       {},<br>
&gt; +};<br>
&gt; +<br>
&gt; +static const struct panel_desc boe_himax8279d8p_panel_desc = {<br>
&gt; +       .display_mode = &amp;default_display_mode,<br>
&gt; +       .bpc = 8,<br>
&gt; +       .width_mm = 107,<br>
&gt; +       .height_mm = 172,<br>
&gt; +       .delay_t1 = 5000,<br>
&gt; +       .reset_delay_t2 = 14000,<br>
&gt; +       .reset_delay_t3 = 1000,<br>
&gt; +       .reset_delay_t4 = 1000,<br>
&gt; +       .reset_delay_t5 = 5000,<br>
&gt; +       .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |<br>
&gt; +                       MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,<br>
&gt; +       .format = MIPI_DSI_FMT_RGB888,<br>
&gt; +       .lanes = 4,<br>
&gt; +       .on_cmds = boe_himax8279d8p_on_cmds,<br>
&gt; +       .off_cmds = default_off_cmds,<br>
&gt; +};<br>
&gt; +<br>
&gt; +/* 10 inch */<br>
&gt; +static const struct panel_cmd boe_himax8279d10p_on_cmds[] = {<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0xE5),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x52),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x88),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x50),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x8B),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x1A),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x0F),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x02),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x02),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x01),<br>
&gt; +       _INIT_CMD(0x00, 0xE0, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xE1, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xDC, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xDD, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xD2, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xD3, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xE6, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xE7, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xD8, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xD9, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xD6, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xD7, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xD4, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xD5, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xDE, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xDF, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCF, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xDA, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xDB, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xE2, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xE3, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x02),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x0D),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x18),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x27),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x28),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0x30),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0x2E),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x1A),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x20),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x29),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0x32),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0x33),<br>
&gt; +       _INIT_CMD(0x00, 0xCF, 0x31),<br>
&gt; +       _INIT_CMD(0x00, 0xD0, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xD2, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xD3, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xD4, 0x12),<br>
&gt; +       _INIT_CMD(0x00, 0xD5, 0x26),<br>
&gt; +       _INIT_CMD(0x00, 0xD6, 0x3D),<br>
&gt; +       _INIT_CMD(0x00, 0xD7, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xD8, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xD9, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDA, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDB, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDC, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDD, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDE, 0x3F),<br>
&gt; +       _INIT_CMD(0x00, 0xDF, 0x3A),<br>
&gt; +       _INIT_CMD(0x00, 0xE0, 0x37),<br>
&gt; +       _INIT_CMD(0x00, 0xE1, 0x35),<br>
&gt; +       _INIT_CMD(0x00, 0xE2, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xE7, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0x2A),<br>
&gt; +       _INIT_CMD(0x00, 0xDE, 0x2A),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x43),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xE4, 0xC0),<br>
&gt; +       _INIT_CMD(0x00, 0xE5, 0x0D),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0x0F),<br>
&gt; +       _INIT_CMD(0x00, 0xD5, 0x32),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x07),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x44),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x52),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6A),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x8A),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xCA),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xBB, 0x87),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x3D),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x71),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x90),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xA0),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xA8),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xBB),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xC0),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xC4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x31),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x46),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x55),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6E),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x92),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xD4),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x1B),<br>
&gt; +       _INIT_CMD(0x00, 0xBB, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x28),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x2D),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0xC3),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x99),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0xAB),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xBF),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xCF),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xDF),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xF0),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xF9),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xFC),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x17),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2E),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x42),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x51),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x69),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x88),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xC9),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xBB, 0x86),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x95),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x35),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x81),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x96),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x9E),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xAD),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xB4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x09),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x44),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x52),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6A),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x8A),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xCA),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xBB, 0x87),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x06),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x0A),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x3D),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x71),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x90),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xA0),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xA8),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xBB),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xC0),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xC4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x0B),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x19),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x31),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x46),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x55),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x6E),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x92),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xD4),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x1B),<br>
&gt; +       _INIT_CMD(0x00, 0xBB, 0x9B),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x28),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x2D),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0xC3),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x2F),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x99),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0xAB),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0xBF),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0xCF),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xDF),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xF0),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xF9),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xFC),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xB1, 0x04),<br>
&gt; +       _INIT_CMD(0x00, 0xB2, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x17),<br>
&gt; +       _INIT_CMD(0x00, 0xB4, 0x2E),<br>
&gt; +       _INIT_CMD(0x00, 0xB5, 0x42),<br>
&gt; +       _INIT_CMD(0x00, 0xB6, 0x51),<br>
&gt; +       _INIT_CMD(0x00, 0xB7, 0x69),<br>
&gt; +       _INIT_CMD(0x00, 0xB8, 0x88),<br>
&gt; +       _INIT_CMD(0x00, 0xB9, 0xC9),<br>
&gt; +       _INIT_CMD(0x00, 0xBA, 0x0C),<br>
&gt; +       _INIT_CMD(0x00, 0xBB, 0x86),<br>
&gt; +       _INIT_CMD(0x00, 0xBC, 0x03),<br>
&gt; +       _INIT_CMD(0x00, 0xBD, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xBE, 0x95),<br>
&gt; +       _INIT_CMD(0x00, 0xBF, 0x05),<br>
&gt; +       _INIT_CMD(0x00, 0xC0, 0x35),<br>
&gt; +       _INIT_CMD(0x00, 0xC1, 0x62),<br>
&gt; +       _INIT_CMD(0x00, 0xC2, 0x81),<br>
&gt; +       _INIT_CMD(0x00, 0xC3, 0x96),<br>
&gt; +       _INIT_CMD(0x00, 0xC4, 0x9E),<br>
&gt; +       _INIT_CMD(0x00, 0xC5, 0xA5),<br>
&gt; +       _INIT_CMD(0x00, 0xC6, 0xAD),<br>
&gt; +       _INIT_CMD(0x00, 0xC7, 0xB1),<br>
&gt; +       _INIT_CMD(0x00, 0xC8, 0xB4),<br>
&gt; +       _INIT_CMD(0x00, 0xC9, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCA, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xCB, 0x16),<br>
&gt; +       _INIT_CMD(0x00, 0xCC, 0xAF),<br>
&gt; +       _INIT_CMD(0x00, 0xCD, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xCE, 0xFF),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x00),<br>
&gt; +       _INIT_CMD(0x00, 0xB3, 0x08),<br>
&gt; +       _INIT_CMD(0x00, 0xB0, 0x04),<br>
&gt; +       _INIT_CMD(0x64, 0xB8, 0x68),<br>
&gt; +<br>
&gt; +       {},<br>
&gt; +};<br>
&gt; +<br>
&gt; +static const struct panel_desc boe_himax8279d10p_panel_desc = {<br>
&gt; +       .display_mode = &amp;default_display_mode,<br>
&gt; +       .bpc = 8,<br>
&gt; +       .width_mm = 135,<br>
&gt; +       .height_mm = 216,<br>
&gt; +       .delay_t1 = 5000,<br>
&gt; +       .reset_delay_t2 = 14000,<br>
&gt; +       .reset_delay_t3 = 1000,<br>
&gt; +       .reset_delay_t4 = 1000,<br>
&gt; +       .reset_delay_t5 = 5000,<br>
&gt; +       .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |<br>
&gt; +                       MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,<br>
&gt; +       .format = MIPI_DSI_FMT_RGB888,<br>
&gt; +       .lanes = 4,<br>
&gt; +       .on_cmds = boe_himax8279d10p_on_cmds,<br>
&gt; +       .off_cmds = default_off_cmds,<br>
&gt; +};<br>
&gt; +<br>
&gt; +static const struct of_device_id panel_of_match[] = {<br>
&gt; +       { .compatible = &quot;boe,himax8279d8p&quot;,<br>
&gt; +         .data = &amp;boe_himax8279d8p_panel_desc<br>
&gt; +       }, { .compatible = &quot;boe,himax8279d10p&quot;,<br>
&gt; +         .data = &amp;boe_himax8279d10p_panel_desc<br>
&gt; +       }, {<br>
&gt; +               /* sentinel */<br>
&gt; +       }<br>
&gt; +};<br>
&gt; +MODULE_DEVICE_TABLE(of, panel_of_match);<br>
&gt; +<br>
&gt; +static int panel_add(struct panel_info *pinfo)<br>
&gt; +{<br>
&gt; +       struct device *dev = &amp;pinfo-&gt;link-&gt;dev;<br>
&gt; +       int ret;<br>
&gt; +<br>
&gt; +       pinfo-&gt;pp18_gpio = devm_gpiod_get_optional(dev, &quot;pp18&quot;, GPIOD_OUT_HIGH);<br>
&gt; +       if (IS_ERR(pinfo-&gt;pp18_gpio)) {<br>
&gt; +               ret = PTR_ERR(pinfo-&gt;pp18_gpio);<br>
&gt; +               if (ret != -EPROBE_DEFER)<br>
&gt; +                       DRM_DEV_ERROR(dev, &quot;failed to get pp18 gpio: %d\n&quot;,<br>
&gt; +                                       ret);<br>
&gt; +               return ret;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       pinfo-&gt;pp33_gpio = devm_gpiod_get_optional(dev, &quot;pp33&quot;, GPIOD_OUT_HIGH);<br>
&gt; +       if (IS_ERR(pinfo-&gt;pp33_gpio)) {<br>
&gt; +               ret = PTR_ERR(pinfo-&gt;pp33_gpio);<br>
&gt; +               if (ret != -EPROBE_DEFER)<br>
&gt; +                       DRM_DEV_ERROR(dev, &quot;failed to get pp33 gpio: %d\n&quot;,<br>
&gt; +                                       ret);<br>
&gt; +               return ret;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       pinfo-&gt;enable_gpio = devm_gpiod_get_optional(dev, &quot;enable&quot;,<br>
&gt; +                                                       GPIOD_OUT_HIGH);<br>
&gt; +       if (IS_ERR(pinfo-&gt;enable_gpio)) {<br>
&gt; +               ret = PTR_ERR(pinfo-&gt;enable_gpio);<br>
&gt; +               if (ret != -EPROBE_DEFER)<br>
&gt; +                       DRM_DEV_ERROR(dev, &quot;failed to get enable gpio: %d\n&quot;,<br>
&gt; +                                       ret);<br>
&gt; +               return ret;<br>
&gt; +       }<br>
&gt; +<br>
&gt; +       pinfo-&gt;backlight = devm_of_find_backlight(dev);<br>
&gt; +       if (IS_ERR(pinfo-&gt;backlight))<br>
&gt; +               return PTR_ERR(pinfo-&gt;backlight);<br>
&gt; +<br>
&gt; +       drm_panel_init(&amp;pinfo-&gt;base);<br>
&gt; +       pinfo-&gt;base.funcs = &amp;panel_funcs;<br>
&gt; +       pinfo-&gt;base.dev = &amp;pinfo-&gt;link-&gt;dev;<br>
&gt; +<br>
&gt; +       ret = drm_panel_add(&amp;pinfo-&gt;base);<br>
&gt; +       if (ret &lt; 0)<br>
&gt; +               return ret;<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static void panel_del(struct panel_info *pinfo)<br>
&gt; +{<br>
&gt; +       if (pinfo-&gt;base.dev)<br>
&gt; +               drm_panel_remove(&amp;pinfo-&gt;base);<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int panel_probe(struct mipi_dsi_device *dsi)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo;<br>
&gt; +       const struct panel_desc *desc;<br>
&gt; +       int err;<br>
&gt; +<br>
&gt; +       pinfo = devm_kzalloc(&amp;dsi-&gt;dev, sizeof(*pinfo), GFP_KERNEL);<br>
&gt; +       if (!pinfo)<br>
&gt; +               return -ENOMEM;<br>
&gt; +<br>
&gt; +       desc = of_device_get_match_data(&amp;dsi-&gt;dev);<br>
&gt; +       dsi-&gt;mode_flags = desc-&gt;mode_flags;<br>
&gt; +       dsi-&gt;format = desc-&gt;format;<br>
&gt; +       dsi-&gt;lanes = desc-&gt;lanes;<br>
&gt; +       pinfo-&gt;desc = desc;<br>
&gt; +<br>
&gt; +       pinfo-&gt;link = dsi;<br>
&gt; +       mipi_dsi_set_drvdata(dsi, pinfo);<br>
&gt; +<br>
&gt; +       err = panel_add(pinfo);<br>
&gt; +       if (err &lt; 0)<br>
&gt; +               return err;<br>
&gt; +<br>
&gt; +       return mipi_dsi_attach(dsi);<br>
&gt; +}<br>
&gt; +<br>
&gt; +static int panel_remove(struct mipi_dsi_device *dsi)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);<br>
&gt; +       int err;<br>
&gt; +<br>
&gt; +       err = boe_panel_unprepare(&amp;pinfo-&gt;base);<br>
&gt; +       if (err &lt; 0)<br>
&gt; +               DRM_DEV_ERROR(&amp;dsi-&gt;dev, &quot;failed to unprepare panel: %d\n&quot;,<br>
&gt; +                               err);<br>
&gt; +<br>
&gt; +       err = boe_panel_disable(&amp;pinfo-&gt;base);<br>
&gt; +       if (err &lt; 0)<br>
&gt; +               DRM_DEV_ERROR(&amp;dsi-&gt;dev, &quot;failed to disable panel: %d\n&quot;, err);<br>
&gt; +<br>
&gt; +       err = mipi_dsi_detach(dsi);<br>
&gt; +       if (err &lt; 0)<br>
&gt; +               DRM_DEV_ERROR(&amp;dsi-&gt;dev, &quot;failed to detach from DSI host: %d\n&quot;,<br>
&gt; +                               err);<br>
&gt; +<br>
&gt; +       drm_panel_detach(&amp;pinfo-&gt;base);<br>
&gt; +       panel_del(pinfo);<br>
&gt; +<br>
&gt; +       return 0;<br>
&gt; +}<br>
&gt; +<br>
&gt; +static void panel_shutdown(struct mipi_dsi_device *dsi)<br>
&gt; +{<br>
&gt; +       struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);<br>
&gt; +<br>
&gt; +       boe_panel_disable(&amp;pinfo-&gt;base);<br>
&gt; +       boe_panel_unprepare(&amp;pinfo-&gt;base);<br>
&gt; +}<br>
&gt; +<br>
&gt; +static struct mipi_dsi_driver panel_driver = {<br>
&gt; +       .driver = {<br>
&gt; +               .name = &quot;panel-boe-himax8279d&quot;,<br>
&gt; +               .of_match_table = panel_of_match,<br>
&gt; +       },<br>
&gt; +       .probe = panel_probe,<br>
&gt; +       .remove = panel_remove,<br>
&gt; +       .shutdown = panel_shutdown,<br>
&gt; +};<br>
&gt; +module_mipi_dsi_driver(panel_driver);<br>
&gt; +<br>
&gt; +MODULE_AUTHOR(&quot;Jerry Han &lt;<a href="mailto:hanxu5@huaqin.corp-partner.google.com" target="_blank">hanxu5@huaqin.corp-partner.google.com</a>&gt;&quot;);<br>
&gt; +MODULE_DESCRIPTION(&quot;Boe Himax8279d driver&quot;);<br>
&gt; +MODULE_LICENSE(&quot;GPL v2&quot;);<br>
&gt; --<br>
&gt; 2.17.1<br>
&gt;<br>
</blockquote></div>
Thierry Reding April 23, 2019, 12:08 p.m. UTC | #3 
On Tue, Mar 26, 2019 at 03:09:33PM +0800, Jerry Han wrote:
> Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> panel.
> 
> V7:
> - Add the information of the reviewer
> - Remove unnecessary delays, The udelay_range code gracefully returns
>     without hitting the scheduler on a delay of 0. (Derek)
> - Merge the same data structures, like display_mode and off_cmds (Derek)
> - Optimize the processing of results returned by
>     devm_gpiod_get_optional (Derek)
> 
> V6:
> - Add the information of the reviewer (Sam)
> - Delete unnecessary header files #include <linux/fb.h> (Sam)
> - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)
> - ADD static, set_gpios function is not used outside this module (Sam)
> 
> V5:
> - Added changelog
> 
> V4:
> - Frefix all function maes with boe_ (Sam)
> - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
> - Sort include lines alphabetically (Sam)
> - Fixed entries in the makefile must be sorted alphabetically (Sam)
> - Add send_mipi_cmds function to avoid duplicating the code (Sam)
> - Add the necessary delay(reset_delay_t5) between reset and sending
>     the initialization command (Rock wang)
> 
> V3:
> - Remove unnecessary delays in sending initialization commands (Jitao Shi)
> 
> V2:
> - Use SPDX identifier (Sam)
> - Use necessary header files replace drmP.h (Sam)
> - Delete unnecessary header files #include <linux/err.h> (Sam)
> - Specifies a GPIOs array to control the reset timing,
>     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> - Delete backlight_disable() function when already disabled (Sam)
> - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
> - Move the necessary data in the DTS to the current file,
>     like porch, display_mode and Init code etc. (Sam)
> - Add compatible device "boe,himax8279d10p" (Sam)
> 
> Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>

The sign-off identity doesn't match the authorship information in the
patch. You may want to fix your git configuration.

Thierry
Jerry Han April 25, 2019, 2:08 a.m. UTC | #4 
Thanks for your help

Both mailbox accounts are mine.
I don't know what to do next.
Do I need to resubmit the patch[V7]?


Thierry Reding <thierry.reding@gmail.com> 于2019年4月23日周二 下午8:08写道：

> On Tue, Mar 26, 2019 at 03:09:33PM +0800, Jerry Han wrote:
> > Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI
> > panel.
> >
> > V7:
> > - Add the information of the reviewer
> > - Remove unnecessary delays, The udelay_range code gracefully returns
> >     without hitting the scheduler on a delay of 0. (Derek)
> > - Merge the same data structures, like display_mode and off_cmds (Derek)
> > - Optimize the processing of results returned by
> >     devm_gpiod_get_optional (Derek)
> >
> > V6:
> > - Add the information of the reviewer (Sam)
> > - Delete unnecessary header files #include <linux/fb.h> (Sam)
> > - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them
> (Sam)
> > - ADD static, set_gpios function is not used outside this module (Sam)
> >
> > V5:
> > - Added changelog
> >
> > V4:
> > - Frefix all function maes with boe_ (Sam)
> > - Fsed "enable_gpio" replace "reset_gpio", Make it look clearer (Sam)
> > - Sort include lines alphabetically (Sam)
> > - Fixed entries in the makefile must be sorted alphabetically (Sam)
> > - Add send_mipi_cmds function to avoid duplicating the code (Sam)
> > - Add the necessary delay(reset_delay_t5) between reset and sending
> >     the initialization command (Rock wang)
> >
> > V3:
> > - Remove unnecessary delays in sending initialization commands (Jitao
> Shi)
> >
> > V2:
> > - Use SPDX identifier (Sam)
> > - Use necessary header files replace drmP.h (Sam)
> > - Delete unnecessary header files #include <linux/err.h> (Sam)
> > - Specifies a GPIOs array to control the reset timing,
> >     instead of reading "dsi-reset-sequence" data from DTS (Sam)
> > - Delete backlight_disable() function when already disabled (Sam)
> > - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)
> > - Move the necessary data in the DTS to the current file,
> >     like porch, display_mode and Init code etc. (Sam)
> > - Add compatible device "boe,himax8279d10p" (Sam)
> >
> > Signed-off-by: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
>
> The sign-off identity doesn't match the authorship information in the
> patch. You may want to fix your git configuration.
>
> Thierry
>
<div dir="ltr"><div dir="ltr">Thanks for your help</div><div dir="ltr"><br><div><div>Both mailbox accounts are mine.</div><div>I don&#39;t know what to do next.</div><div>Do I need to resubmit the patch[V7]?</div><div><br></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Thierry Reding &lt;<a href="mailto:thierry.reding@gmail.com">thierry.reding@gmail.com</a>&gt; 于2019年4月23日周二 下午8:08写道：<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Mar 26, 2019 at 03:09:33PM +0800, Jerry Han wrote:<br>
&gt; Support Boe Himax8279d 8.0&quot; 1200x1920 TFT LCD panel, it is a MIPI DSI<br>
&gt; panel.<br>
&gt; <br>
&gt; V7:<br>
&gt; - Add the information of the reviewer<br>
&gt; - Remove unnecessary delays, The udelay_range code gracefully returns<br>
&gt;     without hitting the scheduler on a delay of 0. (Derek)<br>
&gt; - Merge the same data structures, like display_mode and off_cmds (Derek)<br>
&gt; - Optimize the processing of results returned by<br>
&gt;     devm_gpiod_get_optional (Derek)<br>
&gt; <br>
&gt; V6:<br>
&gt; - Add the information of the reviewer (Sam)<br>
&gt; - Delete unnecessary header files #include &lt;linux/fb.h&gt; (Sam)<br>
&gt; - The config DRM_PANEL_BOE_HIMAX8279D appears twice. Drop one of them (Sam)<br>
&gt; - ADD static, set_gpios function is not used outside this module (Sam)<br>
&gt; <br>
&gt; V5:<br>
&gt; - Added changelog<br>
&gt; <br>
&gt; V4:<br>
&gt; - Frefix all function maes with boe_ (Sam)<br>
&gt; - Fsed &quot;enable_gpio&quot; replace &quot;reset_gpio&quot;, Make it look clearer (Sam)<br>
&gt; - Sort include lines alphabetically (Sam)<br>
&gt; - Fixed entries in the makefile must be sorted alphabetically (Sam)<br>
&gt; - Add send_mipi_cmds function to avoid duplicating the code (Sam)<br>
&gt; - Add the necessary delay(reset_delay_t5) between reset and sending<br>
&gt;     the initialization command (Rock wang)<br>
&gt; <br>
&gt; V3:<br>
&gt; - Remove unnecessary delays in sending initialization commands (Jitao Shi)<br>
&gt; <br>
&gt; V2:<br>
&gt; - Use SPDX identifier (Sam)<br>
&gt; - Use necessary header files replace drmP.h (Sam)<br>
&gt; - Delete unnecessary header files #include &lt;linux/err.h&gt; (Sam)<br>
&gt; - Specifies a GPIOs array to control the reset timing,<br>
&gt;     instead of reading &quot;dsi-reset-sequence&quot; data from DTS (Sam)<br>
&gt; - Delete backlight_disable() function when already disabled (Sam)<br>
&gt; - Use devm_of_find_backlight() replace of_find_backlight_by_node() (Sam)<br>
&gt; - Move the necessary data in the DTS to the current file,<br>
&gt;     like porch, display_mode and Init code etc. (Sam)<br>
&gt; - Add compatible device &quot;boe,himax8279d10p&quot; (Sam)<br>
&gt; <br>
&gt; Signed-off-by: Jerry Han &lt;<a href="mailto:hanxu5@huaqin.corp-partner.google.com" target="_blank">hanxu5@huaqin.corp-partner.google.com</a>&gt;<br>
<br>
The sign-off identity doesn&#39;t match the authorship information in the<br>
patch. You may want to fix your git configuration.<br>
<br>
Thierry<br>
</blockquote></div>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f8e63bcc4c1c..267468ca72bb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4816,6 +4816,12 @@  T:	git git://anongit.freedesktop.org/drm/drm-misc
 S:	Maintained
 F:	drivers/gpu/drm/bochs/
 
+DRM DRIVER FOR BOE HIMAX8279D PANELS
+M:	Jerry Han <hanxu5@huaqin.corp-partner.google.com>
+S:	Maintained
+F:	drivers/gpu/drm/panel/panel-boe-himax8279d.c
+F:	Documentation/devicetree/bindings/display/panel/boe,himax8279d.txt
+
 DRM DRIVER FOR FARADAY TVE200 TV ENCODER
 M:	Linus Walleij <linus.walleij@linaro.org>
 T:	git git://anongit.freedesktop.org/drm/drm-misc
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index f53f817356db..fe2f87cc6627 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -17,6 +17,17 @@  config DRM_PANEL_ARM_VERSATILE
 	  reference designs. The panel is detected using special registers
 	  in the Versatile family syscon registers.
 
+config DRM_PANEL_BOE_HIMAX8279D
+	tristate "Boe Himax8279d panel"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y here if you want to enable support for Boe Himax8279d
+	  TFT-LCD modules. The panel has a 1200x1920 resolution and uses
+	  24 bit RGB per pixel. It provides a MIPI DSI interface to
+	  the host and has a built-in LED backlight.
+
 config DRM_PANEL_LVDS
 	tristate "Generic LVDS panel driver"
 	depends on OF
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index 7834947a53b0..c4814b6f069e 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -1,5 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o
+obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
 obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
 obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
 obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o
diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
new file mode 100644
index 000000000000..ff5a89e38fd7
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
@@ -0,0 +1,1050 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2019, Huaqin Telecom Technology Co., Ltd
+ *
+ * Author: Jerry Han <hanxu5@huaqin.corp-partner.google.com>
+ *
+ */
+
+#include <linux/backlight.h>
+#include <linux/delay.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+
+#include <linux/gpio/consumer.h>
+#include <linux/regulator/consumer.h>
+
+#include <drm/drm_device.h>
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+#include <drm/drm_print.h>
+
+#include <video/mipi_display.h>
+
+struct panel_cmd {
+	size_t len;
+	const char *data;
+};
+
+#define _INIT_CMD(...) { \
+	.len = sizeof((char[]){__VA_ARGS__}), \
+	.data = (char[]){__VA_ARGS__} }
+
+struct panel_desc {
+	const struct drm_display_mode *display_mode;
+	unsigned int bpc;
+	unsigned int width_mm;
+	unsigned int height_mm;
+
+	unsigned int delay_t1;
+	unsigned int reset_delay_t2;
+	unsigned int reset_delay_t3;
+	unsigned int reset_delay_t4;
+	unsigned int reset_delay_t5;
+
+	unsigned long mode_flags;
+	enum mipi_dsi_pixel_format format;
+	unsigned int lanes;
+	const struct panel_cmd *on_cmds;
+	const struct panel_cmd *off_cmds;
+};
+
+struct panel_info {
+	struct drm_panel base;
+	struct mipi_dsi_device *link;
+	const struct panel_desc *desc;
+
+	struct backlight_device *backlight;
+	struct gpio_desc *enable_gpio;
+	struct gpio_desc *pp33_gpio;
+	struct gpio_desc *pp18_gpio;
+
+	bool prepared;
+	bool enabled;
+};
+
+static inline struct panel_info *to_panel_info(struct drm_panel *panel)
+{
+	return container_of(panel, struct panel_info, base);
+}
+
+static void set_gpios(struct panel_info *pinfo, int enable)
+{
+	gpiod_set_value(pinfo->enable_gpio, enable);
+	gpiod_set_value(pinfo->pp33_gpio, enable);
+	gpiod_set_value(pinfo->pp18_gpio, enable);
+}
+
+static int send_mipi_cmds(struct drm_panel *panel, const struct panel_cmd *cmds)
+{
+	struct panel_info *pinfo = to_panel_info(panel);
+	unsigned int i = 0;
+	int err;
+
+	if (!cmds)
+		return -EFAULT;
+
+	for (i = 0; cmds[i].len != 0; i++) {
+		const struct panel_cmd *cmd = &cmds[i];
+
+		if (cmd->len == 2)
+			err = mipi_dsi_dcs_write(pinfo->link,
+						    cmd->data[1], NULL, 0);
+		else
+			err = mipi_dsi_dcs_write(pinfo->link,
+						    cmd->data[1], cmd->data + 2,
+						    cmd->len - 2);
+
+		if (err < 0)
+			return err;
+
+		usleep_range((cmd->data[0]) * 1000,
+			    (1 + cmd->data[0]) * 1000);
+	}
+
+	return 0;
+}
+
+static int boe_panel_disable(struct drm_panel *panel)
+{
+	struct panel_info *pinfo = to_panel_info(panel);
+
+	backlight_disable(pinfo->backlight);
+
+	pinfo->enabled = false;
+
+	return 0;
+}
+
+static int boe_panel_unprepare(struct drm_panel *panel)
+{
+	struct panel_info *pinfo = to_panel_info(panel);
+	int err;
+
+	if (!pinfo->prepared)
+		return 0;
+
+	/* send off code */
+	err = send_mipi_cmds(panel, pinfo->desc->off_cmds);
+	if (err < 0) {
+		DRM_DEV_ERROR(panel->dev,
+				"failed to send DCS Off Code: %d\n", err);
+		goto poweroff;
+	}
+
+	set_gpios(pinfo, 0);
+
+	pinfo->prepared = false;
+
+	return 0;
+
+poweroff:
+	set_gpios(pinfo, 0);
+	return err;
+}
+
+static int boe_panel_prepare(struct drm_panel *panel)
+{
+	struct panel_info *pinfo = to_panel_info(panel);
+	const struct panel_desc *desc = pinfo->desc;
+	int err;
+
+	if (pinfo->prepared)
+		return 0;
+
+	gpiod_set_value(pinfo->pp18_gpio, 1);
+	/* T1 (> 5ms) */
+	usleep_range(desc->delay_t1, 1000 + desc->delay_t1);
+	gpiod_set_value(pinfo->pp33_gpio, 1);
+
+	/* reset sequence */
+	usleep_range(desc->reset_delay_t2, 1000 + desc->reset_delay_t2);
+
+	gpiod_set_value(pinfo->enable_gpio, 1);
+	usleep_range(desc->reset_delay_t3, 1000 + desc->reset_delay_t3);
+	gpiod_set_value(pinfo->enable_gpio, 0);
+
+	usleep_range(desc->reset_delay_t4, 1000 + desc->reset_delay_t4);
+	gpiod_set_value(pinfo->enable_gpio, 1);
+
+	usleep_range(desc->reset_delay_t5, 1000 + desc->reset_delay_t5);
+
+	/* send init code */
+	err = send_mipi_cmds(panel, pinfo->desc->on_cmds);
+	if (err < 0) {
+		DRM_DEV_ERROR(panel->dev,
+				"failed to send DCS Init Code: %d\n", err);
+		goto poweroff;
+	}
+
+	pinfo->prepared = true;
+
+	return 0;
+
+poweroff:
+	set_gpios(pinfo, 0);
+	return err;
+}
+
+static int boe_panel_enable(struct drm_panel *panel)
+{
+	struct panel_info *pinfo = to_panel_info(panel);
+	int ret;
+
+	if (pinfo->enabled)
+		return 0;
+
+	ret = backlight_enable(pinfo->backlight);
+	if (ret) {
+		DRM_DEV_ERROR(panel->drm->dev,
+				"Failed to enable backlight %d\n", ret);
+		return ret;
+	}
+
+	pinfo->enabled = true;
+
+	return 0;
+}
+
+static int boe_panel_get_modes(struct drm_panel *panel)
+{
+	struct panel_info *pinfo = to_panel_info(panel);
+	const struct drm_display_mode *m = pinfo->desc->display_mode;
+	struct drm_display_mode *mode;
+
+	mode = drm_mode_duplicate(panel->drm, m);
+	if (!mode) {
+		DRM_DEV_ERROR(panel->drm->dev, "failed to add mode %ux%u@%u\n",
+				m->hdisplay, m->vdisplay, m->vrefresh);
+		return -ENOMEM;
+	}
+
+	drm_mode_set_name(mode);
+
+	drm_mode_probed_add(panel->connector, mode);
+
+	panel->connector->display_info.width_mm = pinfo->desc->width_mm;
+	panel->connector->display_info.height_mm = pinfo->desc->height_mm;
+	panel->connector->display_info.bpc = pinfo->desc->bpc;
+
+	return 1;
+}
+
+static const struct drm_panel_funcs panel_funcs = {
+	.disable = boe_panel_disable,
+	.unprepare = boe_panel_unprepare,
+	.prepare = boe_panel_prepare,
+	.enable = boe_panel_enable,
+	.get_modes = boe_panel_get_modes,
+};
+
+static const struct drm_display_mode default_display_mode = {
+	.clock = 159420,
+	.hdisplay = 1200,
+	.hsync_start = 1200 + 80,
+	.hsync_end = 1200 + 80 + 60,
+	.htotal = 1200 + 80 + 60 + 24,
+	.vdisplay = 1920,
+	.vsync_start = 1920 + 10,
+	.vsync_end = 1920 + 10 + 14,
+	.vtotal = 1920 + 10 + 14 + 4,
+	.vrefresh = 60,
+};
+
+static const struct panel_cmd default_off_cmds[] = {
+	_INIT_CMD(0x00, 0x28),
+	_INIT_CMD(0x01, 0x10),
+
+	{},
+};
+
+/* 8 inch */
+static const struct panel_cmd boe_himax8279d8p_on_cmds[] = {
+	_INIT_CMD(0x22, 0x10),
+	_INIT_CMD(0x00, 0xB0, 0x05),
+	_INIT_CMD(0x00, 0xB1, 0xE5),
+	_INIT_CMD(0x00, 0xB3, 0x52),
+	_INIT_CMD(0x00, 0xB0, 0x00),
+	_INIT_CMD(0x00, 0xB3, 0x88),
+	_INIT_CMD(0x00, 0xB0, 0x04),
+	_INIT_CMD(0x00, 0xB8, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x00),
+	_INIT_CMD(0x00, 0xB2, 0x50),
+	_INIT_CMD(0x00, 0xB6, 0x03),
+	_INIT_CMD(0x00, 0xBA, 0x8B),
+	_INIT_CMD(0x00, 0xBF, 0x15),
+	_INIT_CMD(0x00, 0xC0, 0x0F),
+	_INIT_CMD(0x00, 0xC2, 0x0C),
+	_INIT_CMD(0x00, 0xC3, 0x02),
+	_INIT_CMD(0x00, 0xC4, 0x0C),
+	_INIT_CMD(0x00, 0xC5, 0x02),
+	_INIT_CMD(0x00, 0xB0, 0x01),
+	_INIT_CMD(0x00, 0xE0, 0x26),
+	_INIT_CMD(0x00, 0xE1, 0x26),
+	_INIT_CMD(0x00, 0xDC, 0x00),
+	_INIT_CMD(0x00, 0xDD, 0x00),
+	_INIT_CMD(0x00, 0xCC, 0x26),
+	_INIT_CMD(0x00, 0xCD, 0x26),
+	_INIT_CMD(0x00, 0xC8, 0x00),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xD2, 0x04),
+	_INIT_CMD(0x00, 0xD3, 0x04),
+	_INIT_CMD(0x00, 0xE6, 0x03),
+	_INIT_CMD(0x00, 0xE7, 0x03),
+	_INIT_CMD(0x00, 0xC4, 0x08),
+	_INIT_CMD(0x00, 0xC5, 0x08),
+	_INIT_CMD(0x00, 0xD8, 0x07),
+	_INIT_CMD(0x00, 0xD9, 0x07),
+	_INIT_CMD(0x00, 0xC2, 0x06),
+	_INIT_CMD(0x00, 0xC3, 0x06),
+	_INIT_CMD(0x00, 0xD6, 0x05),
+	_INIT_CMD(0x00, 0xD7, 0x05),
+	_INIT_CMD(0x00, 0xC0, 0x0C),
+	_INIT_CMD(0x00, 0xC1, 0x0C),
+	_INIT_CMD(0x00, 0xD4, 0x0B),
+	_INIT_CMD(0x00, 0xD5, 0x0B),
+	_INIT_CMD(0x00, 0xCA, 0x0A),
+	_INIT_CMD(0x00, 0xCB, 0x0A),
+	_INIT_CMD(0x00, 0xDE, 0x09),
+	_INIT_CMD(0x00, 0xDF, 0x09),
+	_INIT_CMD(0x00, 0xC6, 0x26),
+	_INIT_CMD(0x00, 0xC7, 0x26),
+	_INIT_CMD(0x00, 0xCE, 0x00),
+	_INIT_CMD(0x00, 0xCF, 0x00),
+	_INIT_CMD(0x00, 0xDA, 0x26),
+	_INIT_CMD(0x00, 0xDB, 0x26),
+	_INIT_CMD(0x00, 0xE2, 0x00),
+	_INIT_CMD(0x00, 0xE3, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x02),
+	_INIT_CMD(0x00, 0xC0, 0x00),
+	_INIT_CMD(0x00, 0xC1, 0x07),
+	_INIT_CMD(0x00, 0xC2, 0x0D),
+	_INIT_CMD(0x00, 0xC3, 0x18),
+	_INIT_CMD(0x00, 0xC4, 0x27),
+	_INIT_CMD(0x00, 0xC5, 0x28),
+	_INIT_CMD(0x00, 0xC6, 0x30),
+	_INIT_CMD(0x00, 0xC7, 0x2E),
+	_INIT_CMD(0x00, 0xC8, 0x2F),
+	_INIT_CMD(0x00, 0xC9, 0x1A),
+	_INIT_CMD(0x00, 0xCA, 0x20),
+	_INIT_CMD(0x00, 0xCB, 0x29),
+	_INIT_CMD(0x00, 0xCC, 0x26),
+	_INIT_CMD(0x00, 0xCD, 0x32),
+	_INIT_CMD(0x00, 0xCE, 0x33),
+	_INIT_CMD(0x00, 0xCF, 0x31),
+	_INIT_CMD(0x00, 0xD0, 0x06),
+	_INIT_CMD(0x00, 0xD2, 0x00),
+	_INIT_CMD(0x00, 0xD3, 0x07),
+	_INIT_CMD(0x00, 0xD4, 0x12),
+	_INIT_CMD(0x00, 0xD5, 0x26),
+	_INIT_CMD(0x00, 0xD6, 0x3D),
+	_INIT_CMD(0x00, 0xD7, 0x3F),
+	_INIT_CMD(0x00, 0xD8, 0x3F),
+	_INIT_CMD(0x00, 0xD9, 0x3F),
+	_INIT_CMD(0x00, 0xDA, 0x3F),
+	_INIT_CMD(0x00, 0xDB, 0x3F),
+	_INIT_CMD(0x00, 0xDC, 0x3F),
+	_INIT_CMD(0x00, 0xDD, 0x3F),
+	_INIT_CMD(0x00, 0xDE, 0x3F),
+	_INIT_CMD(0x00, 0xDF, 0x3A),
+	_INIT_CMD(0x00, 0xE0, 0x37),
+	_INIT_CMD(0x00, 0xE1, 0x35),
+	_INIT_CMD(0x00, 0xE2, 0x07),
+	_INIT_CMD(0x00, 0xB0, 0x03),
+	_INIT_CMD(0x00, 0xC8, 0x0B),
+	_INIT_CMD(0x00, 0xC9, 0x07),
+	_INIT_CMD(0x00, 0xC3, 0x00),
+	_INIT_CMD(0x00, 0xE7, 0x00),
+	_INIT_CMD(0x00, 0xC5, 0x2A),
+	_INIT_CMD(0x00, 0xDE, 0x2A),
+	_INIT_CMD(0x00, 0xCA, 0x43),
+	_INIT_CMD(0x00, 0xC9, 0x07),
+	_INIT_CMD(0x00, 0xE4, 0xC0),
+	_INIT_CMD(0x00, 0xE5, 0x0D),
+	_INIT_CMD(0x00, 0xCB, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x06),
+	_INIT_CMD(0x00, 0xB8, 0xA5),
+	_INIT_CMD(0x00, 0xC0, 0xA5),
+	_INIT_CMD(0x00, 0xC7, 0x0F),
+	_INIT_CMD(0x00, 0xD5, 0x32),
+	_INIT_CMD(0x00, 0xB8, 0x00),
+	_INIT_CMD(0x00, 0xC0, 0x00),
+	_INIT_CMD(0x00, 0xBC, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x07),
+	_INIT_CMD(0x00, 0xB1, 0x00),
+	_INIT_CMD(0x00, 0xB2, 0x09),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x2F),
+	_INIT_CMD(0x00, 0xB5, 0x44),
+	_INIT_CMD(0x00, 0xB6, 0x52),
+	_INIT_CMD(0x00, 0xB7, 0x6A),
+	_INIT_CMD(0x00, 0xB8, 0x8A),
+	_INIT_CMD(0x00, 0xB9, 0xCA),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x05, 0xBB, 0x87),
+	_INIT_CMD(0x00, 0xBC, 0x06),
+	_INIT_CMD(0x00, 0xBD, 0x0A),
+	_INIT_CMD(0x00, 0xBE, 0x9B),
+	_INIT_CMD(0x00, 0xBF, 0x0C),
+	_INIT_CMD(0x00, 0xC0, 0x3D),
+	_INIT_CMD(0x00, 0xC1, 0x71),
+	_INIT_CMD(0x00, 0xC2, 0x90),
+	_INIT_CMD(0x00, 0xC3, 0xA0),
+	_INIT_CMD(0x00, 0xC4, 0xA8),
+	_INIT_CMD(0x00, 0xC5, 0xB1),
+	_INIT_CMD(0x00, 0xC6, 0xBB),
+	_INIT_CMD(0x00, 0xC7, 0xC0),
+	_INIT_CMD(0x00, 0xC8, 0xC4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x08),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x08),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x31),
+	_INIT_CMD(0x00, 0xB5, 0x46),
+	_INIT_CMD(0x00, 0xB6, 0x55),
+	_INIT_CMD(0x00, 0xB7, 0x6E),
+	_INIT_CMD(0x00, 0xB8, 0x92),
+	_INIT_CMD(0x00, 0xB9, 0xD4),
+	_INIT_CMD(0x00, 0xBA, 0x1B),
+	_INIT_CMD(0x05, 0xBB, 0x9B),
+	_INIT_CMD(0x00, 0xBC, 0x28),
+	_INIT_CMD(0x00, 0xBD, 0x2D),
+	_INIT_CMD(0x00, 0xBE, 0xC3),
+	_INIT_CMD(0x00, 0xBF, 0x2F),
+	_INIT_CMD(0x00, 0xC0, 0x62),
+	_INIT_CMD(0x00, 0xC1, 0x99),
+	_INIT_CMD(0x00, 0xC2, 0xAB),
+	_INIT_CMD(0x00, 0xC3, 0xBF),
+	_INIT_CMD(0x00, 0xC4, 0xCF),
+	_INIT_CMD(0x00, 0xC5, 0xDF),
+	_INIT_CMD(0x00, 0xC6, 0xF0),
+	_INIT_CMD(0x00, 0xC7, 0xF9),
+	_INIT_CMD(0x00, 0xC8, 0xFC),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x09),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x05),
+	_INIT_CMD(0x00, 0xB3, 0x17),
+	_INIT_CMD(0x00, 0xB4, 0x2E),
+	_INIT_CMD(0x00, 0xB5, 0x42),
+	_INIT_CMD(0x00, 0xB6, 0x51),
+	_INIT_CMD(0x00, 0xB7, 0x69),
+	_INIT_CMD(0x00, 0xB8, 0x88),
+	_INIT_CMD(0x00, 0xB9, 0xC9),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x05, 0xBB, 0x86),
+	_INIT_CMD(0x00, 0xBC, 0x03),
+	_INIT_CMD(0x00, 0xBD, 0x08),
+	_INIT_CMD(0x00, 0xBE, 0x95),
+	_INIT_CMD(0x00, 0xBF, 0x05),
+	_INIT_CMD(0x00, 0xC0, 0x35),
+	_INIT_CMD(0x00, 0xC1, 0x62),
+	_INIT_CMD(0x00, 0xC2, 0x81),
+	_INIT_CMD(0x00, 0xC3, 0x96),
+	_INIT_CMD(0x00, 0xC4, 0x9E),
+	_INIT_CMD(0x00, 0xC5, 0xA5),
+	_INIT_CMD(0x00, 0xC6, 0xAD),
+	_INIT_CMD(0x00, 0xC7, 0xB1),
+	_INIT_CMD(0x00, 0xC8, 0xB4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x0A),
+	_INIT_CMD(0x00, 0xB1, 0x00),
+	_INIT_CMD(0x00, 0xB2, 0x09),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x2F),
+	_INIT_CMD(0x00, 0xB5, 0x44),
+	_INIT_CMD(0x00, 0xB6, 0x52),
+	_INIT_CMD(0x00, 0xB7, 0x6A),
+	_INIT_CMD(0x00, 0xB8, 0x8A),
+	_INIT_CMD(0x00, 0xB9, 0xCA),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x05, 0xBB, 0x87),
+	_INIT_CMD(0x00, 0xBC, 0x06),
+	_INIT_CMD(0x00, 0xBD, 0x0A),
+	_INIT_CMD(0x00, 0xBE, 0x9B),
+	_INIT_CMD(0x00, 0xBF, 0x0C),
+	_INIT_CMD(0x00, 0xC0, 0x3D),
+	_INIT_CMD(0x00, 0xC1, 0x71),
+	_INIT_CMD(0x00, 0xC2, 0x90),
+	_INIT_CMD(0x00, 0xC3, 0xA0),
+	_INIT_CMD(0x00, 0xC4, 0xA8),
+	_INIT_CMD(0x00, 0xC5, 0xB1),
+	_INIT_CMD(0x00, 0xC6, 0xBB),
+	_INIT_CMD(0x00, 0xC7, 0xC0),
+	_INIT_CMD(0x00, 0xC8, 0xC4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x0B),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x08),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x31),
+	_INIT_CMD(0x00, 0xB5, 0x46),
+	_INIT_CMD(0x00, 0xB6, 0x55),
+	_INIT_CMD(0x00, 0xB7, 0x6E),
+	_INIT_CMD(0x00, 0xB8, 0x92),
+	_INIT_CMD(0x00, 0xB9, 0xD4),
+	_INIT_CMD(0x00, 0xBA, 0x1B),
+	_INIT_CMD(0x05, 0xBB, 0x9B),
+	_INIT_CMD(0x00, 0xBC, 0x28),
+	_INIT_CMD(0x00, 0xBD, 0x2D),
+	_INIT_CMD(0x00, 0xBE, 0xC3),
+	_INIT_CMD(0x00, 0xBF, 0x2F),
+	_INIT_CMD(0x00, 0xC0, 0x62),
+	_INIT_CMD(0x00, 0xC1, 0x99),
+	_INIT_CMD(0x00, 0xC2, 0xAB),
+	_INIT_CMD(0x00, 0xC3, 0xBF),
+	_INIT_CMD(0x00, 0xC4, 0xCF),
+	_INIT_CMD(0x00, 0xC5, 0xDF),
+	_INIT_CMD(0x00, 0xC6, 0xF0),
+	_INIT_CMD(0x00, 0xC7, 0xF9),
+	_INIT_CMD(0x00, 0xC8, 0xFC),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x0C),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x05),
+	_INIT_CMD(0x00, 0xB3, 0x17),
+	_INIT_CMD(0x00, 0xB4, 0x2E),
+	_INIT_CMD(0x00, 0xB5, 0x42),
+	_INIT_CMD(0x00, 0xB6, 0x51),
+	_INIT_CMD(0x00, 0xB7, 0x69),
+	_INIT_CMD(0x00, 0xB8, 0x88),
+	_INIT_CMD(0x00, 0xB9, 0xC9),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x05, 0xBB, 0x86),
+	_INIT_CMD(0x00, 0xBC, 0x03),
+	_INIT_CMD(0x00, 0xBD, 0x08),
+	_INIT_CMD(0x00, 0xBE, 0x95),
+	_INIT_CMD(0x00, 0xBF, 0x05),
+	_INIT_CMD(0x00, 0xC0, 0x35),
+	_INIT_CMD(0x00, 0xC1, 0x62),
+	_INIT_CMD(0x00, 0xC2, 0x81),
+	_INIT_CMD(0x00, 0xC3, 0x96),
+	_INIT_CMD(0x00, 0xC4, 0x9E),
+	_INIT_CMD(0x00, 0xC5, 0xA5),
+	_INIT_CMD(0x00, 0xC6, 0xAD),
+	_INIT_CMD(0x00, 0xC7, 0xB1),
+	_INIT_CMD(0x00, 0xC8, 0xB4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x64, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x00),
+	_INIT_CMD(0x00, 0xB3, 0x08),
+	_INIT_CMD(0x00, 0xB0, 0x04),
+	_INIT_CMD(0x0A, 0xB8, 0x68),
+	_INIT_CMD(0x78, 0x11),
+	_INIT_CMD(0x14, 0x29),
+
+	{},
+};
+
+static const struct panel_desc boe_himax8279d8p_panel_desc = {
+	.display_mode = &default_display_mode,
+	.bpc = 8,
+	.width_mm = 107,
+	.height_mm = 172,
+	.delay_t1 = 5000,
+	.reset_delay_t2 = 14000,
+	.reset_delay_t3 = 1000,
+	.reset_delay_t4 = 1000,
+	.reset_delay_t5 = 5000,
+	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
+			MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
+	.format = MIPI_DSI_FMT_RGB888,
+	.lanes = 4,
+	.on_cmds = boe_himax8279d8p_on_cmds,
+	.off_cmds = default_off_cmds,
+};
+
+/* 10 inch */
+static const struct panel_cmd boe_himax8279d10p_on_cmds[] = {
+	_INIT_CMD(0x00, 0xB0, 0x05),
+	_INIT_CMD(0x00, 0xB1, 0xE5),
+	_INIT_CMD(0x00, 0xB3, 0x52),
+	_INIT_CMD(0x00, 0xB0, 0x00),
+	_INIT_CMD(0x00, 0xB3, 0x88),
+	_INIT_CMD(0x00, 0xB0, 0x04),
+	_INIT_CMD(0x00, 0xB8, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x00),
+	_INIT_CMD(0x00, 0xB2, 0x50),
+	_INIT_CMD(0x00, 0xB6, 0x03),
+	_INIT_CMD(0x00, 0xBA, 0x8B),
+	_INIT_CMD(0x00, 0xBF, 0x1A),
+	_INIT_CMD(0x00, 0xC0, 0x0F),
+	_INIT_CMD(0x00, 0xC2, 0x0C),
+	_INIT_CMD(0x00, 0xC3, 0x02),
+	_INIT_CMD(0x00, 0xC4, 0x0C),
+	_INIT_CMD(0x00, 0xC5, 0x02),
+	_INIT_CMD(0x00, 0xB0, 0x01),
+	_INIT_CMD(0x00, 0xE0, 0x26),
+	_INIT_CMD(0x00, 0xE1, 0x26),
+	_INIT_CMD(0x00, 0xDC, 0x00),
+	_INIT_CMD(0x00, 0xDD, 0x00),
+	_INIT_CMD(0x00, 0xCC, 0x26),
+	_INIT_CMD(0x00, 0xCD, 0x26),
+	_INIT_CMD(0x00, 0xC8, 0x00),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xD2, 0x04),
+	_INIT_CMD(0x00, 0xD3, 0x04),
+	_INIT_CMD(0x00, 0xE6, 0x03),
+	_INIT_CMD(0x00, 0xE7, 0x03),
+	_INIT_CMD(0x00, 0xC4, 0x08),
+	_INIT_CMD(0x00, 0xC5, 0x08),
+	_INIT_CMD(0x00, 0xD8, 0x07),
+	_INIT_CMD(0x00, 0xD9, 0x07),
+	_INIT_CMD(0x00, 0xC2, 0x06),
+	_INIT_CMD(0x00, 0xC3, 0x06),
+	_INIT_CMD(0x00, 0xD6, 0x05),
+	_INIT_CMD(0x00, 0xD7, 0x05),
+	_INIT_CMD(0x00, 0xC0, 0x0C),
+	_INIT_CMD(0x00, 0xC1, 0x0C),
+	_INIT_CMD(0x00, 0xD4, 0x0B),
+	_INIT_CMD(0x00, 0xD5, 0x0B),
+	_INIT_CMD(0x00, 0xCA, 0x0A),
+	_INIT_CMD(0x00, 0xCB, 0x0A),
+	_INIT_CMD(0x00, 0xDE, 0x09),
+	_INIT_CMD(0x00, 0xDF, 0x09),
+	_INIT_CMD(0x00, 0xC6, 0x26),
+	_INIT_CMD(0x00, 0xC7, 0x26),
+	_INIT_CMD(0x00, 0xCE, 0x00),
+	_INIT_CMD(0x00, 0xCF, 0x00),
+	_INIT_CMD(0x00, 0xDA, 0x26),
+	_INIT_CMD(0x00, 0xDB, 0x26),
+	_INIT_CMD(0x00, 0xE2, 0x00),
+	_INIT_CMD(0x00, 0xE3, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x02),
+	_INIT_CMD(0x00, 0xC0, 0x00),
+	_INIT_CMD(0x00, 0xC1, 0x07),
+	_INIT_CMD(0x00, 0xC2, 0x0D),
+	_INIT_CMD(0x00, 0xC3, 0x18),
+	_INIT_CMD(0x00, 0xC4, 0x27),
+	_INIT_CMD(0x00, 0xC5, 0x28),
+	_INIT_CMD(0x00, 0xC6, 0x30),
+	_INIT_CMD(0x00, 0xC7, 0x2E),
+	_INIT_CMD(0x00, 0xC8, 0x2F),
+	_INIT_CMD(0x00, 0xC9, 0x1A),
+	_INIT_CMD(0x00, 0xCA, 0x20),
+	_INIT_CMD(0x00, 0xCB, 0x29),
+	_INIT_CMD(0x00, 0xCC, 0x26),
+	_INIT_CMD(0x00, 0xCD, 0x32),
+	_INIT_CMD(0x00, 0xCE, 0x33),
+	_INIT_CMD(0x00, 0xCF, 0x31),
+	_INIT_CMD(0x00, 0xD0, 0x06),
+	_INIT_CMD(0x00, 0xD2, 0x00),
+	_INIT_CMD(0x00, 0xD3, 0x07),
+	_INIT_CMD(0x00, 0xD4, 0x12),
+	_INIT_CMD(0x00, 0xD5, 0x26),
+	_INIT_CMD(0x00, 0xD6, 0x3D),
+	_INIT_CMD(0x00, 0xD7, 0x3F),
+	_INIT_CMD(0x00, 0xD8, 0x3F),
+	_INIT_CMD(0x00, 0xD9, 0x3F),
+	_INIT_CMD(0x00, 0xDA, 0x3F),
+	_INIT_CMD(0x00, 0xDB, 0x3F),
+	_INIT_CMD(0x00, 0xDC, 0x3F),
+	_INIT_CMD(0x00, 0xDD, 0x3F),
+	_INIT_CMD(0x00, 0xDE, 0x3F),
+	_INIT_CMD(0x00, 0xDF, 0x3A),
+	_INIT_CMD(0x00, 0xE0, 0x37),
+	_INIT_CMD(0x00, 0xE1, 0x35),
+	_INIT_CMD(0x00, 0xE2, 0x07),
+	_INIT_CMD(0x00, 0xB0, 0x03),
+	_INIT_CMD(0x00, 0xC8, 0x0B),
+	_INIT_CMD(0x00, 0xC9, 0x07),
+	_INIT_CMD(0x00, 0xC3, 0x00),
+	_INIT_CMD(0x00, 0xE7, 0x00),
+	_INIT_CMD(0x00, 0xC5, 0x2A),
+	_INIT_CMD(0x00, 0xDE, 0x2A),
+	_INIT_CMD(0x00, 0xCA, 0x43),
+	_INIT_CMD(0x00, 0xC9, 0x07),
+	_INIT_CMD(0x00, 0xE4, 0xC0),
+	_INIT_CMD(0x00, 0xE5, 0x0D),
+	_INIT_CMD(0x00, 0xCB, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x06),
+	_INIT_CMD(0x00, 0xB8, 0xA5),
+	_INIT_CMD(0x00, 0xC0, 0xA5),
+	_INIT_CMD(0x00, 0xC7, 0x0F),
+	_INIT_CMD(0x00, 0xD5, 0x32),
+	_INIT_CMD(0x00, 0xB8, 0x00),
+	_INIT_CMD(0x00, 0xC0, 0x00),
+	_INIT_CMD(0x00, 0xBC, 0x00),
+	_INIT_CMD(0x00, 0xB0, 0x07),
+	_INIT_CMD(0x00, 0xB1, 0x00),
+	_INIT_CMD(0x00, 0xB2, 0x09),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x2F),
+	_INIT_CMD(0x00, 0xB5, 0x44),
+	_INIT_CMD(0x00, 0xB6, 0x52),
+	_INIT_CMD(0x00, 0xB7, 0x6A),
+	_INIT_CMD(0x00, 0xB8, 0x8A),
+	_INIT_CMD(0x00, 0xB9, 0xCA),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x00, 0xBB, 0x87),
+	_INIT_CMD(0x00, 0xBC, 0x06),
+	_INIT_CMD(0x00, 0xBD, 0x0A),
+	_INIT_CMD(0x00, 0xBE, 0x9B),
+	_INIT_CMD(0x00, 0xBF, 0x0C),
+	_INIT_CMD(0x00, 0xC0, 0x3D),
+	_INIT_CMD(0x00, 0xC1, 0x71),
+	_INIT_CMD(0x00, 0xC2, 0x90),
+	_INIT_CMD(0x00, 0xC3, 0xA0),
+	_INIT_CMD(0x00, 0xC4, 0xA8),
+	_INIT_CMD(0x00, 0xC5, 0xB1),
+	_INIT_CMD(0x00, 0xC6, 0xBB),
+	_INIT_CMD(0x00, 0xC7, 0xC0),
+	_INIT_CMD(0x00, 0xC8, 0xC4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x08),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x08),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x31),
+	_INIT_CMD(0x00, 0xB5, 0x46),
+	_INIT_CMD(0x00, 0xB6, 0x55),
+	_INIT_CMD(0x00, 0xB7, 0x6E),
+	_INIT_CMD(0x00, 0xB8, 0x92),
+	_INIT_CMD(0x00, 0xB9, 0xD4),
+	_INIT_CMD(0x00, 0xBA, 0x1B),
+	_INIT_CMD(0x00, 0xBB, 0x9B),
+	_INIT_CMD(0x00, 0xBC, 0x28),
+	_INIT_CMD(0x00, 0xBD, 0x2D),
+	_INIT_CMD(0x00, 0xBE, 0xC3),
+	_INIT_CMD(0x00, 0xBF, 0x2F),
+	_INIT_CMD(0x00, 0xC0, 0x62),
+	_INIT_CMD(0x00, 0xC1, 0x99),
+	_INIT_CMD(0x00, 0xC2, 0xAB),
+	_INIT_CMD(0x00, 0xC3, 0xBF),
+	_INIT_CMD(0x00, 0xC4, 0xCF),
+	_INIT_CMD(0x00, 0xC5, 0xDF),
+	_INIT_CMD(0x00, 0xC6, 0xF0),
+	_INIT_CMD(0x00, 0xC7, 0xF9),
+	_INIT_CMD(0x00, 0xC8, 0xFC),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x09),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x05),
+	_INIT_CMD(0x00, 0xB3, 0x17),
+	_INIT_CMD(0x00, 0xB4, 0x2E),
+	_INIT_CMD(0x00, 0xB5, 0x42),
+	_INIT_CMD(0x00, 0xB6, 0x51),
+	_INIT_CMD(0x00, 0xB7, 0x69),
+	_INIT_CMD(0x00, 0xB8, 0x88),
+	_INIT_CMD(0x00, 0xB9, 0xC9),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x00, 0xBB, 0x86),
+	_INIT_CMD(0x00, 0xBC, 0x03),
+	_INIT_CMD(0x00, 0xBD, 0x08),
+	_INIT_CMD(0x00, 0xBE, 0x95),
+	_INIT_CMD(0x00, 0xBF, 0x05),
+	_INIT_CMD(0x00, 0xC0, 0x35),
+	_INIT_CMD(0x00, 0xC1, 0x62),
+	_INIT_CMD(0x00, 0xC2, 0x81),
+	_INIT_CMD(0x00, 0xC3, 0x96),
+	_INIT_CMD(0x00, 0xC4, 0x9E),
+	_INIT_CMD(0x00, 0xC5, 0xA5),
+	_INIT_CMD(0x00, 0xC6, 0xAD),
+	_INIT_CMD(0x00, 0xC7, 0xB1),
+	_INIT_CMD(0x00, 0xC8, 0xB4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x0A),
+	_INIT_CMD(0x00, 0xB1, 0x00),
+	_INIT_CMD(0x00, 0xB2, 0x09),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x2F),
+	_INIT_CMD(0x00, 0xB5, 0x44),
+	_INIT_CMD(0x00, 0xB6, 0x52),
+	_INIT_CMD(0x00, 0xB7, 0x6A),
+	_INIT_CMD(0x00, 0xB8, 0x8A),
+	_INIT_CMD(0x00, 0xB9, 0xCA),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x00, 0xBB, 0x87),
+	_INIT_CMD(0x00, 0xBC, 0x06),
+	_INIT_CMD(0x00, 0xBD, 0x0A),
+	_INIT_CMD(0x00, 0xBE, 0x9B),
+	_INIT_CMD(0x00, 0xBF, 0x0C),
+	_INIT_CMD(0x00, 0xC0, 0x3D),
+	_INIT_CMD(0x00, 0xC1, 0x71),
+	_INIT_CMD(0x00, 0xC2, 0x90),
+	_INIT_CMD(0x00, 0xC3, 0xA0),
+	_INIT_CMD(0x00, 0xC4, 0xA8),
+	_INIT_CMD(0x00, 0xC5, 0xB1),
+	_INIT_CMD(0x00, 0xC6, 0xBB),
+	_INIT_CMD(0x00, 0xC7, 0xC0),
+	_INIT_CMD(0x00, 0xC8, 0xC4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x0B),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x08),
+	_INIT_CMD(0x00, 0xB3, 0x19),
+	_INIT_CMD(0x00, 0xB4, 0x31),
+	_INIT_CMD(0x00, 0xB5, 0x46),
+	_INIT_CMD(0x00, 0xB6, 0x55),
+	_INIT_CMD(0x00, 0xB7, 0x6E),
+	_INIT_CMD(0x00, 0xB8, 0x92),
+	_INIT_CMD(0x00, 0xB9, 0xD4),
+	_INIT_CMD(0x00, 0xBA, 0x1B),
+	_INIT_CMD(0x00, 0xBB, 0x9B),
+	_INIT_CMD(0x00, 0xBC, 0x28),
+	_INIT_CMD(0x00, 0xBD, 0x2D),
+	_INIT_CMD(0x00, 0xBE, 0xC3),
+	_INIT_CMD(0x00, 0xBF, 0x2F),
+	_INIT_CMD(0x00, 0xC0, 0x62),
+	_INIT_CMD(0x00, 0xC1, 0x99),
+	_INIT_CMD(0x00, 0xC2, 0xAB),
+	_INIT_CMD(0x00, 0xC3, 0xBF),
+	_INIT_CMD(0x00, 0xC4, 0xCF),
+	_INIT_CMD(0x00, 0xC5, 0xDF),
+	_INIT_CMD(0x00, 0xC6, 0xF0),
+	_INIT_CMD(0x00, 0xC7, 0xF9),
+	_INIT_CMD(0x00, 0xC8, 0xFC),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x0C),
+	_INIT_CMD(0x00, 0xB1, 0x04),
+	_INIT_CMD(0x00, 0xB2, 0x05),
+	_INIT_CMD(0x00, 0xB3, 0x17),
+	_INIT_CMD(0x00, 0xB4, 0x2E),
+	_INIT_CMD(0x00, 0xB5, 0x42),
+	_INIT_CMD(0x00, 0xB6, 0x51),
+	_INIT_CMD(0x00, 0xB7, 0x69),
+	_INIT_CMD(0x00, 0xB8, 0x88),
+	_INIT_CMD(0x00, 0xB9, 0xC9),
+	_INIT_CMD(0x00, 0xBA, 0x0C),
+	_INIT_CMD(0x00, 0xBB, 0x86),
+	_INIT_CMD(0x00, 0xBC, 0x03),
+	_INIT_CMD(0x00, 0xBD, 0x08),
+	_INIT_CMD(0x00, 0xBE, 0x95),
+	_INIT_CMD(0x00, 0xBF, 0x05),
+	_INIT_CMD(0x00, 0xC0, 0x35),
+	_INIT_CMD(0x00, 0xC1, 0x62),
+	_INIT_CMD(0x00, 0xC2, 0x81),
+	_INIT_CMD(0x00, 0xC3, 0x96),
+	_INIT_CMD(0x00, 0xC4, 0x9E),
+	_INIT_CMD(0x00, 0xC5, 0xA5),
+	_INIT_CMD(0x00, 0xC6, 0xAD),
+	_INIT_CMD(0x00, 0xC7, 0xB1),
+	_INIT_CMD(0x00, 0xC8, 0xB4),
+	_INIT_CMD(0x00, 0xC9, 0x00),
+	_INIT_CMD(0x00, 0xCA, 0x00),
+	_INIT_CMD(0x00, 0xCB, 0x16),
+	_INIT_CMD(0x00, 0xCC, 0xAF),
+	_INIT_CMD(0x00, 0xCD, 0xFF),
+	_INIT_CMD(0x00, 0xCE, 0xFF),
+	_INIT_CMD(0x00, 0xB0, 0x00),
+	_INIT_CMD(0x00, 0xB3, 0x08),
+	_INIT_CMD(0x00, 0xB0, 0x04),
+	_INIT_CMD(0x64, 0xB8, 0x68),
+
+	{},
+};
+
+static const struct panel_desc boe_himax8279d10p_panel_desc = {
+	.display_mode = &default_display_mode,
+	.bpc = 8,
+	.width_mm = 135,
+	.height_mm = 216,
+	.delay_t1 = 5000,
+	.reset_delay_t2 = 14000,
+	.reset_delay_t3 = 1000,
+	.reset_delay_t4 = 1000,
+	.reset_delay_t5 = 5000,
+	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
+			MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
+	.format = MIPI_DSI_FMT_RGB888,
+	.lanes = 4,
+	.on_cmds = boe_himax8279d10p_on_cmds,
+	.off_cmds = default_off_cmds,
+};
+
+static const struct of_device_id panel_of_match[] = {
+	{ .compatible = "boe,himax8279d8p",
+	  .data = &boe_himax8279d8p_panel_desc
+	}, { .compatible = "boe,himax8279d10p",
+	  .data = &boe_himax8279d10p_panel_desc
+	}, {
+		/* sentinel */
+	}
+};
+MODULE_DEVICE_TABLE(of, panel_of_match);
+
+static int panel_add(struct panel_info *pinfo)
+{
+	struct device *dev = &pinfo->link->dev;
+	int ret;
+
+	pinfo->pp18_gpio = devm_gpiod_get_optional(dev, "pp18", GPIOD_OUT_HIGH);
+	if (IS_ERR(pinfo->pp18_gpio)) {
+		ret = PTR_ERR(pinfo->pp18_gpio);
+		if (ret != -EPROBE_DEFER)
+			DRM_DEV_ERROR(dev, "failed to get pp18 gpio: %d\n",
+					ret);
+		return ret;
+	}
+
+	pinfo->pp33_gpio = devm_gpiod_get_optional(dev, "pp33", GPIOD_OUT_HIGH);
+	if (IS_ERR(pinfo->pp33_gpio)) {
+		ret = PTR_ERR(pinfo->pp33_gpio);
+		if (ret != -EPROBE_DEFER)
+			DRM_DEV_ERROR(dev, "failed to get pp33 gpio: %d\n",
+					ret);
+		return ret;
+	}
+
+	pinfo->enable_gpio = devm_gpiod_get_optional(dev, "enable",
+							GPIOD_OUT_HIGH);
+	if (IS_ERR(pinfo->enable_gpio)) {
+		ret = PTR_ERR(pinfo->enable_gpio);
+		if (ret != -EPROBE_DEFER)
+			DRM_DEV_ERROR(dev, "failed to get enable gpio: %d\n",
+					ret);
+		return ret;
+	}
+
+	pinfo->backlight = devm_of_find_backlight(dev);
+	if (IS_ERR(pinfo->backlight))
+		return PTR_ERR(pinfo->backlight);
+
+	drm_panel_init(&pinfo->base);
+	pinfo->base.funcs = &panel_funcs;
+	pinfo->base.dev = &pinfo->link->dev;
+
+	ret = drm_panel_add(&pinfo->base);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
+static void panel_del(struct panel_info *pinfo)
+{
+	if (pinfo->base.dev)
+		drm_panel_remove(&pinfo->base);
+}
+
+static int panel_probe(struct mipi_dsi_device *dsi)
+{
+	struct panel_info *pinfo;
+	const struct panel_desc *desc;
+	int err;
+
+	pinfo = devm_kzalloc(&dsi->dev, sizeof(*pinfo), GFP_KERNEL);
+	if (!pinfo)
+		return -ENOMEM;
+
+	desc = of_device_get_match_data(&dsi->dev);
+	dsi->mode_flags = desc->mode_flags;
+	dsi->format = desc->format;
+	dsi->lanes = desc->lanes;
+	pinfo->desc = desc;
+
+	pinfo->link = dsi;
+	mipi_dsi_set_drvdata(dsi, pinfo);
+
+	err = panel_add(pinfo);
+	if (err < 0)
+		return err;
+
+	return mipi_dsi_attach(dsi);
+}
+
+static int panel_remove(struct mipi_dsi_device *dsi)
+{
+	struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
+	int err;
+
+	err = boe_panel_unprepare(&pinfo->base);
+	if (err < 0)
+		DRM_DEV_ERROR(&dsi->dev, "failed to unprepare panel: %d\n",
+				err);
+
+	err = boe_panel_disable(&pinfo->base);
+	if (err < 0)
+		DRM_DEV_ERROR(&dsi->dev, "failed to disable panel: %d\n", err);
+
+	err = mipi_dsi_detach(dsi);
+	if (err < 0)
+		DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI host: %d\n",
+				err);
+
+	drm_panel_detach(&pinfo->base);
+	panel_del(pinfo);
+
+	return 0;
+}
+
+static void panel_shutdown(struct mipi_dsi_device *dsi)
+{
+	struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi);
+
+	boe_panel_disable(&pinfo->base);
+	boe_panel_unprepare(&pinfo->base);
+}
+
+static struct mipi_dsi_driver panel_driver = {
+	.driver = {
+		.name = "panel-boe-himax8279d",
+		.of_match_table = panel_of_match,
+	},
+	.probe = panel_probe,
+	.remove = panel_remove,
+	.shutdown = panel_shutdown,
+};
+module_mipi_dsi_driver(panel_driver);
+
+MODULE_AUTHOR("Jerry Han <hanxu5@huaqin.corp-partner.google.com>");
+MODULE_DESCRIPTION("Boe Himax8279d driver");
+MODULE_LICENSE("GPL v2");