diff mbox series

[1/2] dt-bindings: display: tfp410: Add bus-width parameter property

Message ID 20190401124143.17179-2-peter.ujfalusi@ti.com (mailing list archive)
State New, archived
Headers show
Series drm/bridge: ti-tfp410: Handle bus-format for 24/12 lines selection | expand

Commit Message

Peter Ujfalusi April 1, 2019, 12:41 p.m. UTC
tfp410 can be connect to host processor in 24bit, single-edge (24 lines) or
12bit, dual-edge (12 lines).

Add bus-width to the documentation so it can be used to select between the
two connection scheme.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 .../devicetree/bindings/display/bridge/ti,tfp410.txt   | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart April 2, 2019, 11:45 a.m. UTC | #1
Hi Peter,

Thank you for the patch.

On Mon, Apr 01, 2019 at 03:41:42PM +0300, Peter Ujfalusi wrote:
> tfp410 can be connect to host processor in 24bit, single-edge (24 lines) or
> 12bit, dual-edge (12 lines).
> 
> Add bus-width to the documentation so it can be used to select between the
> two connection scheme.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  .../devicetree/bindings/display/bridge/ti,tfp410.txt   | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
> index 3f903af93949..5ff4f64ef8e8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
> @@ -18,7 +18,14 @@ This device has two video ports. Their connections are modeled using the OF
>  graph bindings specified in [1]. Each port node shall have a single endpoint.
>  
>  - Port 0 is the DPI input port. Its endpoint subnode shall contain a
> -  pclk-sample property and a remote-endpoint property as specified in [1].
> +  pclk-sample and bus-width property and a remote-endpoint property as specified
> +  in [1].
> +  - If pclk-sample is not defined, pclk-sample = 0 should be assumed for
> +    backward compatibility.
> +  - If bus-width is not defined then bus-width = 24 should be assumed for
> +    backward compatibility.
> +    bus-width = 24: 24 data lines are connected and single-edge mode
> +    bus-width = 12: 12 data lines are connected and dual-edge mode
>  
>  - Port 1 is the DVI output port. Its endpoint subnode shall contain a
>    remote-endpoint property is specified in [1].
> @@ -43,6 +50,7 @@ tfp410: encoder@0 {
>  
>  			tfp410_in: endpoint@0 {
>  				pclk-sample = <1>;
> +				bus-width = <24>;
>  				remote-endpoint = <&dpi_out>;
>  			};
>  		};
Rob Herring (Arm) April 6, 2019, 6:06 a.m. UTC | #2
On Mon, 1 Apr 2019 15:41:42 +0300, Peter Ujfalusi wrote:
> tfp410 can be connect to host processor in 24bit, single-edge (24 lines) or
> 12bit, dual-edge (12 lines).
> 
> Add bus-width to the documentation so it can be used to select between the
> two connection scheme.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  .../devicetree/bindings/display/bridge/ti,tfp410.txt   | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
index 3f903af93949..5ff4f64ef8e8 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
+++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt
@@ -18,7 +18,14 @@  This device has two video ports. Their connections are modeled using the OF
 graph bindings specified in [1]. Each port node shall have a single endpoint.
 
 - Port 0 is the DPI input port. Its endpoint subnode shall contain a
-  pclk-sample property and a remote-endpoint property as specified in [1].
+  pclk-sample and bus-width property and a remote-endpoint property as specified
+  in [1].
+  - If pclk-sample is not defined, pclk-sample = 0 should be assumed for
+    backward compatibility.
+  - If bus-width is not defined then bus-width = 24 should be assumed for
+    backward compatibility.
+    bus-width = 24: 24 data lines are connected and single-edge mode
+    bus-width = 12: 12 data lines are connected and dual-edge mode
 
 - Port 1 is the DVI output port. Its endpoint subnode shall contain a
   remote-endpoint property is specified in [1].
@@ -43,6 +50,7 @@  tfp410: encoder@0 {
 
 			tfp410_in: endpoint@0 {
 				pclk-sample = <1>;
+				bus-width = <24>;
 				remote-endpoint = <&dpi_out>;
 			};
 		};