| Message ID | 20190423092810.28359-1-jian-hong@endlessm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i915: disable framebuffer compression on GeminiLake | expand |
Quoting Jian-Hong Pan (2019-04-23 10:28:10) > From: Daniel Drake <drake@endlessm.com> > > On many (all?) the Gemini Lake systems we work with, there is frequent > momentary graphical corruption at the top of the screen, and it seems > that disabling framebuffer compression can avoid this. > > The ticket was reported 6 months ago and has already affected a > multitude of users, without any real progress being made. So, lets > disable framebuffer compression on GeminiLake until a solution is found. > > Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=108085 > Signed-off-by: Daniel Drake <drake@endlessm.com> > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ? Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: <stable@vger.kernel.org> # v4.11+ glk landed 1 month before, so that seems the earliest broken point. > --- > drivers/gpu/drm/i915/intel_fbc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > index 656e684e7c9a..fc018f3f53a1 100644 > --- a/drivers/gpu/drm/i915/intel_fbc.c > +++ b/drivers/gpu/drm/i915/intel_fbc.c > @@ -1278,6 +1278,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) > if (!HAS_FBC(dev_priv)) > return 0; > > + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ > + if (IS_GEMINILAKE(dev_priv)) > + return 0; > + > if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) > return 1; > > -- > 2.21.0 >
Em qua, 2019-04-24 às 20:58 +0100, Chris Wilson escreveu: > Quoting Jian-Hong Pan (2019-04-23 10:28:10) > > From: Daniel Drake <drake@endlessm.com> > > > > On many (all?) the Gemini Lake systems we work with, there is frequent > > momentary graphical corruption at the top of the screen, and it seems > > that disabling framebuffer compression can avoid this. > > > > The ticket was reported 6 months ago and has already affected a > > multitude of users, without any real progress being made. So, lets > > disable framebuffer compression on GeminiLake until a solution is found. > > > > Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=108085 > > Signed-off-by: Daniel Drake <drake@endlessm.com> > > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> > > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ? > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: <stable@vger.kernel.org> # v4.11+ > > glk landed 1 month before, so that seems the earliest broken point. > The bug is well reported, the bug author is helpful and it even has a description of "steps to reproduce" that looks very easy (although I didn't try it). Everything suggests this is a bug the display team could actually solve with not-so-many hours of debugging. In the meantime, unbreak the systems: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > > --- > > drivers/gpu/drm/i915/intel_fbc.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c > > index 656e684e7c9a..fc018f3f53a1 100644 > > --- a/drivers/gpu/drm/i915/intel_fbc.c > > +++ b/drivers/gpu/drm/i915/intel_fbc.c > > @@ -1278,6 +1278,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) > > if (!HAS_FBC(dev_priv)) > > return 0; > > > > + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ > > + if (IS_GEMINILAKE(dev_priv)) > > + return 0; > > + > > if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) > > return 1; > > > > -- > > 2.21.0 > >
Hi, On Thu, Apr 25, 2019 at 4:27 AM Paulo Zanoni <paulo.r.zanoni@intel.com> wrote: > > Em qua, 2019-04-24 às 20:58 +0100, Chris Wilson escreveu: > > Quoting Jian-Hong Pan (2019-04-23 10:28:10) > > > From: Daniel Drake <drake@endlessm.com> > > > > > > On many (all?) the Gemini Lake systems we work with, there is frequent > > > momentary graphical corruption at the top of the screen, and it seems > > > that disabling framebuffer compression can avoid this. > > > > > > The ticket was reported 6 months ago and has already affected a > > > multitude of users, without any real progress being made. So, lets > > > disable framebuffer compression on GeminiLake until a solution is found. > > > > > > Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=108085 > > > Signed-off-by: Daniel Drake <drake@endlessm.com> > > > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> > > > > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ? > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Cc: <stable@vger.kernel.org> # v4.11+ > > > > glk landed 1 month before, so that seems the earliest broken point. > > > > The bug is well reported, the bug author is helpful and it even has a > description of "steps to reproduce" that looks very easy (although I > didn't try it). Everything suggests this is a bug the display team > could actually solve with not-so-many hours of debugging. > > In the meantime, unbreak the systems: > Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Quick ping here. Any further comments on this patch? Can it be applied? Thanks Daniel
On Thu, 09 May 2019, Daniel Drake <drake@endlessm.com> wrote: > Hi, > > > On Thu, Apr 25, 2019 at 4:27 AM Paulo Zanoni <paulo.r.zanoni@intel.com> wrote: >> >> Em qua, 2019-04-24 às 20:58 +0100, Chris Wilson escreveu: >> > Quoting Jian-Hong Pan (2019-04-23 10:28:10) >> > > From: Daniel Drake <drake@endlessm.com> >> > > >> > > On many (all?) the Gemini Lake systems we work with, there is frequent >> > > momentary graphical corruption at the top of the screen, and it seems >> > > that disabling framebuffer compression can avoid this. >> > > >> > > The ticket was reported 6 months ago and has already affected a >> > > multitude of users, without any real progress being made. So, lets >> > > disable framebuffer compression on GeminiLake until a solution is found. >> > > >> > > Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=108085 >> > > Signed-off-by: Daniel Drake <drake@endlessm.com> >> > > Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> >> > >> > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ? >> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> >> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >> > Cc: Jani Nikula <jani.nikula@linux.intel.com> >> > Cc: <stable@vger.kernel.org> # v4.11+ >> > >> > glk landed 1 month before, so that seems the earliest broken point. >> > >> >> The bug is well reported, the bug author is helpful and it even has a >> description of "steps to reproduce" that looks very easy (although I >> didn't try it). Everything suggests this is a bug the display team >> could actually solve with not-so-many hours of debugging. >> >> In the meantime, unbreak the systems: >> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Quick ping here. Any further comments on this patch? Can it be applied? Pushed now, thanks. Needed to get a clean CI result, and I dropped the ball a bit there, sorry. BR, Jani.
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 656e684e7c9a..fc018f3f53a1 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -1278,6 +1278,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) if (!HAS_FBC(dev_priv)) return 0; + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ + if (IS_GEMINILAKE(dev_priv)) + return 0; + if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) return 1;