From patchwork Mon May 6 14:46:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10931173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 945FC1515 for ; Mon, 6 May 2019 14:46:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E035286D0 for ; Mon, 6 May 2019 14:46:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 70CDC286DB; Mon, 6 May 2019 14:46:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0E779286D0 for ; Mon, 6 May 2019 14:46:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1750F89A4F; Mon, 6 May 2019 14:46:39 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 209DB89A1F for ; Mon, 6 May 2019 14:46:38 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id p26so15607961edr.2 for ; Mon, 06 May 2019 07:46:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+J4AecpOs7wrslxkg+bAl6T47e+O2ANuzwMN3YlnNp0=; b=PymjX+7I2ivKRU4+nuV8uLR9XtdFwSuXgjxa2G+m5Bro0HTlToDdYDztT6F8b7yJhx sRIAbi/IbQKIr/PUKCxcbYJWipEDFcXPUzVj/hS53e9vFasgK1o4sinlpfQY577ZDzYR YxkosA2zHahckZNIo0dklbmc0XFkHFwYW9FzHgmIjIYHotDxU5NlfCunbD+8EA9LzhQ2 YsqTZY1qdmSuudQeDx18RN9csoL5+0CiDBp2ibRR6BBEmocrKBh9HRhMDFajwfjiowQj 9jT8TKzVGRGaIdCTWYL/b/gW+AaMHl8eZvMyoobvbb7O5rJIgtj5ilNILRDSowWhHfVW 27PA== X-Gm-Message-State: APjAAAXGY4T/jvuq95oqKb7VFRVxxq0aDiemB5SYJuUHuwQTImL2aGM7 xqm+QMh4F0lrmpiMpwGOVD/2+4zWMLg= X-Google-Smtp-Source: APXvYqxYrBxTJx2m9SyFNj8vP9rP0cdBbQwYm4/7wYsUkUBh1hUvHtMNb7ydJkZXTd87IaKc/53qWg== X-Received: by 2002:a17:906:6b01:: with SMTP id q1mr3006924ejr.34.1557153996194; Mon, 06 May 2019 07:46:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id y22sm256810ejj.75.2019.05.06.07.46.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 May 2019 07:46:34 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm/doc: Improve docs for conn_state->best_encoder Date: Mon, 6 May 2019 16:46:29 +0200 Message-Id: <20190506144629.5976-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+J4AecpOs7wrslxkg+bAl6T47e+O2ANuzwMN3YlnNp0=; b=E/d9zz+DYTm/cckzCbxabeY1tfcldbJW0t+KqHILI/pst9CQjSz06n9DrAPOn0rfuv 3VMtfbo+nTvyu428+BNt+STpUY3MqAoxcM+bffPQ2+2hESn5noSl5aaZVSysKi3V8R5r fCRqtnpKxyuCC0MSNwjEebJFeclZ9EFZofM2s= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Sean Paul , Laurent Pinchart , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP It's mandatory and considered core state since ioctls rely on this working. Thanks to Laurent for pointing out this gap. v2: Clarify to "atomic drivers" only. Cc: Laurent Pinchart Cc: Sean Paul Signed-off-by: Daniel Vetter --- include/drm/drm_connector.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 02a131202add..f43f40d5888a 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -517,6 +517,10 @@ struct drm_connector_state { * Used by the atomic helpers to select the encoder, through the * &drm_connector_helper_funcs.atomic_best_encoder or * &drm_connector_helper_funcs.best_encoder callbacks. + * + * NOTE: Atomic drivers must fill this out (either themselves or through + * helpers), for otherwise the GETCONNECTOR and GETENCODER IOCTLs will + * not return correct data to userspace. */ struct drm_encoder *best_encoder;