| Message ID | 20190513133504.18612-1-ramalingam.c@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/hdcp: drm_hdcp_request_srm() as static | expand |
On Mon, May 13, 2019 at 07:05:04PM +0530, Ramalingam C wrote: > Below Sparsh warnings are fixed. > > Commit: drm: revocation check at drm subsystem > +drivers/gpu/drm/drm_hdcp.c:235:6: warning: symbol > 'drm_hdcp_request_srm' was not declared. Should it be static? > +drivers/gpu/drm/drm_hdcp.c:27:3: warning: symbol 'srm_data' was not > declared. Should it be static? > +drivers/gpu/drm/drm_hdcp.c:317:5: warning: symbol 'drm_setup_hdcp_srm' > was not declared. Should it be static? > +drivers/gpu/drm/drm_hdcp.c:327:6: warning: symbol > 'drm_teardown_hdcp_srm' was not declared. Should it be static? > > cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com> Merged with Dave's irc ack into drm-intel-next-queued, thanks for your quick fix. -Daniel > --- > drivers/gpu/drm/drm_hdcp.c | 6 ++++-- > drivers/gpu/drm/drm_internal.h | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c > index 0da7b3718bad..cd837bd409f7 100644 > --- a/drivers/gpu/drm/drm_hdcp.c > +++ b/drivers/gpu/drm/drm_hdcp.c > @@ -21,7 +21,9 @@ > #include <drm/drm_mode_object.h> > #include <drm/drm_connector.h> > > -struct hdcp_srm { > +#include "drm_internal.h" > + > +static struct hdcp_srm { > u32 revoked_ksv_cnt; > u8 *revoked_ksv_list; > > @@ -235,7 +237,7 @@ static void drm_hdcp_srm_update(const u8 *buf, size_t count) > drm_hdcp_parse_hdcp2_srm(buf, count); > } > > -void drm_hdcp_request_srm(struct drm_device *drm_dev) > +static void drm_hdcp_request_srm(struct drm_device *drm_dev) > { > char fw_name[36] = "display_hdcp_srm.bin"; > const struct firmware *fw; > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index 476a422414f6..65abf3a69b40 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -106,6 +106,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector); > void drm_sysfs_lease_event(struct drm_device *dev); > > /* drm_gem.c */ > +struct drm_gem_object; > int drm_gem_init(struct drm_device *dev); > void drm_gem_destroy(struct drm_device *dev); > int drm_gem_handle_create_tail(struct drm_file *file_priv, > -- > 2.19.1 >
diff --git a/drivers/gpu/drm/drm_hdcp.c b/drivers/gpu/drm/drm_hdcp.c index 0da7b3718bad..cd837bd409f7 100644 --- a/drivers/gpu/drm/drm_hdcp.c +++ b/drivers/gpu/drm/drm_hdcp.c @@ -21,7 +21,9 @@ #include <drm/drm_mode_object.h> #include <drm/drm_connector.h> -struct hdcp_srm { +#include "drm_internal.h" + +static struct hdcp_srm { u32 revoked_ksv_cnt; u8 *revoked_ksv_list; @@ -235,7 +237,7 @@ static void drm_hdcp_srm_update(const u8 *buf, size_t count) drm_hdcp_parse_hdcp2_srm(buf, count); } -void drm_hdcp_request_srm(struct drm_device *drm_dev) +static void drm_hdcp_request_srm(struct drm_device *drm_dev) { char fw_name[36] = "display_hdcp_srm.bin"; const struct firmware *fw; diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h index 476a422414f6..65abf3a69b40 100644 --- a/drivers/gpu/drm/drm_internal.h +++ b/drivers/gpu/drm/drm_internal.h @@ -106,6 +106,7 @@ void drm_sysfs_connector_remove(struct drm_connector *connector); void drm_sysfs_lease_event(struct drm_device *dev); /* drm_gem.c */ +struct drm_gem_object; int drm_gem_init(struct drm_device *dev); void drm_gem_destroy(struct drm_device *dev); int drm_gem_handle_create_tail(struct drm_file *file_priv,
Below Sparsh warnings are fixed. Commit: drm: revocation check at drm subsystem +drivers/gpu/drm/drm_hdcp.c:235:6: warning: symbol 'drm_hdcp_request_srm' was not declared. Should it be static? +drivers/gpu/drm/drm_hdcp.c:27:3: warning: symbol 'srm_data' was not declared. Should it be static? +drivers/gpu/drm/drm_hdcp.c:317:5: warning: symbol 'drm_setup_hdcp_srm' was not declared. Should it be static? +drivers/gpu/drm/drm_hdcp.c:327:6: warning: symbol 'drm_teardown_hdcp_srm' was not declared. Should it be static? cc: Daniel Vetter <daniel.vetter@ffwll.ch> Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Ramalingam C <ramalingam.c@intel.com> --- drivers/gpu/drm/drm_hdcp.c | 6 ++++-- drivers/gpu/drm/drm_internal.h | 1 + 2 files changed, 5 insertions(+), 2 deletions(-)