From patchwork Mon Jun 3 14:28:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10972961 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D36421398 for ; Mon, 3 Jun 2019 14:28:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2E901FE95 for ; Mon, 3 Jun 2019 14:28:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B679B1FFE6; Mon, 3 Jun 2019 14:28:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 14F641FE95 for ; Mon, 3 Jun 2019 14:28:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 503D089244; Mon, 3 Jun 2019 14:28:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63AF589244 for ; Mon, 3 Jun 2019 14:28:56 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id r18so26183282edo.7 for ; Mon, 03 Jun 2019 07:28:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uNAeS51QRUwciVaj0qUAWn++Wcyjuws4KaNbVtCgqIg=; b=Pfa36fdJz1zaMaT0JXyKfW5nz7xjgsumUhwaIbCMW0cKR81aIGCMY6Y+Be9XgwLOzd bcr98Ccj93t25cyesPtFUx5j6Rc+I9lDP5WhCin208cerjc8JP7FMuqhK7DC+XUGw9Zo NzajCOdkt74jMxbvaTDVnllzWczwD2i0y6X7AbCrvLeboyzAxv2KD66JDQOU3VWul4+7 jqhpzK6Z56Ypotpjduia0wtfQ+HJ53uCxiwVdU/NqqMTpjvlFJXxWxXY5kyf71RRj5Gy EXZA9db/Ix8Nw4jW8F0GiSI3FUN9hmXrjP2kp93eFq6ja53+5W41uS6rWlD2wBPEjsfW OCQg== X-Gm-Message-State: APjAAAU3PiLddSYu4olVtArAAd6PqgofzTK3uXWFTwrpTbwyHSwxEBM4 DJVG4J38+7G7vxsEdrzC+ckOmgcw4rw= X-Google-Smtp-Source: APXvYqxr8JNKelZSPvLm8lUlcvEZ+sComgPTxPSLY12mHjF6SZvHXDzXvSb6ohXT05mDxOg9PhV6eg== X-Received: by 2002:a50:aeaf:: with SMTP id e44mr29643846edd.239.1559572134834; Mon, 03 Jun 2019 07:28:54 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id z3sm2572707edh.71.2019.06.03.07.28.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 07:28:54 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm/docs: More links for implicit/explicit fencing. Date: Mon, 3 Jun 2019 16:28:48 +0200 Message-Id: <20190603142848.26487-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uNAeS51QRUwciVaj0qUAWn++Wcyjuws4KaNbVtCgqIg=; b=AFGi04VVp/3xB5QuV/dCaezEZmGv3eXvARp3zR/Suj92Trwok3JFbCc3Zu9ax6ETD6 u0wsQfO4ikMpKTylUmPXjCc9LbOXZk39DD6e16lisk4GY5a5NAF93fDeuGRvTVLjd/0S CaK4vSj/GNBvraRDnKF5J/1jBW7BVDP+9eBec= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pekka Paalanen , Maxime Ripard , Daniel Vetter , David Airlie , Daniel Vetter , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP drm_atomic_set_fence_for_plane() contains the main discussion from a driver pov, link to that from more places. Cc: Pekka Paalanen Signed-off-by: Daniel Vetter Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Reviewed-by: Pekka Paalanen --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 ++++++ include/drm/drm_plane.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index 6fd48efe288c..6791245963c3 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -284,6 +284,9 @@ EXPORT_SYMBOL_GPL(drm_gem_fb_create_with_dirty); * There is no need for &drm_plane_helper_funcs.cleanup_fb hook for simple * gem based framebuffer drivers which have their buffers always pinned in * memory. + * + * See drm_atomic_set_fence_for_plane() for a discussion of implicit and + * explicit fencing in atomic modeset updates. */ int drm_gem_fb_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state) @@ -314,6 +317,9 @@ EXPORT_SYMBOL_GPL(drm_gem_fb_prepare_fb); * &dma_buf attached, extracts the exclusive fence and attaches it to plane * state for the atomic helper to wait on. Drivers can use this as their * &drm_simple_display_pipe_funcs.prepare_fb callback. + * + * See drm_atomic_set_fence_for_plane() for a discussion of implicit and + * explicit fencing in atomic modeset updates. */ int drm_gem_fb_simple_display_pipe_prepare_fb(struct drm_simple_display_pipe *pipe, struct drm_plane_state *plane_state) diff --git a/include/drm/drm_plane.h b/include/drm/drm_plane.h index 6078c700d9ba..cd5903ad33f7 100644 --- a/include/drm/drm_plane.h +++ b/include/drm/drm_plane.h @@ -69,7 +69,7 @@ struct drm_plane_state { * * Optional fence to wait for before scanning out @fb. The core atomic * code will set this when userspace is using explicit fencing. Do not - * write this directly for a driver's implicit fence, use + * write this field directly for a driver's implicit fence, use * drm_atomic_set_fence_for_plane() to ensure that an explicit fence is * preserved. *