From patchwork Wed Jun 5 07:04:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10976407 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 62611924 for ; Wed, 5 Jun 2019 07:33:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FCD428849 for ; Wed, 5 Jun 2019 07:33:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 442502885F; Wed, 5 Jun 2019 07:33:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E029C28849 for ; Wed, 5 Jun 2019 07:33:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3778F895E2; Wed, 5 Jun 2019 07:33:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF3EC893C0 for ; Wed, 5 Jun 2019 07:05:26 +0000 (UTC) Received: by mail-pg1-x543.google.com with SMTP id a3so4478065pgb.3 for ; Wed, 05 Jun 2019 00:05:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wirFf7Bfi/9XjwkqOXDgrZYsLDnJpPp9vEZbkrcNQgM=; b=A5mw98msGY8zM2iaonFdcYD4tmRyQQnyA+WHwB7siG46l2P8DeETUpZ6jyDahe0znF Z2kGQ1fb2iQx+l3I3Q73+YEeRxTSXt47u5cg4M2BRj5o848ITk44K2Im8RX53h4RR4Zn RK7lDhosTsWQZudUmafmjtz4zbV5kCEtNcvVaxVhTFT5izlF/Q73VkFwHBD2cVpSti6S P4Dv/hE/I/jgoEsi7q4o7GVMwQH0P/wMZO93HlZOQS3oPRQ3LxrXHYtg3Mnx9o8AysOE Pb+cwf6n3UdgbewezocwCt/ezv0fvgk3M94yiwx7KDWaR96faZ6u32tavSDQ8H7GQou1 354g== X-Gm-Message-State: APjAAAURTNMOT9XtCFv4hZXwB0h3DaOWYZtnf25EvuSlciGy02cM/Jkv XjL/JJXChnp9grF13l+AqodFSfB5pI8= X-Google-Smtp-Source: APXvYqzdAjVBrJhFWY+RrjKSWzaYuKCZNU94Ec07F/vvaqCHIvzCwttviG6CztET7NH7lSx/v9qRCQ== X-Received: by 2002:a63:f44b:: with SMTP id p11mr2435554pgk.225.1559718326197; Wed, 05 Jun 2019 00:05:26 -0700 (PDT) Received: from localhost.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id d132sm6527348pfd.61.2019.06.05.00.05.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 00:05:25 -0700 (PDT) From: Andrey Smirnov To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 03/15] drm/bridge: tc358767: Simplify polling in tc_link_training() Date: Wed, 5 Jun 2019 00:04:55 -0700 Message-Id: <20190605070507.11417-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190605070507.11417-1-andrew.smirnov@gmail.com> References: <20190605070507.11417-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 05 Jun 2019 07:33:22 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wirFf7Bfi/9XjwkqOXDgrZYsLDnJpPp9vEZbkrcNQgM=; b=NIHBvw4DzFLmSh+4MdmMCikQr0aNv7Gkhi7yCDFo0EYZH942t+X3CFLkzVladA3Swb 71Q8gWyOMwE3jAO5/hyjtYSrn6iR2qWSCXbJtWy8uax9XJLaSngzuIwi/YXsgG1aH7Pd haLYlVRzocFh+mB2qOhYiuw+xQbShOfzrN0O3xFV5DUjzqgDHw8/JboORuS6I74vjeSl uLZk7SSwhbspqq1qCdzWVDAQKZs50ov7P8cjBVcmiFW3RYf/0KbI22pVj/by6wPkG/uH 2fzmlJcvJgU/DYfXDRkFPnc7s4QNVxJkxftGNP7WK+d73ctFN6/TW3yDjP+ZZCTyBtxn pu1Q== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cory Tusar , Archit Taneja , Andrey Smirnov , Andrey Gusakov , linux-kernel@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , Chris Healy Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Replace explicit polling in tc_link_training() with equivalent call to tc_poll_timeout() for simplicity. No functional change intended (not including slightly altered debug output). Signed-off-by: Andrey Smirnov Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: Tomi Valkeinen Cc: Andrey Gusakov Cc: Philipp Zabel Cc: Cory Tusar Cc: Chris Healy Cc: Lucas Stach Cc: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 5e1e73a91696..115cffc55a96 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -748,22 +748,19 @@ static int tc_set_video_mode(struct tc_data *tc, static int tc_wait_link_training(struct tc_data *tc) { - u32 timeout = 1000; u32 value; int ret; - do { - udelay(1); - tc_read(DP0_LTSTAT, &value); - } while ((!(value & LT_LOOPDONE)) && (--timeout)); - - if (timeout == 0) { + ret = tc_poll_timeout(tc, DP0_LTSTAT, LT_LOOPDONE, + LT_LOOPDONE, 1, 1000); + if (ret) { dev_err(tc->dev, "Link training timeout waiting for LT_LOOPDONE!\n"); - return -ETIMEDOUT; + return ret; } - return (value >> 8) & 0x7; + tc_read(DP0_LTSTAT, &value); + return (value >> 8) & 0x7; err: return ret; }