From patchwork Thu Jun 6 22:27:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10980525 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D2188924 for ; Thu, 6 Jun 2019 22:28:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1A461FFE4 for ; Thu, 6 Jun 2019 22:28:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B517D27EE2; Thu, 6 Jun 2019 22:28:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5D6F21FFE4 for ; Thu, 6 Jun 2019 22:28:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5DA5C89A20; Thu, 6 Jun 2019 22:28:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id A838E89A08 for ; Thu, 6 Jun 2019 22:28:10 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id a8so5574747edx.3 for ; Thu, 06 Jun 2019 15:28:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kEwCoKMEU9hYC5cQlPLTZr8d/17Dvv8CqSbJ0oq0mBA=; b=AnL3q3yIrJV4CJ6ADFs7zOMR7ZV6/AK4TMhbyVwvINeGVHzTdycMvgZViq8hJvAMrT 5kGgkqH1DtLGtepjAPzH50s1Y5lTKJ+W0+RxeKjsLwL8pehXdmZE+6sntdzh85WkJ+F5 MKat4I3/Xy4EQRiBC6g8vcsz5sYjqKzW9O2Ay89zaskiWWNPTPNPLVmsOdKOunG09e8k ug4GMY4penLys+dhuwfLexmZEZ7B86TTTO44Q+Qu061iaVPweMwETCytpx4bh7vHW8XE EpDuDzBf046mqID1G0/7tekz7MCKNdFFap/UH9k3GjVkHSG0lBkufSQh8y6FcUAZyc1R RmvQ== X-Gm-Message-State: APjAAAVRU6ZnYfoPVCJI6mW+2ozyTKx332YIqVyz5Y3ZHpSVy6Ke6dNB zbUf1rIs6vHfre7l/CfhxzIsPyGF8rM= X-Google-Smtp-Source: APXvYqwLyX/DauxG+tOreWbM7W6K1M96l9h1v4GxpyRXMVqbJ+4bUBe3vdEIYaL2QhJGew3i9IT7/w== X-Received: by 2002:a17:906:2acf:: with SMTP id m15mr43817971eje.31.1559860088802; Thu, 06 Jun 2019 15:28:08 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id z10sm54228edl.35.2019.06.06.15.28.07 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 06 Jun 2019 15:28:08 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 07/10] drm/vkms: Dont flush crc worker when we change crc status Date: Fri, 7 Jun 2019 00:27:48 +0200 Message-Id: <20190606222751.32567-8-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190606222751.32567-1-daniel.vetter@ffwll.ch> References: <20190606222751.32567-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kEwCoKMEU9hYC5cQlPLTZr8d/17Dvv8CqSbJ0oq0mBA=; b=UjjABmM5aKOzkwqOgwquO4ZPHTIxw1O7vdR7RJnRoQm3pRSvFYtRmPAaozfAce23OK MgQoaAcpUj6y758+j7ZL/kRM4Whk+nEHAXr7pp55SogKIcyAr9ndkP1XLUWFz0bi1HZZ 34LpvAlGXv/vFZPSjR9OaofqBapXrNkg04krQ= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Haneen Mohammed , Rodrigo Siqueira , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The crc core code can cope with some late crc, the race is kinda unavoidable. So no need to flush pending workers, they'll complete in time. Signed-off-by: Daniel Vetter Cc: Rodrigo Siqueira Cc: Haneen Mohammed Cc: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_crc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_crc.c b/drivers/gpu/drm/vkms/vkms_crc.c index 96806cd35ad4..9d15e5e85830 100644 --- a/drivers/gpu/drm/vkms/vkms_crc.c +++ b/drivers/gpu/drm/vkms/vkms_crc.c @@ -249,9 +249,6 @@ int vkms_set_crc_source(struct drm_crtc *crtc, const char *src_name) ret = vkms_crc_parse_source(src_name, &enabled); - /* make sure nothing is scheduled on crtc workq */ - flush_workqueue(out->crc_workq); - spin_lock_irq(&out->lock); out->crc_enabled = enabled; spin_unlock_irq(&out->lock);