From patchwork Thu Jun 6 22:27:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10980531 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BA0CB924 for ; Thu, 6 Jun 2019 22:28:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A7BFE1FFE4 for ; Thu, 6 Jun 2019 22:28:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9937A27EE2; Thu, 6 Jun 2019 22:28:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56A451FFE4 for ; Thu, 6 Jun 2019 22:28:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DE79A89A35; Thu, 6 Jun 2019 22:28:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D20589A08 for ; Thu, 6 Jun 2019 22:28:12 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id w13so5559843eds.4 for ; Thu, 06 Jun 2019 15:28:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XeDSyVtOXRXEHiR2W7B4DH9ZPXBdnhHGqP4dgrobpmo=; b=HJLVuHVakPg/kSNmhbHhTUndTrelbfEGZeFI3UxbialwyibasbzEHto9sP3w3DZ4ZV g/kOZn4bP6IUdaMx4yDj9pkTRk2Ra6K37Wh3AtoIGMNY/LoTHDVgtw7k8mlrMdYy/Nvq aka84h37n/qAX+aXNH384XYgmRjRjKSLQ8A33NcfeV8RLrWgcHUot4pzdiqu5Zhk4p+q 8TxWKCd+hMu+mkDROXSSOUt1oSzoLipMeMN4XMSL2V1nOnzF853UZxLZaFfLZkC5s6GY 7rfJJhMmn9mWxeFhLIlRlMuioXrGz1Fav8kDdhzwjLaD4p53Xxzf8izU2Bl1Upteq0B2 u57A== X-Gm-Message-State: APjAAAU7TK2UYN40aJqaoBm07LQRRW+CBVPKi7wn8fITiJkaRI9YIGlT +9h5b8Uj31vCgu2701pbiQtEFPMgGIA= X-Google-Smtp-Source: APXvYqzS2BVvGqtu3HGJ7jajln37Vr8QcwtLx1hDJn1g7LCVNa2z8TlQpJGaHavsPlgfCI/Fs5/W3Q== X-Received: by 2002:aa7:c402:: with SMTP id j2mr46664467edq.165.1559860089984; Thu, 06 Jun 2019 15:28:09 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id z10sm54228edl.35.2019.06.06.15.28.08 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 06 Jun 2019 15:28:09 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 08/10] drm/vkms: No _irqsave within spin_lock_irq needed Date: Fri, 7 Jun 2019 00:27:49 +0200 Message-Id: <20190606222751.32567-9-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190606222751.32567-1-daniel.vetter@ffwll.ch> References: <20190606222751.32567-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XeDSyVtOXRXEHiR2W7B4DH9ZPXBdnhHGqP4dgrobpmo=; b=ceVHHuMhW3DSI1EL8qvoGn9laYfMHLlDtOzETk1/ebRTLtZWDcp68irwiKTPDYAwfO /wJp3x9zqvn2DcuatT9Gw38TFkpjEsFlSXbjRDB50w3vw3lca0mqpfsRb+M4CsFChFFb liFteu6lberZVyqDAVmLW5Ej+5qVK55qkeg6Y= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP irqs are already off. Signed-off-by: Daniel Vetter Reviewed-by: Rodrigo Siqueira Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/vkms/vkms_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c index b6987d90805f..48a793ba4030 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -183,17 +183,16 @@ static void vkms_crtc_atomic_flush(struct drm_crtc *crtc, struct drm_crtc_state *old_crtc_state) { struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc); - unsigned long flags; if (crtc->state->event) { - spin_lock_irqsave(&crtc->dev->event_lock, flags); + spin_lock(&crtc->dev->event_lock); if (drm_crtc_vblank_get(crtc) != 0) drm_crtc_send_vblank_event(crtc, crtc->state->event); else drm_crtc_arm_vblank_event(crtc, crtc->state->event); - spin_unlock_irqrestore(&crtc->dev->event_lock, flags); + spin_unlock(&crtc->dev->event_lock); crtc->state->event = NULL; }