[v4,hmm,06/12] mm/hmm: Do not use list*_rcu() for hmm->ranges

Commit Message

Jason Gunthorpe June 24, 2019, 9:01 p.m. UTC

From: Jason Gunthorpe <[e-mail]>

This list is always read and written while holding hmm->lock so there is
no need for the confusing _rcu annotations.

Signed-off-by: Jason Gunthorpe <[e-mail]>
Reviewed-by: Jérôme Glisse <[e-mail]>
Reviewed-by: John Hubbard <[e-mail]>
Acked-by: Souptick Joarder <[e-mail]>
Reviewed-by: Ralph Campbell <[e-mail]>
Reviewed-by: Ira Weiny <[e-mail]>
Reviewed-by: Christoph Hellwig <[e-mail]>
Tested-by: Philip Yang <[e-mail]>
---
 mm/hmm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/mm/hmm.c b/mm/hmm.c
index 0423f4ca3a7e09..73c8af4827fe87 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -912,7 +912,7 @@  int hmm_range_register(struct hmm_range *range,
 
 	range->hmm = hmm;
 	kref_get(&hmm->kref);
-	list_add_rcu(&range->list, &hmm->ranges);
+	list_add(&range->list, &hmm->ranges);
 
 	/*
 	 * If there are any concurrent notifiers we have to wait for them for
@@ -942,7 +942,7 @@  void hmm_range_unregister(struct hmm_range *range)
 		return;
 
 	mutex_lock(&hmm->lock);
-	list_del_rcu(&range->list);
+	list_del(&range->list);
 	mutex_unlock(&hmm->lock);
 
 	/* Drop reference taken by hmm_range_register() */