| Message ID | 20190627112939.GA4832@xin-VirtualBox (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] Adjust analogix chip driver location | expand |
On Thu, Jun 27, 2019 at 07:57:05PM +0800, Laurent Pinchart wrote: > Hello Xin Ji, > > Thank you for the patch. > > On Thu, Jun 27, 2019 at 11:29:47AM +0000, Xin Ji wrote: > > Move analogix chip ANX78XX bridge driver into "analogix" directory. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > drivers/gpu/drm/bridge/Kconfig | 10 ---------- > > drivers/gpu/drm/bridge/Makefile | 3 +-- > > drivers/gpu/drm/bridge/analogix/Kconfig | 10 ++++++++++ > > drivers/gpu/drm/bridge/analogix/Makefile | 2 ++ > > drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c | 0 > > drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h | 0 > > 6 files changed, 13 insertions(+), 12 deletions(-) > > rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (100%) > > rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h (100%) > > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > index ee77746..862789b 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -16,16 +16,6 @@ config DRM_PANEL_BRIDGE > > menu "Display Interface Bridges" > > depends on DRM && DRM_BRIDGE > > > > -config DRM_ANALOGIX_ANX78XX > > - tristate "Analogix ANX78XX bridge" > > - select DRM_KMS_HELPER > > - select REGMAP_I2C > > - ---help--- > > - ANX78XX is an ultra-low Full-HD SlimPort transmitter > > - designed for portable devices. The ANX78XX transforms > > - the HDMI output of an application processor to MyDP > > - or DisplayPort. > > - > > config DRM_CDNS_DSI > > tristate "Cadence DPI/DSI bridge" > > select DRM_KMS_HELPER > > diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile > > index 4934fcf..02cb4cd 100644 > > --- a/drivers/gpu/drm/bridge/Makefile > > +++ b/drivers/gpu/drm/bridge/Makefile > > @@ -1,5 +1,4 @@ > > # SPDX-License-Identifier: GPL-2.0 > > -obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o > > obj-$(CONFIG_DRM_CDNS_DSI) += cdns-dsi.o > > obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o > > obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o > > @@ -12,8 +11,8 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o > > obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o > > obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o > > obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o > > -obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/ > > obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ > > obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o > > obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o > > obj-y += synopsys/ > > +obj-y += analogix/ > > Could you place that line just above the synopsys/ directory, to have > them alphabetically sorted (this could also be done while applying) ? > Apart from that the patch looks good to me, so OK, I'll submit new patch, thanks! > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > diff --git a/drivers/gpu/drm/bridge/analogix/Kconfig b/drivers/gpu/drm/bridge/analogix/Kconfig > > index e930ff9..dfe84f5 100644 > > --- a/drivers/gpu/drm/bridge/analogix/Kconfig > > +++ b/drivers/gpu/drm/bridge/analogix/Kconfig > > @@ -1,4 +1,14 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > +config DRM_ANALOGIX_ANX78XX > > + tristate "Analogix ANX78XX bridge" > > + select DRM_KMS_HELPER > > + select REGMAP_I2C > > + ---help--- > > + ANX78XX is an ultra-low Full-HD SlimPort transmitter > > + designed for portable devices. The ANX78XX transforms > > + the HDMI output of an application processor to MyDP > > + or DisplayPort. > > + > > config DRM_ANALOGIX_DP > > tristate > > depends on DRM > > diff --git a/drivers/gpu/drm/bridge/analogix/Makefile b/drivers/gpu/drm/bridge/analogix/Makefile > > index fdbf3fd..d4c54ac 100644 > > --- a/drivers/gpu/drm/bridge/analogix/Makefile > > +++ b/drivers/gpu/drm/bridge/analogix/Makefile > > @@ -1,3 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o > > + > > analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o > > obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o > > diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > similarity index 100% > > rename from drivers/gpu/drm/bridge/analogix-anx78xx.c > > rename to drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.h b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h > > similarity index 100% > > rename from drivers/gpu/drm/bridge/analogix-anx78xx.h > > rename to drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index ee77746..862789b 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -16,16 +16,6 @@ config DRM_PANEL_BRIDGE menu "Display Interface Bridges" depends on DRM && DRM_BRIDGE -config DRM_ANALOGIX_ANX78XX - tristate "Analogix ANX78XX bridge" - select DRM_KMS_HELPER - select REGMAP_I2C - ---help--- - ANX78XX is an ultra-low Full-HD SlimPort transmitter - designed for portable devices. The ANX78XX transforms - the HDMI output of an application processor to MyDP - or DisplayPort. - config DRM_CDNS_DSI tristate "Cadence DPI/DSI bridge" select DRM_KMS_HELPER diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile index 4934fcf..02cb4cd 100644 --- a/drivers/gpu/drm/bridge/Makefile +++ b/drivers/gpu/drm/bridge/Makefile @@ -1,5 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o obj-$(CONFIG_DRM_CDNS_DSI) += cdns-dsi.o obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o obj-$(CONFIG_DRM_LVDS_ENCODER) += lvds-encoder.o @@ -12,8 +11,8 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o -obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/ obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o obj-y += synopsys/ +obj-y += analogix/ diff --git a/drivers/gpu/drm/bridge/analogix/Kconfig b/drivers/gpu/drm/bridge/analogix/Kconfig index e930ff9..dfe84f5 100644 --- a/drivers/gpu/drm/bridge/analogix/Kconfig +++ b/drivers/gpu/drm/bridge/analogix/Kconfig @@ -1,4 +1,14 @@ # SPDX-License-Identifier: GPL-2.0-only +config DRM_ANALOGIX_ANX78XX + tristate "Analogix ANX78XX bridge" + select DRM_KMS_HELPER + select REGMAP_I2C + ---help--- + ANX78XX is an ultra-low Full-HD SlimPort transmitter + designed for portable devices. The ANX78XX transforms + the HDMI output of an application processor to MyDP + or DisplayPort. + config DRM_ANALOGIX_DP tristate depends on DRM diff --git a/drivers/gpu/drm/bridge/analogix/Makefile b/drivers/gpu/drm/bridge/analogix/Makefile index fdbf3fd..d4c54ac 100644 --- a/drivers/gpu/drm/bridge/analogix/Makefile +++ b/drivers/gpu/drm/bridge/analogix/Makefile @@ -1,3 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o + analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c similarity index 100% rename from drivers/gpu/drm/bridge/analogix-anx78xx.c rename to drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.h b/drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h similarity index 100% rename from drivers/gpu/drm/bridge/analogix-anx78xx.h rename to drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h
Move analogix chip ANX78XX bridge driver into "analogix" directory. Signed-off-by: Xin Ji <xji@analogixsemi.com> --- drivers/gpu/drm/bridge/Kconfig | 10 ---------- drivers/gpu/drm/bridge/Makefile | 3 +-- drivers/gpu/drm/bridge/analogix/Kconfig | 10 ++++++++++ drivers/gpu/drm/bridge/analogix/Makefile | 2 ++ drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c | 0 drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h | 0 6 files changed, 13 insertions(+), 12 deletions(-) rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.c (100%) rename drivers/gpu/drm/bridge/{ => analogix}/analogix-anx78xx.h (100%)