| Message ID | 20190630061922.7254-31-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: drop use of drmp.h in drm-misc | expand |
On Sun, Jun 30, 2019 at 08:19:19AM +0200, Sam Ravnborg wrote: > The macro DRM_VRAM_MM_FILE_OPERATIONS referencs > functions declared in other header files. > Include these header files so this header files > pulls in what it references. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > The list of cc: was too large to add all recipients to the cover letter. > Please find cover letter here: > https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html > Search for "drm: drop use of drmp.h in drm-misc" > > Sam > > include/drm/drm_vram_mm_helper.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/drm_vram_mm_helper.h b/include/drm/drm_vram_mm_helper.h > index a8ffd8599b08..2aacfb1ccfae 100644 > --- a/include/drm/drm_vram_mm_helper.h > +++ b/include/drm/drm_vram_mm_helper.h > @@ -3,6 +3,8 @@ > #ifndef DRM_VRAM_MM_HELPER_H > #define DRM_VRAM_MM_HELPER_H > > +#include <drm/drm_file.h> > +#include <drm/drm_ioctl.h> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> btw for these helpers good if you manually add relevant people - since there are maintainers for the entire subsystem get_maintainers.pl doesn't look at git history. Or we'd need to add MAINTAINERS entries manually for all of them ... -Daniel > #include <drm/ttm/ttm_bo_driver.h> > > struct drm_device; > -- > 2.20.1 >
On Tue, Jul 02, 2019 at 03:35:52PM +0200, Daniel Vetter wrote: > On Sun, Jun 30, 2019 at 08:19:19AM +0200, Sam Ravnborg wrote: > > The macro DRM_VRAM_MM_FILE_OPERATIONS referencs > > functions declared in other header files. > > Include these header files so this header files > > pulls in what it references. > > > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Maxime Ripard <maxime.ripard@bootlin.com> > > Cc: Sean Paul <sean@poorly.run> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Daniel Vetter <daniel@ffwll.ch> > > --- > > The list of cc: was too large to add all recipients to the cover letter. > > Please find cover letter here: > > https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html > > Search for "drm: drop use of drmp.h in drm-misc" > > > > Sam > > > > include/drm/drm_vram_mm_helper.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/drm/drm_vram_mm_helper.h b/include/drm/drm_vram_mm_helper.h > > index a8ffd8599b08..2aacfb1ccfae 100644 > > --- a/include/drm/drm_vram_mm_helper.h > > +++ b/include/drm/drm_vram_mm_helper.h > > @@ -3,6 +3,8 @@ > > #ifndef DRM_VRAM_MM_HELPER_H > > #define DRM_VRAM_MM_HELPER_H > > > > +#include <drm/drm_file.h> > > +#include <drm/drm_ioctl.h> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Thanks, applied. > > btw for these helpers good if you manually add relevant people - since > there are maintainers for the entire subsystem get_maintainers.pl doesn't > look at git history. Or we'd need to add MAINTAINERS entries manually for > all of them ... Noted, will do so next time I touch the more general files. get_maintainers sometimes list a _lot_ of people. I have yet to find out why, but then I have not digged inot it. And for now I just ignore it and add all. Sam
diff --git a/include/drm/drm_vram_mm_helper.h b/include/drm/drm_vram_mm_helper.h index a8ffd8599b08..2aacfb1ccfae 100644 --- a/include/drm/drm_vram_mm_helper.h +++ b/include/drm/drm_vram_mm_helper.h @@ -3,6 +3,8 @@ #ifndef DRM_VRAM_MM_HELPER_H #define DRM_VRAM_MM_HELPER_H +#include <drm/drm_file.h> +#include <drm/drm_ioctl.h> #include <drm/ttm/ttm_bo_driver.h> struct drm_device;
The macro DRM_VRAM_MM_FILE_OPERATIONS referencs functions declared in other header files. Include these header files so this header files pulls in what it references. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> --- The list of cc: was too large to add all recipients to the cover letter. Please find cover letter here: https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html Search for "drm: drop use of drmp.h in drm-misc" Sam include/drm/drm_vram_mm_helper.h | 2 ++ 1 file changed, 2 insertions(+)