| Message ID | 20190820151357.22324-1-mihail.atanassov@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/komeda: Add missing of_node_get() call | expand |
On Tue, Aug 20, 2019 at 03:16:58PM +0000, Mihail Atanassov wrote: > komeda_pipeline_destroy has the matching of_node_put(). > > Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing") > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > --- > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > index 0142ee991957..ca64a129c594 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > @@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np) > of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT); > > pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1]; > - pipe->of_node = np; > + pipe->of_node = of_node_get(np); > Good catch. Reviewed-by: Ayan Kumar Halder <ayan.halder@arm.com> > return 0; > } > -- > 2.22.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Aug 23, 2019 at 01:43:49PM +0000, Ayan Halder wrote: > On Tue, Aug 20, 2019 at 03:16:58PM +0000, Mihail Atanassov wrote: > > komeda_pipeline_destroy has the matching of_node_put(). > > > > Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing") > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > > --- > > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > > index 0142ee991957..ca64a129c594 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > > @@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np) > > of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT); > > > > pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1]; > > - pipe->of_node = np; > > + pipe->of_node = of_node_get(np); > > > > Good catch. > Reviewed-by: Ayan Kumar Halder <ayan.halder@arm.com> > > return 0; > > } > > -- Pushed to drm-misc-fixes - 51a44a28eefd0d4c1addeb23fc5a599ff1787dfd Apologies, I accidently pushed the gerrit change-id in the commit message. Surprisingly, "checkpatch.pl --strict" did not catch the issue. > > 2.22.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index 0142ee991957..ca64a129c594 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -130,7 +130,7 @@ static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np) of_graph_get_port_by_id(np, KOMEDA_OF_PORT_OUTPUT); pipe->dual_link = pipe->of_output_links[0] && pipe->of_output_links[1]; - pipe->of_node = np; + pipe->of_node = of_node_get(np); return 0; }
komeda_pipeline_destroy has the matching of_node_put(). Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing") Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)