| Message ID | 20190822211518.5578-1-christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mcde: Fix an error handling path in 'mcde_probe()' | expand |
On Thu, Aug 22, 2019 at 11:15 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > If we don't find any matching components, we should go through the error > handling path, in order to free some resources. > > Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Patch applied! Yours, Linus Walleij
diff --git a/drivers/gpu/drm/mcde/mcde_drv.c b/drivers/gpu/drm/mcde/mcde_drv.c index 9a09eba53182..5649887d2b90 100644 --- a/drivers/gpu/drm/mcde/mcde_drv.c +++ b/drivers/gpu/drm/mcde/mcde_drv.c @@ -484,7 +484,8 @@ static int mcde_probe(struct platform_device *pdev) } if (!match) { dev_err(dev, "no matching components\n"); - return -ENODEV; + ret = -ENODEV; + goto clk_disable; } if (IS_ERR(match)) { dev_err(dev, "could not create component match\n");
If we don't find any matching components, we should go through the error handling path, in order to free some resources. Fixes: ca5be902a87d ("drm/mcde: Fix uninitialized variable") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/gpu/drm/mcde/mcde_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)