| Message ID | 20190825135154.11488-4-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: rcar-du: Add Color Management Module (CMM) | expand |
Hi Jacopo, On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Add CMM units to Renesas R-Car M3-W device tree and reference them from > the Display Unit they are connected to. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > index 3dc9d73f589a..8d78e1f98a23 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > @@ -2613,6 +2613,30 @@ > renesas,fcp = <&fcpvi0>; > }; > > + cmm0: cmm@fea40000 { > + compatible = "renesas,cmm-r8a7796"; Shouldn't you add "renesas,rcar-gen3-cmm" as a fallback? (for all CMM nodes in all DT patches) Gr{oetje,eeting}s, Geert
Hi Geert. On Mon, Aug 26, 2019 at 09:28:56AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Sun, Aug 25, 2019 at 3:50 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > Add CMM units to Renesas R-Car M3-W device tree and reference them from > > the Display Unit they are connected to. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > --- > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > index 3dc9d73f589a..8d78e1f98a23 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > @@ -2613,6 +2613,30 @@ > > renesas,fcp = <&fcpvi0>; > > }; > > > > + cmm0: cmm@fea40000 { > > + compatible = "renesas,cmm-r8a7796"; > > Shouldn't you add "renesas,rcar-gen3-cmm" as a fallback? Should I? Since you have suggested to drop all per-SoC compatibles from the driver I guess so... Thanks j > (for all CMM nodes in all DT patches) > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Jacopo, Thank you for the patch. Should you squash this with the patches that add CMM units to the other SoCs ? On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote: > Add CMM units to Renesas R-Car M3-W device tree and reference them from > the Display Unit they are connected to. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Apart from the issue pointed out by Geert, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > index 3dc9d73f589a..8d78e1f98a23 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > @@ -2613,6 +2613,30 @@ > renesas,fcp = <&fcpvi0>; > }; > > + cmm0: cmm@fea40000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea40000 0 0x1000>; > + clocks = <&cpg CPG_MOD 711>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + resets = <&cpg 711>; > + }; > + > + cmm1: cmm@fea50000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea50000 0 0x1000>; > + clocks = <&cpg CPG_MOD 710>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + resets = <&cpg 710>; > + }; > + > + cmm2: cmm@fea60000 { > + compatible = "renesas,cmm-r8a7796"; > + reg = <0 0xfea60000 0 0x1000>; > + clocks = <&cpg CPG_MOD 709>; > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > + resets = <&cpg 709>; > + }; > + > csi20: csi2@fea80000 { > compatible = "renesas,r8a7796-csi2"; > reg = <0 0xfea80000 0 0x10000>; > @@ -2766,6 +2790,7 @@ > status = "disabled"; > > vsps = <&vspd0 &vspd1 &vspd2>; > + cmms = <&cmm0 &cmm1 &cmm2>; > > ports { > #address-cells = <1>;
Hi Laurent, On Tue, Aug 27, 2019 at 01:43:37AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > Should you squash this with the patches that add CMM units to the other > SoCs ? I don't know, I guess it depends on Geert's preferences. Geert? > > On Sun, Aug 25, 2019 at 03:51:43PM +0200, Jacopo Mondi wrote: > > Add CMM units to Renesas R-Car M3-W device tree and reference them from > > the Display Unit they are connected to. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Apart from the issue pointed out by Geert, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > index 3dc9d73f589a..8d78e1f98a23 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > @@ -2613,6 +2613,30 @@ > > renesas,fcp = <&fcpvi0>; > > }; > > > > + cmm0: cmm@fea40000 { > > + compatible = "renesas,cmm-r8a7796"; > > + reg = <0 0xfea40000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 711>; > > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > > + resets = <&cpg 711>; > > + }; > > + > > + cmm1: cmm@fea50000 { > > + compatible = "renesas,cmm-r8a7796"; > > + reg = <0 0xfea50000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 710>; > > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > > + resets = <&cpg 710>; > > + }; > > + > > + cmm2: cmm@fea60000 { > > + compatible = "renesas,cmm-r8a7796"; > > + reg = <0 0xfea60000 0 0x1000>; > > + clocks = <&cpg CPG_MOD 709>; > > + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; > > + resets = <&cpg 709>; > > + }; > > + > > csi20: csi2@fea80000 { > > compatible = "renesas,r8a7796-csi2"; > > reg = <0 0xfea80000 0 0x10000>; > > @@ -2766,6 +2790,7 @@ > > status = "disabled"; > > > > vsps = <&vspd0 &vspd1 &vspd2>; > > + cmms = <&cmm0 &cmm1 &cmm2>; > > > > ports { > > #address-cells = <1>; > > -- > Regards, > > Laurent Pinchart
Hi Jacopo, On Tue, Aug 27, 2019 at 11:53 AM Jacopo Mondi <jacopo@jmondi.org> wrote: > On Tue, Aug 27, 2019 at 01:43:37AM +0300, Laurent Pinchart wrote: > > Should you squash this with the patches that add CMM units to the other > > SoCs ? > > I don't know, I guess it depends on Geert's preferences. Geert? If you add it to all supported SoCs at the same time, a single patch makes sense. Acceptance will mostly depends on who's at the end of the arm-soc pipeline: Olof would prefer a single patch ;-) Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 3dc9d73f589a..8d78e1f98a23 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -2613,6 +2613,30 @@ renesas,fcp = <&fcpvi0>; }; + cmm0: cmm@fea40000 { + compatible = "renesas,cmm-r8a7796"; + reg = <0 0xfea40000 0 0x1000>; + clocks = <&cpg CPG_MOD 711>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + resets = <&cpg 711>; + }; + + cmm1: cmm@fea50000 { + compatible = "renesas,cmm-r8a7796"; + reg = <0 0xfea50000 0 0x1000>; + clocks = <&cpg CPG_MOD 710>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + resets = <&cpg 710>; + }; + + cmm2: cmm@fea60000 { + compatible = "renesas,cmm-r8a7796"; + reg = <0 0xfea60000 0 0x1000>; + clocks = <&cpg CPG_MOD 709>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + resets = <&cpg 709>; + }; + csi20: csi2@fea80000 { compatible = "renesas,r8a7796-csi2"; reg = <0 0xfea80000 0 0x10000>; @@ -2766,6 +2790,7 @@ status = "disabled"; vsps = <&vspd0 &vspd1 &vspd2>; + cmms = <&cmm0 &cmm1 &cmm2>; ports { #address-cells = <1>;
Add CMM units to Renesas R-Car M3-W device tree and reference them from the Display Unit they are connected to. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++ 1 file changed, 25 insertions(+)