| Message ID | 20190827070925.16080-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 2019-08-27 3:09 a.m., YueHaibing wrote: > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > there is no caller in tree. > > Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > .../drm/amd/display/modules/info_packet/info_packet.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > index 5f4b98d..d885d64 100644 > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP { > ColorimetryYCC_DP_ITU2020YCbCr = 7, > }; > > -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value) > -{ > - unsigned int shift = 0; > - > - if (!mask || !dest) > - return; > - > - while (!((mask >> shift) & 1)) > - shift++; > - > - //reset > - *dest = *dest & ~mask; > - //set > - //dont let value span past mask > - value = value & (mask >> shift); > - //insert value > - *dest = *dest | (value << shift); > -} > - > void mod_build_vsc_infopacket(const struct dc_stream_state *stream, > struct dc_info_packet *info_packet) > { >
On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland <hwentlan@amd.com> wrote: > > On 2019-08-27 3:09 a.m., YueHaibing wrote: > > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > > there is no caller in tree. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > Applied. Thanks! Alex > Harry > > > --- > > .../drm/amd/display/modules/info_packet/info_packet.c | 19 ------------------- > > 1 file changed, 19 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > index 5f4b98d..d885d64 100644 > > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP { > > ColorimetryYCC_DP_ITU2020YCbCr = 7, > > }; > > > > -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value) > > -{ > > - unsigned int shift = 0; > > - > > - if (!mask || !dest) > > - return; > > - > > - while (!((mask >> shift) & 1)) > > - shift++; > > - > > - //reset > > - *dest = *dest & ~mask; > > - //set > > - //dont let value span past mask > > - value = value & (mask >> shift); > > - //insert value > > - *dest = *dest | (value << shift); > > -} > > - > > void mod_build_vsc_infopacket(const struct dc_stream_state *stream, > > struct dc_info_packet *info_packet) > > { > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi Alex, There are callers in the same file "info_packet.c" -----Original Message----- From: Alex Deucher <alexdeucher@gmail.com> Sent: August 27, 2019 10:20 To: Wentland, Harry <Harry.Wentland@amd.com> Cc: YueHaibing <yuehaibing@huawei.com>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie; daniel@ffwll.ch; Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Koo, Anthony <Anthony.Koo@amd.com>; Othman, Ahmad <Ahmad.Othman@amd.com>; Bernstein, Eric <Eric.Bernstein@amd.com>; Cyr, Aric <Aric.Cyr@amd.com>; alvin.lee3@amd.com; Tatla, Harmanprit <Harmanprit.Tatla@amd.com>; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland <hwentlan@amd.com> wrote: > > On 2019-08-27 3:09 a.m., YueHaibing wrote: > > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), > > there is no caller in tree. > > > > Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: > > YueHaibing <yuehaibing@huawei.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > Applied. Thanks! Alex > Harry > > > --- > > .../drm/amd/display/modules/info_packet/info_packet.c | 19 > > ------------------- > > 1 file changed, 19 deletions(-) > > > > diff --git > > a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > index 5f4b98d..d885d64 100644 > > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c > > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP { > > ColorimetryYCC_DP_ITU2020YCbCr = 7, }; > > > > -void setFieldWithMask(unsigned char *dest, unsigned int mask, > > unsigned int value) -{ > > - unsigned int shift = 0; > > - > > - if (!mask || !dest) > > - return; > > - > > - while (!((mask >> shift) & 1)) > > - shift++; > > - > > - //reset > > - *dest = *dest & ~mask; > > - //set > > - //dont let value span past mask > > - value = value & (mask >> shift); > > - //insert value > > - *dest = *dest | (value << shift); > > -} > > - > > void mod_build_vsc_infopacket(const struct dc_stream_state *stream, > > struct dc_info_packet *info_packet) { > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c index 5f4b98d..d885d64 100644 --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c @@ -114,25 +114,6 @@ enum ColorimetryYCCDP { ColorimetryYCC_DP_ITU2020YCbCr = 7, }; -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value) -{ - unsigned int shift = 0; - - if (!mask || !dest) - return; - - while (!((mask >> shift) & 1)) - shift++; - - //reset - *dest = *dest & ~mask; - //set - //dont let value span past mask - value = value & (mask >> shift); - //insert value - *dest = *dest | (value << shift); -} - void mod_build_vsc_infopacket(const struct dc_stream_state *stream, struct dc_info_packet *info_packet) {
After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), there is no caller in tree. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- .../drm/amd/display/modules/info_packet/info_packet.c | 19 ------------------- 1 file changed, 19 deletions(-)