From patchwork Wed Sep 4 14:39:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11130891 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2276114E5 for ; Wed, 4 Sep 2019 14:39:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A96C2168B for ; Wed, 4 Sep 2019 14:39:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A96C2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02B2B89178; Wed, 4 Sep 2019 14:39:56 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16E8E89178 for ; Wed, 4 Sep 2019 14:39:51 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id y91so10732962ede.9 for ; Wed, 04 Sep 2019 07:39:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6T0vunus81oOSmwTqHi4FK+oiqrTPhnd6mOhK/w9O8A=; b=k9UgXq9FfqtvuoDhbcstRVSlnNTehXbAVtk6BN6/zCtmGjWO2yL22sAQ3q0DK+FYAC mqsz0Et9Th61lyMTJIl7Olbzai24DYDFIUbHWxcfsAMjyTBw5+/pxa2wC8CCO2PHoAN+ 1o52l63yOMwib6KKv3fMI7AakXfcg1xF7ZtJT94lLwyBX/IlpG+pB45D/Hg53jW1DZB0 dJ5w4kl5a9cHzzUBgG3an0gbyUnLi2qPdHecqNB/JP1/HpSc81ZzDLJiist859M7jEc1 zo6pBRucBe4v3mG7gVt3v8+PTtAy5+ri5XQbHqaWoLSw15QXoh8lkFc/0hN2Fwd+ch8Q 6LkA== X-Gm-Message-State: APjAAAWebDUHrsRatO2muuNqYmpOP9pBXiN/bkwIG7ypB7HLH8iNI+ca A1PwyZ8X2KmAsQ2zQdP6IxGPUZ1rps8= X-Google-Smtp-Source: APXvYqx1iJEwAuMY6gGSyeXYiE0i8+1etOubxtB2OFh9lvmJS25iZONCpdkoN/emK36dCsIA8aUF3g== X-Received: by 2002:a17:906:1d10:: with SMTP id n16mr8787944ejh.34.1567607989373; Wed, 04 Sep 2019 07:39:49 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id o4sm101157edq.84.2019.09.04.07.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 07:39:48 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm: Use EOPNOTSUPP, not ENOTSUPP Date: Wed, 4 Sep 2019 16:39:42 +0200 Message-Id: <20190904143942.31756-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6T0vunus81oOSmwTqHi4FK+oiqrTPhnd6mOhK/w9O8A=; b=HtLb9dmSPQQ8J9F8WwGhXf+vJ1jEnR9GYIjPbZm9MLP1f0DxYZk6IPazDhgQLxfMGe NlEf3qKzsUuXZIY07fMVTt3XkAUacPmhcnSTbJNoCYRbWwlMcMTOSGPs5wbz6qkdVAGn DAC4kAz0g6k+Hgib0Na8i/u19UBdWYnIj87Tc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Maxime Ripard , =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= , Alex Deucher , Daniel Vetter , Sean Paul , Andres Rodriguez Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" - it's what we recommend in our docs: https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-return-values - it's the overwhelmingly used error code for "operation not supported", at least in drm core (slightly less so in drivers): $ git grep EOPNOTSUP -- drivers/gpu/drm/*c | wc -l 83 $ git grep ENOTSUP -- drivers/gpu/drm/*c | wc -l 5 - include/linux/errno.h makes it fairly clear that these are for nfsv3 (plus they also have error codes above 512, which is the block with some special behaviour ...) /* Defined for the NFSv3 protocol */ If the above isn't reflecting current practice, then I guess we should at least update the docs. Cc: José Roberto de Souza Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Sean Paul Cc: Alex Deucher Cc: Andres Rodriguez Cc: Noralf Trønnes Signed-off-by: Daniel Vetter Acked-by: Noralf Trønnes Reviewed-by: José Roberto de Souza --- drivers/gpu/drm/drm_edid.c | 6 +++--- drivers/gpu/drm/drm_mipi_dbi.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 82a4ceed3fcf..12c783f4d956 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -3719,7 +3719,7 @@ cea_db_offsets(const u8 *cea, int *start, int *end) if (*end < 4 || *end > 127) return -ERANGE; } else { - return -ENOTSUPP; + return -EOPNOTSUPP; } return 0; @@ -4188,7 +4188,7 @@ int drm_edid_to_sad(struct edid *edid, struct cea_sad **sads) if (cea_revision(cea) < 3) { DRM_DEBUG_KMS("SAD: wrong CEA revision\n"); - return -ENOTSUPP; + return -EOPNOTSUPP; } if (cea_db_offsets(cea, &start, &end)) { @@ -4249,7 +4249,7 @@ int drm_edid_to_speaker_allocation(struct edid *edid, u8 **sadb) if (cea_revision(cea) < 3) { DRM_DEBUG_KMS("SAD: wrong CEA revision\n"); - return -ENOTSUPP; + return -EOPNOTSUPP; } if (cea_db_offsets(cea, &start, &end)) { diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c index c4ee2709a6f3..f8154316a3b0 100644 --- a/drivers/gpu/drm/drm_mipi_dbi.c +++ b/drivers/gpu/drm/drm_mipi_dbi.c @@ -955,7 +955,7 @@ static int mipi_dbi_typec1_command(struct mipi_dbi *dbi, u8 *cmd, int ret; if (mipi_dbi_command_is_read(dbi, *cmd)) - return -ENOTSUPP; + return -EOPNOTSUPP; MIPI_DBI_DEBUG_COMMAND(*cmd, parameters, num);