From patchwork Fri Sep 6 14:44:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11135453 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A2A2914ED for ; Fri, 6 Sep 2019 14:45:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A1D4206A5 for ; Fri, 6 Sep 2019 14:45:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A1D4206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A319F6E2CF; Fri, 6 Sep 2019 14:45:07 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65F426E2CF for ; Fri, 6 Sep 2019 14:45:06 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id f2so176251edw.3 for ; Fri, 06 Sep 2019 07:45:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JbNFSk0vk9u1tIFchjBlxL+hSi7HGEZcj3DKKbCr2uw=; b=aYLypePN63EONGfp/ZdLv28GELEzffxG/q+YUavK1fyKyyBLh9P+nZlAyQyg5A/4Fa PW++bTm6NGrXsLTDIq+U82QSTAjazsA+IQywjb8qLketEDxdMZi4Y/oNTa8pVKaTFNcR ww4aAdSpeevDuBEWMY9/QpYhMLoJL3Hb0bUos1EG0nFw/lzV7GWTsBhNni/f/Hh0QrJT 6rc/qdJ/deSt5IAnDGZXvDnXq0Bg4JJzYOIFBbLgbh5qfPvhC8H1jYtVNy8hyaCNrBIR zjhYNS2/ZlCW1in4UiCbKIcAsTJtuHQHmVZECex6bEebXoFvXX0wVMR86BLiuk7QanuY OxPQ== X-Gm-Message-State: APjAAAWnFvkz5h4LQod9r8PjVdfUttg5g7O3i8pxeI777251yQ+mngQz AB5C3voDMtwFzjyho2iLXqU5jb6UPNo= X-Google-Smtp-Source: APXvYqxd0EnLcAauc93HJ6BoW6nRlwDyLYLxObLsX238cYaJJUzNWf+T2N8fNnH8K94KEwKcKJ4MEw== X-Received: by 2002:a17:906:3746:: with SMTP id e6mr7966489ejc.35.1567781104642; Fri, 06 Sep 2019 07:45:04 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id b36sm976439edc.53.2019.09.06.07.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2019 07:45:03 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm/blend: Define the direction of Z position values Date: Fri, 6 Sep 2019 16:44:59 +0200 Message-Id: <20190906144459.16025-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JbNFSk0vk9u1tIFchjBlxL+hSi7HGEZcj3DKKbCr2uw=; b=ihuAgesXG42VYDotu20BsqcHVfC+VuQRQ8sG+2ToXtYLevFHU8bTvzoOEKEwdkX/o+ Gu7mHCVRO/1XhxYOx4fCU+MLWOps8MTZtfRy+sJoW+hJI3E6D3k+datWoRe9bsEMBacS AZ1DADXAbNbRhgDqmkpRDlNXOyHAXkGGGgODc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Pekka Paalanen , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We forgot that. Proof is the one igt testcase we have: https://gitlab.freedesktop.org/drm/igt-gpu-tools/blob/master/tests/kms_atomic.c#L280 While at it also document that we have immutable zpos properties in some cases. Reported-by: Pekka Paalanen Cc: Pekka Paalanen Reviewed-by: Pekka Paalanen Cc: Ilia Mirkin Acked-by: Ilia Mirkin Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_blend.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 37ac168fcb60..d02709dd2d4a 100644 --- a/drivers/gpu/drm/drm_blend.c +++ b/drivers/gpu/drm/drm_blend.c @@ -130,7 +130,12 @@ * Z position is set up with drm_plane_create_zpos_immutable_property() and * drm_plane_create_zpos_property(). It controls the visibility of overlapping * planes. Without this property the primary plane is always below the cursor - * plane, and ordering between all other planes is undefined. + * plane, and ordering between all other planes is undefined. The positive + * Z axis points towards the user, i.e. planes with lower Z position values + * are underneath planes with higher Z position values. Note that the Z + * position value can also be immutable, to inform userspace about the + * hard-coded stacking of overlay planes, see + * drm_plane_create_zpos_immutable_property(). * * pixel blend mode: * Pixel blend mode is set up with drm_plane_create_blend_mode_property().