From patchwork Fri Sep 6 19:23:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Davenport X-Patchwork-Id: 11135895 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ABF1B1398 for ; Fri, 6 Sep 2019 19:24:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9518F20838 for ; Fri, 6 Sep 2019 19:24:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9518F20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A7C636E087; Fri, 6 Sep 2019 19:23:58 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7153A6E0BD for ; Fri, 6 Sep 2019 19:23:57 +0000 (UTC) Received: by mail-io1-xd43.google.com with SMTP id r26so15184459ioh.8 for ; Fri, 06 Sep 2019 12:23:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=j/k1s41Cd84FscFUH5HHkD4volUIZMrS8vWB51FggFg=; b=o4+zCBfAYTue2cRYWfcNJBpcpxppmw25x9ZJl7OKon2U5NQW4rVnui2kcAl/BdhAxG VZzBGdVa6CQp+Qn4BJvDuaPNV3Ofp3LVtB0PjucToYvIc5Qc60Ogh/H0qfrNp19GsGxi t+UneWbQ5RvWKse7ZlNMm2LIsObAqss1GH77GNJQdjahTxL0qymWQpWIBw5tNwUcFwLZ CKUoAHo/TibyGUt1I9QxiJd1QzYQXdWKbcdhM0nS85LaLx/jIo6NarPlEhAnQfd3mwfb G/eye/4VCDmbiNrUrwdQNZqGrEVISaeJTmWgn1DaMmsd8B93nG3LerTOT1p2Gq6hfp6r yyKA== X-Gm-Message-State: APjAAAV8aotKZrkcQokv2OkoMF75bA2rIjVv8mRnrhHSzZnu8i3JYIqv Z8YwPs9H6UxH6QsC5whKqd3lmi8o6TmMfg== X-Google-Smtp-Source: APXvYqxqS6QiXdDk5JDrakHdF9YlW8kNKtcmhtlrPTEYPW9EklfJ+iKnRmaedLHEBp6mDxHHlcHM/w== X-Received: by 2002:a02:cad1:: with SMTP id f17mr8739258jap.18.1567797836589; Fri, 06 Sep 2019 12:23:56 -0700 (PDT) Received: from ddavenport4.bld.corp.google.com ([2620:15c:183:0:92f:a80a:519d:f777]) by smtp.gmail.com with ESMTPSA id h70sm10931804iof.48.2019.09.06.12.23.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 06 Sep 2019 12:23:56 -0700 (PDT) From: Drew Davenport To: dri-devel@lists.freedesktop.org Subject: [PATCH 4/6] drm/msm/dpu: Remove unnecessary NULL checks Date: Fri, 6 Sep 2019 13:23:42 -0600 Message-Id: <20190906192344.223694-4-ddavenport@chromium.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190906192344.223694-1-ddavenport@chromium.org> References: <20190906192344.223694-1-ddavenport@chromium.org> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j/k1s41Cd84FscFUH5HHkD4volUIZMrS8vWB51FggFg=; b=RVUr+41FgmB62dAmBtO1Yq+z6nYqWpcb7vKjFfyJhjKwnK2zetlCIe4aATNsLL5Igw 63by+MASskqj+6jzFzFqSsjREa0+GkcMUAoeg4H9GmmkSkEDivCEm46WJVBXxXlYGmlH NVFZ/59Xrc+sZiOFTXGT5XjfVM+a7JzT0eVK4= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bruce Wang , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Jayant Shekhar , Greg Kroah-Hartman , Drew Davenport , freedreno@lists.freedesktop.org, Sean Paul , Sravanthi Kollukuduru Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" drm_crtc.dev will never be NULL, so no need to check it. Signed-off-by: Drew Davenport --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 5 ----- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 +++--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c index 094d74635fb7..839887a3a80c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c @@ -33,11 +33,6 @@ static struct dpu_kms *_dpu_crtc_get_kms(struct drm_crtc *crtc) { struct msm_drm_private *priv; - if (!crtc->dev) { - DPU_ERROR("invalid device\n"); - return NULL; - } - priv = crtc->dev->dev_private; if (!priv->kms) { DPU_ERROR("invalid kms\n"); diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index ead7d657097c..0b9dc042d2e2 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -266,7 +266,7 @@ enum dpu_intf_mode dpu_crtc_get_intf_mode(struct drm_crtc *crtc) { struct drm_encoder *encoder; - if (!crtc || !crtc->dev) { + if (!crtc) { DPU_ERROR("invalid crtc\n"); return INTF_MODE_NONE; } @@ -694,7 +694,7 @@ static void dpu_crtc_disable(struct drm_crtc *crtc, unsigned long flags; bool release_bandwidth = false; - if (!crtc || !crtc->dev || !crtc->state) { + if (!crtc || !crtc->state) { DPU_ERROR("invalid crtc\n"); return; } @@ -766,7 +766,7 @@ static void dpu_crtc_enable(struct drm_crtc *crtc, struct msm_drm_private *priv; bool request_bandwidth; - if (!crtc || !crtc->dev) { + if (!crtc) { DPU_ERROR("invalid crtc\n"); return; }