diff mbox series

[2/2] MAINTAINERS: Add Jernej Škrabec as a reviewer for DE2

Message ID 20190919173020.11655-2-mripard@kernel.org (mailing list archive)
State New, archived
Headers show
Series [1/2] MAINTAINERS: Update Allwinner DRM drivers entry | expand

Commit Message

Maxime Ripard Sept. 19, 2019, 5:30 p.m. UTC
The newer Allwinner SoCs have a different layers controller than the older
ones. Jernej wrote that support and has been reviewing patches for a while
now, so let's make him a formal reviewer.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Jernej Škrabec Sept. 19, 2019, 6:24 p.m. UTC | #1
Dne četrtek, 19. september 2019 ob 19:30:20 CEST je Maxime Ripard napisal(a):
> The newer Allwinner SoCs have a different layers controller than the older
> ones. Jernej wrote that support and has been reviewing patches for a while
> now, so let's make him a formal reviewer.
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 54e222e1d0d6..fae328f06c17 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5361,6 +5361,15 @@ F:	drivers/gpu/drm/sun4i/
>  F:	Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
>  T:	git git://anongit.freedesktop.org/drm/drm-misc
> 
> +DRM DRIVER FOR ALLWINNER DE2 ENGINE

Please make that DE2 and DE3 engine, they share almost all code.

> +M:	Maxime Ripard <mripard@kernel.org>
> +M:	Chen-Yu Tsai <wens@csie.org>
> +R:	Jernej Škrabec <jernej.skrabec@siol.net>

Please make that "S" for consistency with other entry.

With that:
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

> +L:	dri-devel@lists.freedesktop.org
> +S:	Supported
> +F:	drivers/gpu/drm/sun4i/sun8i*
> +T:	git git://anongit.freedesktop.org/drm/drm-misc
> +
>  DRM DRIVERS FOR AMLOGIC SOCS
>  M:	Neil Armstrong <narmstrong@baylibre.com>
>  L:	dri-devel@lists.freedesktop.org
Daniel Vetter Sept. 19, 2019, 7:39 p.m. UTC | #2
On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard <mripard@kernel.org> wrote:
>
> The newer Allwinner SoCs have a different layers controller than the older
> ones. Jernej wrote that support and has been reviewing patches for a while
> now, so let's make him a formal reviewer.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Haz commit rights already, or do we need to fix that?
-Daniel

> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 54e222e1d0d6..fae328f06c17 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5361,6 +5361,15 @@ F:       drivers/gpu/drm/sun4i/
>  F:     Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
>  T:     git git://anongit.freedesktop.org/drm/drm-misc
>
> +DRM DRIVER FOR ALLWINNER DE2 ENGINE
> +M:     Maxime Ripard <mripard@kernel.org>
> +M:     Chen-Yu Tsai <wens@csie.org>
> +R:     Jernej Škrabec <jernej.skrabec@siol.net>
> +L:     dri-devel@lists.freedesktop.org
> +S:     Supported
> +F:     drivers/gpu/drm/sun4i/sun8i*
> +T:     git git://anongit.freedesktop.org/drm/drm-misc
> +
>  DRM DRIVERS FOR AMLOGIC SOCS
>  M:     Neil Armstrong <narmstrong@baylibre.com>
>  L:     dri-devel@lists.freedesktop.org
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maxime Ripard Sept. 20, 2019, 6:08 a.m. UTC | #3
Hi

On Thu, Sep 19, 2019 at 09:39:19PM +0200, Daniel Vetter wrote:
> On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > The newer Allwinner SoCs have a different layers controller than the older
> > ones. Jernej wrote that support and has been reviewing patches for a while
> > now, so let's make him a formal reviewer.
> >
> > Signed-off-by: Maxime Ripard <mripard@kernel.org>
>
> Haz commit rights already, or do we need to fix that?

He doesn't, as far as I'm remember.

Jernej, do you want to have drm-misc committers rights as well?

Maxime
Jernej Škrabec Sept. 20, 2019, 8:12 p.m. UTC | #4
Dne petek, 20. september 2019 ob 08:08:20 CEST je Maxime Ripard napisal(a):
> Hi
> 
> On Thu, Sep 19, 2019 at 09:39:19PM +0200, Daniel Vetter wrote:
> > On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > The newer Allwinner SoCs have a different layers controller than the
> > > older
> > > ones. Jernej wrote that support and has been reviewing patches for a
> > > while
> > > now, so let's make him a formal reviewer.
> > > 
> > > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > 
> > Haz commit rights already, or do we need to fix that?
> 
> He doesn't, as far as I'm remember.

No, I don't.

> 
> Jernej, do you want to have drm-misc committers rights as well?

I would be nice, yes. Thanks!

Best regards,
Jernej
Maxime Ripard Sept. 23, 2019, 3:31 p.m. UTC | #5
On Thu, Sep 19, 2019 at 08:24:18PM +0200, Jernej Škrabec wrote:
> Dne četrtek, 19. september 2019 ob 19:30:20 CEST je Maxime Ripard napisal(a):
> > The newer Allwinner SoCs have a different layers controller than the older
> > ones. Jernej wrote that support and has been reviewing patches for a while
> > now, so let's make him a formal reviewer.
> >
> > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > ---
> >  MAINTAINERS | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 54e222e1d0d6..fae328f06c17 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -5361,6 +5361,15 @@ F:	drivers/gpu/drm/sun4i/
> >  F:	Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> >  T:	git git://anongit.freedesktop.org/drm/drm-misc
> >
> > +DRM DRIVER FOR ALLWINNER DE2 ENGINE
>
> Please make that DE2 and DE3 engine, they share almost all code.
>
> > +M:	Maxime Ripard <mripard@kernel.org>
> > +M:	Chen-Yu Tsai <wens@csie.org>
> > +R:	Jernej Škrabec <jernej.skrabec@siol.net>
>
> Please make that "S" for consistency with other entry.
>
> With that:
> Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Applied both patches, with your suggestions.

Thanks, and welcome to the team :)

Maxime
Maxime Ripard Sept. 23, 2019, 3:32 p.m. UTC | #6
On Fri, Sep 20, 2019 at 10:12:30PM +0200, Jernej Škrabec wrote:
> Dne petek, 20. september 2019 ob 08:08:20 CEST je Maxime Ripard napisal(a):
> > Hi
> >
> > On Thu, Sep 19, 2019 at 09:39:19PM +0200, Daniel Vetter wrote:
> > > On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > > The newer Allwinner SoCs have a different layers controller than the
> > > > older
> > > > ones. Jernej wrote that support and has been reviewing patches for a
> > > > while
> > > > now, so let's make him a formal reviewer.
> > > >
> > > > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > >
> > > Haz commit rights already, or do we need to fix that?
> >
> > He doesn't, as far as I'm remember.
>
> No, I don't.
>
> >
> > Jernej, do you want to have drm-misc committers rights as well?
>
> I would be nice, yes. Thanks!

You have everything needed (hopefully) there:
https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html

Once you have requested the account, please let us know so that we can
ack it and move forward in the process.

Maxime
Jernej Škrabec Sept. 23, 2019, 6:59 p.m. UTC | #7
Dne ponedeljek, 23. september 2019 ob 17:32:53 CEST je Maxime Ripard 
napisal(a):
> On Fri, Sep 20, 2019 at 10:12:30PM +0200, Jernej Škrabec wrote:
> > Dne petek, 20. september 2019 ob 08:08:20 CEST je Maxime Ripard 
napisal(a):
> > > Hi
> > > 
> > > On Thu, Sep 19, 2019 at 09:39:19PM +0200, Daniel Vetter wrote:
> > > > On Thu, Sep 19, 2019 at 7:30 PM Maxime Ripard <mripard@kernel.org> 
wrote:
> > > > > The newer Allwinner SoCs have a different layers controller than the
> > > > > older
> > > > > ones. Jernej wrote that support and has been reviewing patches for a
> > > > > while
> > > > > now, so let's make him a formal reviewer.
> > > > > 
> > > > > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> > > > 
> > > > Haz commit rights already, or do we need to fix that?
> > > 
> > > He doesn't, as far as I'm remember.
> > 
> > No, I don't.
> > 
> > > Jernej, do you want to have drm-misc committers rights as well?
> > 
> > I would be nice, yes. Thanks!
> 
> You have everything needed (hopefully) there:
> https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html
> 
> Once you have requested the account, please let us know so that we can
> ack it and move forward in the process.

Here it is: https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/192

Thanks!

Best regards,
Jernej
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 54e222e1d0d6..fae328f06c17 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5361,6 +5361,15 @@  F:	drivers/gpu/drm/sun4i/
 F:	Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 
+DRM DRIVER FOR ALLWINNER DE2 ENGINE
+M:	Maxime Ripard <mripard@kernel.org>
+M:	Chen-Yu Tsai <wens@csie.org>
+R:	Jernej Škrabec <jernej.skrabec@siol.net>
+L:	dri-devel@lists.freedesktop.org
+S:	Supported
+F:	drivers/gpu/drm/sun4i/sun8i*
+T:	git git://anongit.freedesktop.org/drm/drm-misc
+
 DRM DRIVERS FOR AMLOGIC SOCS
 M:	Neil Armstrong <narmstrong@baylibre.com>
 L:	dri-devel@lists.freedesktop.org